Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Ilya Maximets
On 4/10/24 18:24, Simon Horman wrote: > On Wed, Apr 10, 2024 at 02:10:20PM +0200, Ilya Maximets wrote: >> On 4/6/24 00:08, Ilya Maximets wrote: >>> Currently, calls like ovs_assert() just print out a condition that >>> caused assertion to fail. But it may be not enough to understand what >>>

Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Simon Horman
On Wed, Apr 10, 2024 at 02:10:20PM +0200, Ilya Maximets wrote: > On 4/6/24 00:08, Ilya Maximets wrote: > > Currently, calls like ovs_assert() just print out a condition that > > caused assertion to fail. But it may be not enough to understand what > > exactly has happened, especially if assertion

Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Kevin Traynor
On 10/04/2024 16:16, Ilya Maximets wrote: > On 4/10/24 17:01, Kevin Traynor wrote: >> On 05/04/2024 23:08, Ilya Maximets wrote: >>> Currently, calls like ovs_assert() just print out a condition that >>> caused assertion to fail. But it may be not enough to understand what >>> exactly has

Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Ilya Maximets
On 4/10/24 17:01, Kevin Traynor wrote: > On 05/04/2024 23:08, Ilya Maximets wrote: >> Currently, calls like ovs_assert() just print out a condition that >> caused assertion to fail. But it may be not enough to understand what >> exactly has happened, especially if assertion failed in some generic

Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Kevin Traynor
On 05/04/2024 23:08, Ilya Maximets wrote: > Currently, calls like ovs_assert() just print out a condition that > caused assertion to fail. But it may be not enough to understand what > exactly has happened, especially if assertion failed in some generic > function like dp_packet_resize() or

Re: [ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-10 Thread Ilya Maximets
On 4/6/24 00:08, Ilya Maximets wrote: > Currently, calls like ovs_assert() just print out a condition that > caused assertion to fail. But it may be not enough to understand what > exactly has happened, especially if assertion failed in some generic > function like dp_packet_resize() or similar.

[ovs-dev] [PATCH] vlog: Log stack trace on vlog_abort.

2024-04-05 Thread Ilya Maximets
Currently, calls like ovs_assert() just print out a condition that caused assertion to fail. But it may be not enough to understand what exactly has happened, especially if assertion failed in some generic function like dp_packet_resize() or similar. Print the stack trace along with the abort