Re: [ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

2017-06-07 Thread Ben Pfaff
On Wed, Jun 07, 2017 at 11:26:56AM -0700, Andy Zhou wrote: > On Tue, Jun 6, 2017 at 4:55 PM, Ben Pfaff wrote: > > On Fri, May 26, 2017 at 08:47:44PM -0700, Andy Zhou wrote: > >> There are three methods of translating openflow layer clone action. > >> Using datapath clone action,

Re: [ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

2017-06-07 Thread Andy Zhou
On Tue, Jun 6, 2017 at 4:55 PM, Ben Pfaff wrote: > On Fri, May 26, 2017 at 08:47:44PM -0700, Andy Zhou wrote: >> There are three methods of translating openflow layer clone action. >> Using datapath clone action, datapath sample action or using actions >> to negating the any changes

Re: [ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

2017-06-06 Thread Ben Pfaff
On Tue, Jun 06, 2017 at 04:55:19PM -0700, Ben Pfaff wrote: > I think that this implementation fails when it chooses > COMPOSE_CLONE_USING_ACTIONS, because in that case it does not save and > restore the base flow. I see now that I misunderstood. Never mind, on this point.

Re: [ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

2017-06-06 Thread Ben Pfaff
On Fri, May 26, 2017 at 08:47:44PM -0700, Andy Zhou wrote: > There are three methods of translating openflow layer clone action. > Using datapath clone action, datapath sample action or using actions > to negating the any changes within a clone. Xlate logic selects > a specific method depends on

[ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

2017-05-26 Thread Andy Zhou
There are three methods of translating openflow layer clone action. Using datapath clone action, datapath sample action or using actions to negating the any changes within a clone. Xlate logic selects a specific method depends on datapath features detected at the boot time. Currently only