Re: [ovs-dev] [PATCH 2/2] Eliminate most shadowing for local variable names.

2017-08-02 Thread Andy Zhou
On Wed, Aug 2, 2017 at 8:56 AM, Ben Pfaff wrote: > Shadowing is when a variable with a given name in an inner scope hides a > different variable with the same name in a surrounding scope. This is > generally undesirable because it can confuse programmers. This commit > eliminates

[ovs-dev] [PATCH 2/2] Eliminate most shadowing for local variable names.

2017-08-02 Thread Ben Pfaff
Shadowing is when a variable with a given name in an inner scope hides a different variable with the same name in a surrounding scope. This is generally undesirable because it can confuse programmers. This commit eliminates most of it. Found with -Wshadow=local in GCC 7. The repo is not really