Re: [ovs-dev] [PATCH ovn v4] Make tunnel ids exhaustion test trigger the problem.

2024-04-11 Thread Ihar Hrachyshka
Series with this patch that also fixes ubsan failure here: https://patchwork.ozlabs.org/project/ovn/list/?series=402694 On Mon, Apr 8, 2024 at 9:49 AM Ihar Hrachyshka wrote: > Note to reviewers: looks like the port tunnel id test case revealed a > number of undefined behaviors and leaks (?) in

Re: [ovs-dev] [PATCH ovn v4] Make tunnel ids exhaustion test trigger the problem.

2024-04-08 Thread Ihar Hrachyshka
Note to reviewers: looks like the port tunnel id test case revealed a number of undefined behaviors and leaks (?) in northd; I am working on addressing these. Before that, we should not merge this patch as-is. (Or at least we should not merge the part with the port case; I believe the network case

Re: [ovs-dev] [PATCH ovn v4] Make tunnel ids exhaustion test trigger the problem.

2024-04-06 Thread Vladislav Odintsov
Hi Ihar, Thanks for cooperation and enhancements in the testcases! The patch looks good to me. > On 5 Apr 2024, at 19:14, Ihar Hrachyshka wrote: > > The original version of the scenario passed with or without the fix. > This is because all LSs were processed in one go, so the allocate >

[ovs-dev] [PATCH ovn v4] Make tunnel ids exhaustion test trigger the problem.

2024-04-05 Thread Ihar Hrachyshka
The original version of the scenario passed with or without the fix. This is because all LSs were processed in one go, so the allocate function was never entered with *hint==0. Also, added another scenario that will check behavior when *hint is out of [min;max] bounds but > max (this happens in