Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-11 Thread Simon Horman
On Wed, Jan 10, 2024 at 05:49:58PM +, Simon Horman wrote: > On Wed, Jan 10, 2024 at 06:38:48PM +0100, Ilya Maximets wrote: > > On 1/10/24 18:18, Simon Horman wrote: > > > On Wed, Jan 10, 2024 at 12:28:22PM +0100, Dumitru Ceara wrote: ... > > >> TBH I'd just apply both this patch and the test

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-10 Thread Simon Horman
On Wed, Jan 10, 2024 at 06:38:48PM +0100, Ilya Maximets wrote: > On 1/10/24 18:18, Simon Horman wrote: > > On Wed, Jan 10, 2024 at 12:28:22PM +0100, Dumitru Ceara wrote: > >> On 1/8/24 16:31, Ilya Maximets wrote: > >>> On 1/8/24 16:05, Ilya Maximets wrote: > On 1/5/24 18:35, Terry Wilson

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-10 Thread Ilya Maximets
On 1/10/24 18:18, Simon Horman wrote: > On Wed, Jan 10, 2024 at 12:28:22PM +0100, Dumitru Ceara wrote: >> On 1/8/24 16:31, Ilya Maximets wrote: >>> On 1/8/24 16:05, Ilya Maximets wrote: On 1/5/24 18:35, Terry Wilson wrote: > On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote: >>

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-10 Thread Simon Horman
On Wed, Jan 10, 2024 at 12:28:22PM +0100, Dumitru Ceara wrote: > On 1/8/24 16:31, Ilya Maximets wrote: > > On 1/8/24 16:05, Ilya Maximets wrote: > >> On 1/5/24 18:35, Terry Wilson wrote: > >>> On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote: > > On Mon, Dec 18, 2023 at 05:31:24PM

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-10 Thread Dumitru Ceara
On 1/8/24 16:31, Ilya Maximets wrote: > On 1/8/24 16:05, Ilya Maximets wrote: >> On 1/5/24 18:35, Terry Wilson wrote: >>> On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote: On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote: > Currently python-ovs claims to be "db change

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-10 Thread Dumitru Ceara
On 12/19/23 00:31, Terry Wilson wrote: > Currently python-ovs claims to be "db change aware" but does not > parse the "monitor_canceled" notification. Transactions can continue > being made, but the monitor updates will not be sent. This handles > monitor_cancel similarly to how ovsdb-cs currently

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-08 Thread Ilya Maximets
On 1/8/24 16:05, Ilya Maximets wrote: > On 1/5/24 18:35, Terry Wilson wrote: >> On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote: >>> >>> On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote: Currently python-ovs claims to be "db change aware" but does not parse the

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-08 Thread Ilya Maximets
On 1/5/24 18:35, Terry Wilson wrote: > On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote: >> >> On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote: >>> Currently python-ovs claims to be "db change aware" but does not >>> parse the "monitor_canceled" notification. Transactions can

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-05 Thread Terry Wilson
On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote: > > On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote: > > Currently python-ovs claims to be "db change aware" but does not > > parse the "monitor_canceled" notification. Transactions can continue > > being made, but the monitor

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2024-01-05 Thread Simon Horman
On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote: > Currently python-ovs claims to be "db change aware" but does not > parse the "monitor_canceled" notification. Transactions can continue > being made, but the monitor updates will not be sent. This handles > monitor_cancel similarly to

Re: [ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2023-12-18 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: python: idl: Handle

[ovs-dev] [PATCH v2] python: idl: Handle monitor_canceled

2023-12-18 Thread Terry Wilson
Currently python-ovs claims to be "db change aware" but does not parse the "monitor_canceled" notification. Transactions can continue being made, but the monitor updates will not be sent. This handles monitor_cancel similarly to how ovsdb-cs currently does. Signed-off-by: Terry Wilson ---