Re: [ovs-dev] [PATCH v2 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-06 Thread Ilya Maximets
On 6/2/22 16:34, Terry Wilson wrote: > Since pids can be re-used, it is necessary to check that the > process that is running with a pid matches the one that we expect. > > This adds the ability to optionally pass a 'binary' argument to > pidfile_is_running, and if it is passed to match the

Re: [ovs-dev] [PATCH v2 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-02 Thread Ihar Hrachyshka
On Thu, Jun 2, 2022 at 10:34 AM Terry Wilson wrote: > > Since pids can be re-used, it is necessary to check that the > process that is running with a pid matches the one that we expect. > > This adds the ability to optionally pass a 'binary' argument to > pidfile_is_running, and if it is passed

Re: [ovs-dev] [PATCH v2 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-02 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 124 characters long (recommended limit is 79) #36 FILE: utilities/ovn-ctl:52:

[ovs-dev] [PATCH v2 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-02 Thread Terry Wilson
Since pids can be re-used, it is necessary to check that the process that is running with a pid matches the one that we expect. This adds the ability to optionally pass a 'binary' argument to pidfile_is_running, and if it is passed to match the binary against /proc/$pid/exe. Signed-off-by: Terry