Re: [ovs-dev] [PATCH v5 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-13 Thread Ihar Hrachyshka
Ouch. I believe this should do: https://patchwork.ozlabs.org/project/ovn/patch/20220613185922.2700748-1-ihrac...@redhat.com/ Ihar On Mon, Jun 13, 2022 at 1:47 PM Numan Siddique wrote: > > On Thu, Jun 9, 2022 at 2:47 PM Mark Michelson wrote: > > > > I added Ihar's Ack and my Ack to both patches

Re: [ovs-dev] [PATCH v5 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-13 Thread Numan Siddique
On Thu, Jun 9, 2022 at 2:47 PM Mark Michelson wrote: > > I added Ihar's Ack and my Ack to both patches and pushed them to main, > branch-22.06, branch-22.03, and branch-21.12. > Looks like this patch or the other one has caused regressions. "ovn-ctl start_northd" is not starting ovn-northd. --

Re: [ovs-dev] [PATCH v5 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-09 Thread Mark Michelson
I added Ihar's Ack and my Ack to both patches and pushed them to main, branch-22.06, branch-22.03, and branch-21.12. On 6/8/22 09:29, Terry Wilson wrote: Since pids can be re-used, it is necessary to check that the process that is running with a pid matches the one that we expect. This adds

Re: [ovs-dev] [PATCH v5 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-08 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 135 characters long (recommended limit is 79) #28 FILE: utilities/ovn-ctl:46:

[ovs-dev] [PATCH v5 ovn 1/2] Handle re-used pids in pidfile_is_running

2022-06-08 Thread Terry Wilson
Since pids can be re-used, it is necessary to check that the process that is running with a pid matches the one that we expect. This adds the ability to optionally pass a 'binary' argument to pidfile_is_running, and if it is passed to match the binary against /proc/$pid/exe. Signed-off-by: Terry