Thanks for the feedback Ales, Dumitru. I'm back from vacation so I'm again
focusing on this change.
On Tue, Apr 2, 2024 at 5:33 PM Dumitru Ceara wrote:
> On 3/20/24 12:20, Ales Musil wrote:
> > On Tue, Mar 12, 2024 at 9:18 PM Martin Kalcok <
> martin.kal...@canonical.com>
> > wrote:
> >
> > Hi
On 3/20/24 12:20, Ales Musil wrote:
> On Tue, Mar 12, 2024 at 9:18 PM Martin Kalcok
> wrote:
>
> Hi Martin,
>
Hi Ales, Martin, Numan,
> sorry for the late reply.
>
Sorry for jumping in late in the discussion.
> Following up on the comments from v1.
>>
>> @amusil You were right that the
On 3/13/24 10:27, Martin Kalcok wrote:
> On Tue, Mar 12, 2024 at 9:17 PM Martin Kalcok
> wrote:
>
>> Following up on the comments from v1.
>>
>> @amusil You were right that the struct in actions.h was not necessary
>> then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1`
>>
On Tue, Mar 12, 2024 at 9:18 PM Martin Kalcok
wrote:
Hi Martin,
sorry for the late reply.
Following up on the comments from v1.
>
> @amusil You were right that the struct in actions.h was not necessary
> then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1`
> function and
On Tue, Mar 12, 2024 at 9:17 PM Martin Kalcok
wrote:
> Following up on the comments from v1.
>
> @amusil You were right that the struct in actions.h was not necessary
> then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1`
> function and for that I think the struct is
Following up on the comments from v1.
@amusil You were right that the struct in actions.h was not necessary then.
However I also noticed that I forgot to modify `format_CT_COMMIT_V1`
function and for that I think the struct is necessary. I need to
distinguish whether the `ct_commit` action was
Bleep bloop. Greetings Martin Kalcok, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#223 FILE: ovn-sb.xml:1431:
Action `ct_commit` currently does not allow specifying zone into
which connection is committed. For example, in LR datapath, the `ct_commit`
will always use the DNAT zone.
This change adds option to use `ct_commit(snat)` or `ct_commit(dnat)` to
explicitly specify the zone into which the
