Re: [ovs-dev] [patch v1] conntrack: Fix 'check_orig_tuple()' Valgrind false positive.

2019-09-24 Thread Ben Pfaff
Done! On Tue, Sep 24, 2019 at 02:56:40PM -0700, Darrell Ball wrote: > Thanks Ben > > Would you mind applying to 2.12 as well. > > Darrell > > On Tue, Sep 24, 2019 at 2:34 PM Ben Pfaff wrote: > > > On Mon, Sep 23, 2019 at 04:44:33PM -0700, Darrell Ball wrote: > > > Valgrind reported that

Re: [ovs-dev] [patch v1] conntrack: Fix 'check_orig_tuple()' Valgrind false positive.

2019-09-24 Thread Darrell Ball
Thanks Ben Would you mind applying to 2.12 as well. Darrell On Tue, Sep 24, 2019 at 2:34 PM Ben Pfaff wrote: > On Mon, Sep 23, 2019 at 04:44:33PM -0700, Darrell Ball wrote: > > Valgrind reported that 'pkt->md.ct_orig_tuple.ipv4.ipv4_proto' is > > uninitialized in 'check_orig_tuple()', if

Re: [ovs-dev] [patch v1] conntrack: Fix 'check_orig_tuple()' Valgrind false positive.

2019-09-24 Thread Ben Pfaff
On Mon, Sep 23, 2019 at 04:44:33PM -0700, Darrell Ball wrote: > Valgrind reported that 'pkt->md.ct_orig_tuple.ipv4.ipv4_proto' is > uninitialized in 'check_orig_tuple()', if 'ct_state' is zero. Although > this is true, the check is superceded, as even if it succeeds the check > for natted packets

[ovs-dev] [patch v1] conntrack: Fix 'check_orig_tuple()' Valgrind false positive.

2019-09-23 Thread Darrell Ball
Valgrind reported that 'pkt->md.ct_orig_tuple.ipv4.ipv4_proto' is uninitialized in 'check_orig_tuple()', if 'ct_state' is zero. Although this is true, the check is superceded, as even if it succeeds the check for natted packets based on 'ct_state' is an ORed condition and is intended to catch