Re: [ovs-dev] [PATCH ovn] controller: ofctrl: Use index for meter lookups.

2024-02-26 Thread Han Zhou
On Mon, Feb 26, 2024 at 9:44 AM Ilya Maximets wrote: > > Currently, ovn-controller attempts to sync all the meters on each > ofctrl_put() call. And the complexity of this logic is quadratic > because for each desired meter we perform a full scan of all the > rows in the Southbound Meter table in

[ovs-dev] [PATCH v7 2/2] ofproto-dpif-mirror: Add support for pre-selection filter.

2024-02-26 Thread Mike Pattrick
Currently a bridge mirror will collect all packets and tools like ovs-tcpdump can apply additional filters after they have already been duplicated by vswitchd. This can result in inefficient collection. This patch adds support to apply pre-selection to bridge mirrors, which can limit which

[ovs-dev] [PATCH v7 1/2] ofproto-dpif-mirror: Reduce number of function parameters.

2024-02-26 Thread Mike Pattrick
Previously the mirror_set() and mirror_get() functions took a large number of parameters, which was inefficient and difficult to read and extend. This patch moves most of the parameters into a struct. Signed-off-by: Mike Pattrick Acked-by: Simon Horman Acked-by: Eelco Chaudron ---

Re: [ovs-dev] [PATCH ovn] controller: ofctrl: Use index for meter lookups.

2024-02-26 Thread Ilya Maximets
On 2/26/24 18:44, Ilya Maximets wrote: > Currently, ovn-controller attempts to sync all the meters on each > ofctrl_put() call. And the complexity of this logic is quadratic > because for each desired meter we perform a full scan of all the > rows in the Southbound Meter table in order to lookup

[ovs-dev] [PATCH ovn] controller: ofctrl: Use index for meter lookups.

2024-02-26 Thread Ilya Maximets
Currently, ovn-controller attempts to sync all the meters on each ofctrl_put() call. And the complexity of this logic is quadratic because for each desired meter we perform a full scan of all the rows in the Southbound Meter table in order to lookup a matching meter. This is very inefficient.

Re: [ovs-dev] [PATCH OVN] DHCP Relay Agent support for overlay subnets

2024-02-26 Thread Naveen Yerramneni
> On 24-Jan-2024, at 6:30 PM, Naveen Yerramneni > wrote: > > > >> On 24-Jan-2024, at 8:59 AM, Numan Siddique wrote: >> >> On Tue, Jan 23, 2024 at 8:02 PM Naveen Yerramneni >> wrote: >>> >>> >>> On 16-Jan-2024, at 2:30 AM, Numan Siddique wrote: On Tue, Dec 12, 2023 at

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Stop dropping bind_vport requests immediately after handling.

2024-02-26 Thread 0-day Robot
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject, ': ', is over 70 characters, i.e., 77. Subject: ovn-controller: Stop

Re: [ovs-dev] [PATCH ovn] ovn-controller: Stop dropping bind_vport requests immediately after handling.

2024-02-26 Thread Mohammad Heib
Hi Ales, Thank you for the review i addressed all your comments in v2. regarding the test actually, it's a bit hard to test that using a unit test because we need to let ovn-sb ignore the first binding request which is not applicable using a unit test, i was testing that manually by dropping the

[ovs-dev] [PATCH ovn v2] ovn-controller: Stop dropping bind_vport requests immediately after handling.

2024-02-26 Thread Mohammad Heib
ovn-controller immediately removes the vport_bindings requests that were generated by VIFs after handling them locally, this approach is intended to avoid binding the vport to one VIF only and allocate the vport between the different VIFs that exist in the vport:virtual-parents. Although the

[ovs-dev] [PATCH v2] dp-packet: Don't offload inner csum if outer isn't supported.

2024-02-26 Thread Mike Pattrick
Some network cards support inner checksum offloading but not outer checksum offloading. Currently OVS will resolve that outer checksum but allows the network card to resolve the inner checksum, invalidating the outer checksum in the process. Now if we can't offload outer checksums, we don't

[ovs-dev] [PATCH ovn v3] OVN-SB: Exposes igmp group protocol version through IGMP table.

2024-02-26 Thread Mohammad Heib
Expose the igmp/mld group protocol version through the IGMP_GROUP table in SBDB. This patch can be used by ovn consumer for debuggability purposes, user now can match between the protocol version used in the OVN logical switches and the uplink ports. Rreported-at:

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Fix infinite recirculation tracing.

2024-02-26 Thread Simon Horman
On Thu, Feb 22, 2024 at 04:06:32PM +0100, Ilya Maximets wrote: > Trace attempts to process all the recirculations. However, if there > is a recirculation loop, i.e. if every recirculation generates another > recirculation, this process will never stop. It will grind until the > trace fills the

[ovs-dev] [PATCH ovn] northd: Don't skip the unSNAT stage for traffic towards VIPs.

2024-02-26 Thread Dumitru Ceara
Otherwise, in case there's also a SNAT rule that uses the VIP as external IP, we break sessions initiated from behind the VIP. This partially reverts 832893bdbb42 ("ovn-northd: Skip unsnat flows for load balancer vips in router ingress pipeline"). That's OK because commit 384a7c6237da ("northd:

[ovs-dev] [PATCH v2] conntrack: Fix flush not flushing all elements.

2024-02-26 Thread Xavier Simonart
On netdev datapath, when a ct element was cleaned, the cmap could be shrinked, potentially causing some elements to be skipped in the flush iteration. Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.") Signed-off-by: Xavier Simonart --- v2: - Updated commit message. - Use compose-packet

[ovs-dev] [PATCH v5 1/2] util: Support checking for kernel versions.

2024-02-26 Thread Felix Huettner via dev
Extract checking for a given kernel version to a separate function. It will be used also in the next patch. Signed-off-by: Felix Huettner --- v4->v5: - fix wrong ifdef that broke on macos - fix ovs_kernel_is_version_or_newer working in reverse than desired - ovs_kernel_is_version_or_newer now

[ovs-dev] [PATCH v5 2/2] netlink-conntrack: Optimize flushing ct zone.

2024-02-26 Thread Felix Huettner via dev
Previously the kernel did not provide a netlink interface to flush/list only conntrack entries matching a specific zone. With [1] and [2] it is now possible to flush and list conntrack entries filtered by zone. Older kernels not yet supporting this feature will ignore the filter. For the list