On Wed, Mar 6, 2024 at 7:26 AM Martin Kalcok
wrote:
> Hi Ales,
> Thank you for review and helpful comments. I'll update commit subjects for
> this series in v2.
>
> On Wed, Mar 6, 2024 at 7:45 AM Ales Musil wrote:
>
>>
>>
>> On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok <
>>
Previously when an empty mutation was used to count the number of rows
in a table, OVSDB would iterate over all rows twice. First to perform an
RBAC check, and then to perform the no-operation.
This change adds a short circuit to mutate operations with no conditions
and an empty mutation set,
On 2/27/24 20:14, Han Zhou wrote:
> For kernel datapath, when a new tunnel port is created in the same
> transaction in which an old tunnel port with the same tunnel
> configuration is deleted, the new tunnel port creation will fail and
> left in an error state. This can be easily reproduced in
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
> On 18-Dec-2023, at 8:53 PM, Dumitru Ceara wrote:
>
> On 12/18/23 16:17, Naveen Yerramneni wrote:
>>
>>
>>> On 18-Dec-2023, at 7:26 PM, Dumitru Ceara wrote:
>>>
>>> On 11/30/23 16:32, Dumitru Ceara wrote:
On 11/30/23 15:54, Naveen Yerramneni wrote:
>
>
>> On
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
On 3/5/24 15:56, Numan Siddique wrote:
> On Mon, Feb 26, 2024 at 7:59 AM Dumitru Ceara wrote:
>>
>> Otherwise, in case there's also a SNAT rule that uses the VIP as
>> external IP, we break sessions initiated from behind the VIP.
>>
>> This partially reverts 832893bdbb42 ("ovn-northd: Skip unsnat
From: Xavier Simonart
On netdev datapath, when a ct element was cleaned, the cmap
could be shrinked, potentially causing some elements to be skipped
in the flush iteration.
Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Xavier Simonart
Acked-by: Mike Pattrick
From: Xavier Simonart
On netdev datapath, when a ct element was cleaned, the cmap
could be shrinked, potentially causing some elements to be skipped
in the flush iteration.
Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Xavier Simonart
Acked-by: Mike Pattrick
+ Xavier Simonart
Mike Pattrick
On Wed, Mar 06, 2024 at 06:21:36PM +, 'Simon Horman' wrote:
> From: Xavier Simonart
>
> On netdev datapath, when a ct element was cleaned, the cmap
> could be shrinked, potentially causing some elements to be skipped
> in the flush
On Wed, Mar 06, 2024 at 12:34:07PM -0500, Eric Garver wrote:
> Kernel support has been added for this action. As such, we need to probe
> the datapath for support.
>
> Signed-off-by: Eric Garver
> ---
> include/linux/openvswitch.h | 2 +-
> lib/dpif.c | 6 ---
> lib/dpif.h
Bleep bloop. Greetings 'Simon Horman', I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
From: Xavier Simonart
On netdev datapath, when a ct element was cleaned, the cmap
could be shrinked, potentially causing some elements to be skipped
in the flush iteration.
Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Xavier Simonart
Acked-by: Mike Pattrick
Bleep bloop. Greetings 'Simon Horman', I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
+ Aaron Conole
Frode Nordahl
Mike Pattrick
Paolo Valerio
Xavier Simonart
On Wed, Mar 06, 2024 at 06:11:08PM +, 'Simon Horman' wrote:
> Backport to branch-3.20 of:
s/branch-3.20/branch-3.2/
> - conntrack: Fix flush not flushing all elements.
>
Bleep bloop. Greetings 'Simon Horman', I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
Simon Horman writes:
> + Xavier
>
> On Thu, Aug 31, 2023 at 02:52:59PM -0400, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>> > On 8/31/23 09:15, Frode Nordahl wrote:
>> >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote:
>> >>>
>> >>> From: hepeng
>> >>>
>> >>> The patch avoids the
From: Peng He
The patch avoids the extra allocation for nat_conn.
Currently, when doing NAT, the userspace conntrack will use an extra
conn for the two directions in a flow. However, each conn has actually
the two keys for both orig and rev directions. This patch introduces a
key_node[CT_DIRS]
Backport to branch-3.20 of:
- conntrack: Fix flush not flushing all elements.
https://github.com/openvswitch/ovs/commit/6c082a8310d5
Including dependency which is not present in branch-3.2.
---
Peng He (1):
conntrack: Remove nat_conn introducing key directionality.
Xavier Simonart (1):
From: Xavier Simonart
On netdev datapath, when a ct element was cleaned, the cmap
could be shrinked, potentially causing some elements to be skipped
in the flush iteration.
Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Xavier Simonart
Acked-by: Mike Pattrick
On Mon, Mar 04, 2024 at 11:18:22AM -0500, Mike Pattrick wrote:
> On Mon, Mar 4, 2024 at 10:22 AM Xavier Simonart wrote:
> >
> > On netdev datapath, when a ct element was cleaned, the cmap
> > could be shrinked, potentially causing some elements to be skipped
> > in the flush iteration.
> >
> >
+ Xavier
On Thu, Aug 31, 2023 at 02:52:59PM -0400, Aaron Conole wrote:
> Ilya Maximets writes:
>
> > On 8/31/23 09:15, Frode Nordahl wrote:
> >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote:
> >>>
> >>> From: hepeng
> >>>
> >>> The patch avoids the extra allocation for nat_conn.
> >>>
Exercise the drop action in the datapath. This specific tests triggers
an xlate_error.
For the kernel datapath skb drop reasons can then be seen while this
test runs.
# perf trace -e skb:kfree_skb --filter="reason >= 0x3"
0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \
The next commit will convert a dp feature from bool to atomic_bool. As
such we have to add support to the macros and functions. We must pass by
reference instead of pass by value because all the atomic operations
require a reference.
Signed-off-by: Eric Garver
---
ofproto/ofproto-dpif.c | 52
Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP. Also
add a new test case.
v8:
- new patch to support atomic_bool dpif field types
- re-add re-probe of support
- use atomic_bool type for explicit_drop_action
v7:
- remove re-probe of support as Ilya is working on a
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
Kernel support has been added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 ---
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 89
On Mon, Mar 4, 2024 at 3:22 AM Felix Huettner via dev
wrote:
>
> Previously the kernel did not provide a netlink interface to flush/list
> only conntrack entries matching a specific zone. With [1] and [2] it is now
> possible to flush and list conntrack entries filtered by zone. Older
> kernels
On Wed, Mar 6, 2024 at 1:50 PM Martin Kalcok
wrote:
>
> Thanks for reviewing this as well, Ales.
>
> On Wed, Mar 6, 2024 at 8:08 AM Ales Musil wrote:
>
>>
>>
>> On Wed, Mar 6, 2024 at 8:07 AM Ales Musil wrote:
>>
>>>
>>>
>>> On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok <
>>>
Thanks for reviewing this as well, Ales.
On Wed, Mar 6, 2024 at 8:08 AM Ales Musil wrote:
>
>
> On Wed, Mar 6, 2024 at 8:07 AM Ales Musil wrote:
>
>>
>>
>> On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok <
>> martin.kal...@canonical.com> wrote:
>>
>>> This change fixes bug that breaks ability of
Hi Ales,
Thank you for review and helpful comments. I'll update commit subjects for
this series in v2.
On Wed, Mar 6, 2024 at 7:45 AM Ales Musil wrote:
>
>
> On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok
> wrote:
>
>> Action `ct_commit` currently does not allow specifying zone into
>> which
On Fri, Mar 01, 2024 at 02:50:29PM +, Simon Horman wrote:
> Recently OVS adopted a policy of using the inclusive naming word list v1
> [1, 2].
>
> This patch-set addresses some uses of the terms master and slave
> by using alternate terms.
>
> These changes are not intended to have any
On Fri, Mar 01, 2024 at 05:41:44PM +0100, Eelco Chaudron wrote:
>
>
> On 1 Mar 2024, at 15:50, Simon Horman wrote:
>
> > Recently OVS adopted a policy of using the inclusive naming word list v1
> > [1, 2].
> >
> > This patch partially addresses the use of the term master in the
> > context of
On Tue, Mar 05, 2024 at 04:08:19PM +, Kevin Traynor wrote:
> On 01/03/2024 14:50, Simon Horman wrote:
> > Recently OVS adopted a policy of using the inclusive naming word list v1
> > [1, 2].
> >
> > This patch-set addresses some uses of the terms master and slave
> > by using alternate terms.
34 matches
Mail list logo
