Re: [ovs-dev] Asan+Ubsan tests are crashing all the tests with new 20240310.1.0 GHA images

On 3/11/24 21:00, Ilya Maximets wrote: > On 3/11/24 20:47, Ilya Maximets wrote: >> Something strange is happening. Every single test fails if >> clang with asan+ubsan tests are running on 20240310.1.0 image. >> >> Example: https://github.com/ovsrobot/ovs/actions/runs/8237626849 >> >> Every built

Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

I pushed this to main and branch-24.03. On 3/11/24 11:02, Mark Michelson wrote: Thanks for fixing the crash, and thanks for taking the extra effort to ensure BFD tests are run by CI. Acked-by: Mark Michelson On 3/11/24 10:48, Ales Musil wrote: The cb_bt pointer was pointing to different

Re: [ovs-dev] Asan+Ubsan tests are crashing all the tests with new 20240310.1.0 GHA images

On 3/11/24 20:47, Ilya Maximets wrote: > Something strange is happening. Every single test fails if > clang with asan+ubsan tests are running on 20240310.1.0 image. > > Example: https://github.com/ovsrobot/ovs/actions/runs/8237626849 > > Every built binary appears to be crashing. For exmple: >

Re: [ovs-dev] Asan+Ubsan tests are crashing all the tests with new 20240310.1.0 GHA images

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject, ': ', is over 70 characters, i.e., 76. WARNING: The subject summary

[ovs-dev] Asan+Ubsan tests are crashing all the tests with new 20240310.1.0 GHA images

Something strange is happening. Every single test fails if clang with asan+ubsan tests are running on 20240310.1.0 image. Example: https://github.com/ovsrobot/ovs/actions/runs/8237626849 Every built binary appears to be crashing. For exmple: # -*- compilation -*-

[ovs-dev] [PATCH] netdev-dpdk: Clean up all marker flags if no offloads requested.

Some drivers (primarily, Intel ones) do not expect any marking flags being set if no offloads are requested. If these flags are present, driver will fail Tx preparation or behave abnormally. For example, ixgbe driver will refuse to process the packet with only RTE_MBUF_F_TX_TUNNEL_GENEVE and

[ovs-dev] [PATCH v11 1/5] dpif: Stub out unimplemented action OVS_ACTION_ATTR_DEC_TTL.

This is prep for adding a different OVS_ACTION_ATTR_ enum value. This action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However, to make -Werror happy we must add a case to all existing switches. Signed-off-by: Eric Garver --- include/linux/openvswitch.h | 1 + lib/dpif-netdev.c

[ovs-dev] [PATCH v11 5/5] tests: system-traffic: Add coverage for drop action.

Exercise the drop action in the datapath. This specific tests triggers an xlate_error. For the kernel datapath skb drop reasons can then be seen while this test runs. # perf trace -e skb:kfree_skb --filter="reason >= 0x3" 0.000 ping/1275884 skb:kfree_skb(skbaddr: 0x8acd76546000, \

[ovs-dev] [PATCH v11 4/5] dpif: Probe support for OVS_ACTION_ATTR_DROP.

Kernel support has been added for this action. As such, we need to probe the datapath for support. Signed-off-by: Eric Garver --- include/linux/openvswitch.h | 2 +- lib/dpif.c | 6 ++- lib/dpif.h | 2 +- ofproto/ofproto-dpif.c | 77

[ovs-dev] [PATCH v11 0/5] dpif: probe support for OVS_ACTION_ATTR_DROP

v11: - move netdev and flow API check to lib - tweaked log message - use atomic store instead of cmpx - copy odp in copy_support() v10: - fix a sparse error in show_dp_feature_atomic_bool() v9: - new patch make get_datapath_cap() access support by pointer - fix a clang warning in

[ovs-dev] [PATCH v11 3/5] dpif: Support atomic_bool field type.

The next commit will convert a dp feature from bool to atomic_bool. As such we have to add support to the macros and functions. We must pass by reference instead of pass by value because all the atomic operations require a reference. Signed-off-by: Eric Garver --- ofproto/ofproto-dpif.c | 54

[ovs-dev] [PATCH v11 2/5] dpif: Make get_datapath_cap() access support by pointer.

This avoids copying the support struct onto the stack. Signed-off-by: Eric Garver --- ofproto/ofproto-dpif.c | 59 +- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index

Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

Thanks for fixing the crash, and thanks for taking the extra effort to ensure BFD tests are run by CI. Acked-by: Mark Michelson On 3/11/24 10:48, Ales Musil wrote: The cb_bt pointer was pointing to different struct and might have been NULL at this point. Make sure we are using the correct

Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #99 FILE:

[ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

The cb_bt pointer was pointing to different struct and might have been NULL at this point. Make sure we are using the correct pointer in the strcmp() and sbrec_bfd_set_chassis_name() call. At the same time make sure we are actually running all tests that do require the BFD beacon, as it was

[ovs-dev] [PATCH v7 2/2] netlink-conntrack: Optimize flushing ct zone.

Previously the kernel did not provide a netlink interface to flush/list only conntrack entries matching a specific zone. With [1] and [2] it is now possible to flush and list conntrack entries filtered by zone. Older kernels not yet supporting this feature will ignore the filter. For the list

[ovs-dev] [PATCH v7 1/2] util: Support checking for kernel versions.

Extract checking for a given kernel version to a separate function. It will be used also in the next patch. Acked-by: Mike Pattrick Acked-by: Eelco Chaudron Signed-off-by: Felix Huettner --- v6->v7: none v5->v6: - fix ovs_kernel_is_version_or_newer returning false if major and minor are

Re: [ovs-dev] [PATCH v6 2/2] netlink-conntrack: Optimize flushing ct zone.

> > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > > index 07d09b912..d87d6914d 100644 > > --- a/tests/system-traffic.at > > +++ b/tests/system-traffic.at > > @@ -3376,6 +3376,14 @@ AT_CHECK([ovs-appctl dpctl/dump-conntrack | > > FORMAT_CT(10.1.1.4)], [0], [dnl > > > >

Re: [ovs-dev] [RFC] bridge: Retry tunnel port addition for conflict.

On 3/11/24 06:17, Han Zhou wrote: > > > On Fri, Mar 8, 2024 at 12:17 AM Tao Liu > wrote: >> >> >> On 3/7/24 5:39 AM, Ilya Maximets wrote: >> > On 2/27/24 20:14, Han Zhou wrote: >> >> For kernel datapath, when a new tunnel port is created in the same >> >> transaction

Re: [ovs-dev] [PATCH net-next 3/3] genetlink: remove linux/genetlink.h

On Sat, Mar 09, 2024 at 10:34:58AM -0800, Jakub Kicinski wrote: > genetlink.h is a shell of what used to be a combined uAPI > and kernel header over a decade ago. It has fewer than > 10 lines of code. Merge it into net/genetlink.h. > In some ways it'd be better to keep the combined header > under