Missing and extra spaces, missing empty lines, unused imports and
variables, long lines.
Decided to just comment out the unused 'tail' and 'head' as they
seem useful in documenting the meaning of the words.
Files added to flake8-check to avoid future issues.
Signed-off-by: Ilya Maximets
---
We pinned the python version to 3.9 because we had issues building
older meson 0.47.1 with python 3.10. Since then meson was updated to
0.53.2 in our CI, but we didn't reconsider the python version.
Newer versions of python uncover more issues with our python files.
And newer major distributions
ovsdb-doc script generates the following syntax warning while running
with Python 3.12:
/ovsdb/ovsdb-doc:240: SyntaxWarning: invalid escape sequence '\{'
s += """
This doesn't cause a build failure because so far it's only a warning,
but it will become a syntax error in the future.
Fix that
Fixing a few more issues with Python 3.12 and Python files in general.
Switch CI testing to Python 3.12, more explanation in commit messages.
Plan s to also backport these changes to fix issues on older branches
and also to have uniform CI on all branches if possible.
Ilya Maximets (3):
On 4/10/24 17:48, Chris Riches wrote:
> If the database is particularly large (multi-GB), ovsdb-server can take
Hi, Chris. May I ask how did you end up with multi-GB database?
I would understand if it was an OVN Southbound DB, for example,
but why the local database that only stores
If the database is particularly large (multi-GB), ovsdb-server can take
several minutes to come up. This tends to fall afoul of the default
systemd start timeout, which is typically 90s, putting the service into
an infinite restart loop.
To avoid this, set the timeout to a more generous 5
The argument to insert() should be a uuid.UUID object. If it isn't
then a Row is created with a string uuid attribute and that row is
added to table.rows with a string key instead of a UUID key.
Fixes: 55b9507e6824 ("ovsdb-idl: Add the support to specify the uuid for row
insert.")
Signed-off-by:
The Python IDL code very closely mirrors the C IDL code, which uses
an hmap to store table rows. hmap code allows duplicate keys, while
IndexedRows, which is derived from DictBase does not.
The persistent UUID code can attempt to temporarily add a Row with
a duplicate UUID to table.rows, so
The Python persistent UUID tests should have the keyword "python"
added so that TESTSUITEFLAGS="-k python" will not miss testing
them.
Fixes: 55b9507e6824 ("ovsdb-idl: Add the support to specify the uuid for row
insert.")
Signed-off-by: Terry Wilson
---
tests/ovsdb-idl.at | 2 +-
1 file
On 4/10/24 18:24, Simon Horman wrote:
> On Wed, Apr 10, 2024 at 03:56:24PM +0200, Dumitru Ceara wrote:
>> The previously enabled 'hacking' checks were only applicable to Python 2
>> code. OVS doesn't support Python 2 for a while now so it's fine to
>> remove the dependency on hacking.
>>
>> A
On 4/10/24 18:24, Simon Horman wrote:
> On Wed, Apr 10, 2024 at 02:10:20PM +0200, Ilya Maximets wrote:
>> On 4/6/24 00:08, Ilya Maximets wrote:
>>> Currently, calls like ovs_assert() just print out a condition that
>>> caused assertion to fail. But it may be not enough to understand what
>>>
On 4/10/24 18:17, Simon Horman wrote:
> On Tue, Apr 09, 2024 at 10:24:09PM +0200, Ilya Maximets wrote:
>> Without this change many unit tests are failing on systems with
>> Python 3.12:
>>
>> +++ /tests/testsuite.dir/at-groups/2352/stdout
>> @@ -1,3 +1,5 @@
>> +/./interface-reconfigure:98:
On 4/10/24 12:04, Kevin Traynor wrote:
> On 10/04/2024 10:51, Eelco Chaudron wrote:
>>
>>
>> On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
>>
>>> 13.3 was released on March 5 and 13.2 will reach EoL in June.
>>> Update now.
>>
>> Changing from 13.2 to 13.3 looks fine to me. Assume you ran it
On 4/10/24 11:37, Eelco Chaudron wrote:
>
>
> On 9 Apr 2024, at 21:55, Ilya Maximets wrote:
>
>> Current code checks spelling of names in commit message tags and that
>> makes no sense.
>>
>> Most of the tags are explicitly handled, but tags like 'Tested-by' or
>> other lesser used ones are
On Wed, Apr 10, 2024 at 6:52 AM Simon Horman wrote:
>
> Hi,
>
> I would like to announce that the primary development branch for OvS
> has been renamed main.
>
> The rename occurred a little earlier today.
>
> OVS is currently hosted on GitHub. We can expect the following behaviour
> after the
On 4/10/24 16:09, Simon Horman wrote:
> The OvS primary development branch has been renamed main
> so there is no longer any need for this CI configuration
> to refer to master.
>
> Signed-off-by: Simon Horman
> ---
> .github/workflows/build-and-test.yml | 2 +-
> 1 file changed, 1
On 4/10/24 16:09, Simon Horman wrote:
> The OvS primary development branch has been renamed main
> so there is no longer any need for this CI configuration
> to refer to master.
>
> Signed-off-by: Simon Horman
> ---
> appveyor.yml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
On Wed, Apr 10, 2024 at 03:56:24PM +0200, Dumitru Ceara wrote:
> The previously enabled 'hacking' checks were only applicable to Python 2
> code. OVS doesn't support Python 2 for a while now so it's fine to
> remove the dependency on hacking.
>
> A similar change landed in OVN a while ago:
>
On Wed, Apr 10, 2024 at 02:10:20PM +0200, Ilya Maximets wrote:
> On 4/6/24 00:08, Ilya Maximets wrote:
> > Currently, calls like ovs_assert() just print out a condition that
> > caused assertion to fail. But it may be not enough to understand what
> > exactly has happened, especially if assertion
On Tue, Apr 09, 2024 at 10:24:09PM +0200, Ilya Maximets wrote:
> Without this change many unit tests are failing on systems with
> Python 3.12:
>
> +++ /tests/testsuite.dir/at-groups/2352/stdout
> @@ -1,3 +1,5 @@
> +/./interface-reconfigure:98: SyntaxWarning: invalid escape sequence '\s'
>
On 4/10/24 17:24, Simon Horman wrote:
> On Wed, Apr 10, 2024 at 03:45:53PM +0200, Ales Musil wrote:
>> There was recent switch in OvS from master to main branch.
>> Use main in all the references across OVN code base.
>>
>> Signed-off-by: Ales Musil
>> ---
>> v2: Add the missing two references.
>
On Wed, Apr 10, 2024 at 03:45:53PM +0200, Ales Musil wrote:
> There was recent switch in OvS from master to main branch.
> Use main in all the references across OVN code base.
>
> Signed-off-by: Ales Musil
> ---
> v2: Add the missing two references.
Acked-by: Simon Horman
On 10/04/2024 16:16, Ilya Maximets wrote:
> On 4/10/24 17:01, Kevin Traynor wrote:
>> On 05/04/2024 23:08, Ilya Maximets wrote:
>>> Currently, calls like ovs_assert() just print out a condition that
>>> caused assertion to fail. But it may be not enough to understand what
>>> exactly has
On 4/10/24 17:01, Kevin Traynor wrote:
> On 05/04/2024 23:08, Ilya Maximets wrote:
>> Currently, calls like ovs_assert() just print out a condition that
>> caused assertion to fail. But it may be not enough to understand what
>> exactly has happened, especially if assertion failed in some generic
On 05/04/2024 23:08, Ilya Maximets wrote:
> Currently, calls like ovs_assert() just print out a condition that
> caused assertion to fail. But it may be not enough to understand what
> exactly has happened, especially if assertion failed in some generic
> function like dp_packet_resize() or
On 10 Apr 2024, at 16:09, Simon Horman wrote:
> The OvS primary development branch has been renamed main
> so there is no longer any need for this CI configuration
> to refer to master.
>
> Signed-off-by: Simon Horman
Thanks for following through with the main branch change.
Acked-by: Eelco
On 10 Apr 2024, at 16:09, Simon Horman wrote:
> The OvS primary development branch has been renamed main
> so there is no longer any need for this CI configuration
> to refer to master.
>
> Signed-off-by: Simon Horman
Thanks for following through with the main branch change.
Acked-by: Eelco
Acked-by: Alin Gabriel Serdean
>
> On 10 Apr 2024, at 16:09, Simon Horman wrote:
>
> The OvS primary development branch has been renamed main
> so there is no longer any need for this CI configuration
> to refer to master.
>
> Signed-off-by: Simon Horman
> ---
> appveyor.yml | 1 -
> 1
The OvS primary development branch has been renamed main
so there is no longer any need for this CI configuration
to refer to master.
Signed-off-by: Simon Horman
---
appveyor.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/appveyor.yml b/appveyor.yml
index 050c7dead786..baa844753962
The OvS primary development branch has been renamed main
so there is no longer any need for this CI configuration
to refer to master.
Signed-off-by: Simon Horman
---
.github/workflows/build-and-test.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The OvS primary development branch has been renamed main
so there is no longer any need for CI configuration to
refer to master.
Signed-off-by: Simon Horman
---
Simon Horman (2):
appveyor: Remove reference to master branch.
github: Remove reference to master branch.
The previously enabled 'hacking' checks were only applicable to Python 2
code. OVS doesn't support Python 2 for a while now so it's fine to
remove the dependency on hacking.
A similar change landed in OVN a while ago:
https://github.com/ovn-org/ovn/commit/271186fa7d76
Signed-off-by: Dumitru
Hi,
I would like to announce that the primary development branch for OvS
has been renamed main.
The rename occurred a little earlier today.
OVS is currently hosted on GitHub. We can expect the following behaviour
after the rename:
* GitHub pull requests against master should have been
On Wed, Apr 10, 2024 at 3:42 PM Dumitru Ceara wrote:
> Hi Ales, Simon,
>
> On 4/10/24 15:39, Simon Horman wrote:
> > On Wed, Apr 10, 2024 at 03:26:25PM +0200, Ales Musil wrote:
> >> There was recent switch in OvS from master to main branch.
> >> Use main instead in ovn-fake-mutlinode tests.
>
>
There was recent switch in OvS from master to main branch.
Use main in all the references across OVN code base.
Signed-off-by: Ales Musil
---
v2: Add the missing two references.
---
.github/workflows/ovn-fake-multinode-tests.yml | 4 ++--
Documentation/tutorials/ovn-sandbox.rst| 2 +-
On 9 Apr 2024, at 9:19, Adrian Moreno wrote:
> The current __check_doc_is_listed() verifies that the new .rst file is
> listed in Documentation/automake.mk with the full path (i.e:
> "{directory}/{filename}").
>
> While this holds true for generic documentation files, which are added
> to
Hi Ales, Simon,
On 4/10/24 15:39, Simon Horman wrote:
> On Wed, Apr 10, 2024 at 03:26:25PM +0200, Ales Musil wrote:
>> There was recent switch in OvS from master to main branch.
>> Use main instead in ovn-fake-mutlinode tests.
Nit: typo :)
>>
>> Signed-off-by: Ales Musil
>
> Acked-by: Simon
On Wed, Apr 10, 2024 at 03:26:25PM +0200, Ales Musil wrote:
> There was recent switch in OvS from master to main branch.
> Use main instead in ovn-fake-mutlinode tests.
>
> Signed-off-by: Ales Musil
Acked-by: Simon Horman
___
dev mailing list
On Wed, Apr 10, 2024 at 12:07:12PM +0100, Simon Horman wrote:
> On Tue, Apr 09, 2024 at 07:28:08PM +0200, Ilya Maximets wrote:
> > On 4/5/24 15:57, Simon Horman wrote:
> > > Recently OVS adopted a policy of using the inclusive naming word list v1
> > > [1, 2].
> > >
> > > In keeping with this
On Tue, Apr 9, 2024 at 5:54 PM Numan Siddique wrote:
>
>
> On Tue, Apr 9, 2024, 7:46 AM Dumitru Ceara wrote:
>
>> On 4/8/24 09:19, Ales Musil wrote:
>> > On Fri, Apr 5, 2024 at 10:35 PM Numan Siddique wrote:
>> >
>> >>
>> >>
>> >> On Tue, Apr 2, 2024 at 2:28 AM Ales Musil wrote:
>> >>
>> >>>
The current packet injection loses ct_state in the process. When
the ct_state is lost we might commit to DNAT zone and perform
zero SNAT after the packet injection. This causes the first session
to be wrong as the reply packets are not unDNATted.
Instead of re-injecting the packet back into the
The ovn-fake-multinode workflow can be triggered manually,
however the definition didn't respect the branch for the manual
run and always used main branch. Make sure that the correct
branch is used for the ovn-fake-multinode workflow.
Fixes: 033f5bebf94d ("CI: Add a couple of periodic jobs using
There was recent switch in OvS from master to main branch.
Use main instead in ovn-fake-mutlinode tests.
Signed-off-by: Ales Musil
---
.github/workflows/ovn-fake-multinode-tests.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Tue, Apr 09, 2024 at 09:19:02AM +0200, Adrian Moreno wrote:
> The current __check_doc_is_listed() verifies that the new .rst file is
> listed in Documentation/automake.mk with the full path (i.e:
> "{directory}/{filename}").
>
> While this holds true for generic documentation files, which are
On 4/6/24 00:08, Ilya Maximets wrote:
> Currently, calls like ovs_assert() just print out a condition that
> caused assertion to fail. But it may be not enough to understand what
> exactly has happened, especially if assertion failed in some generic
> function like dp_packet_resize() or similar.
On 4/3/24 17:15, Timothy Redaelli wrote:
> Since on CentOS/RHEL the builds are based on stable branches and not on
> tags for debugging purpose it's better to have the downstream version as
> version so it's easier to know which commits are included in a build.
>
> This commit adds
On Tue, Apr 09, 2024 at 07:28:08PM +0200, Ilya Maximets wrote:
> On 4/5/24 15:57, Simon Horman wrote:
> > Recently OVS adopted a policy of using the inclusive naming word list v1
> > [1, 2].
> >
> > In keeping with this policy rename the primary development branch from
> > 'master' to 'main'.
On 10 Apr 2024, at 12:49, Ilya Maximets wrote:
> On 4/10/24 12:44, Eelco Chaudron wrote:
>>
>>
>> On 10 Apr 2024, at 12:09, Kevin Traynor wrote:
>>
>>> On 10/04/2024 11:04, Kevin Traynor wrote:
On 10/04/2024 10:51, Eelco Chaudron wrote:
>
>
> On 10 Apr 2024, at 11:41, Ilya
On 4/10/24 12:44, Eelco Chaudron wrote:
>
>
> On 10 Apr 2024, at 12:09, Kevin Traynor wrote:
>
>> On 10/04/2024 11:04, Kevin Traynor wrote:
>>> On 10/04/2024 10:51, Eelco Chaudron wrote:
On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
> 13.3 was released on March 5 and
On 10 Apr 2024, at 12:09, Kevin Traynor wrote:
> On 10/04/2024 11:04, Kevin Traynor wrote:
>> On 10/04/2024 10:51, Eelco Chaudron wrote:
>>>
>>>
>>> On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
>>>
13.3 was released on March 5 and 13.2 will reach EoL in June.
Update now.
>>>
>>>
On 10/04/2024 11:04, Kevin Traynor wrote:
> On 10/04/2024 10:51, Eelco Chaudron wrote:
>>
>>
>> On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
>>
>>> 13.3 was released on March 5 and 13.2 will reach EoL in June.
>>> Update now.
>>
>> Changing from 13.2 to 13.3 looks fine to me. Assume you ran it
On 10/04/2024 10:51, Eelco Chaudron wrote:
>
>
> On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
>
>> 13.3 was released on March 5 and 13.2 will reach EoL in June.
>> Update now.
>
> Changing from 13.2 to 13.3 looks fine to me. Assume you ran it trough GitHub
> actions;
>
I ran it here:
On 10 Apr 2024, at 11:41, Ilya Maximets wrote:
> 13.3 was released on March 5 and 13.2 will reach EoL in June.
> Update now.
Changing from 13.2 to 13.3 looks fine to me. Assume you ran it trough GitHub
actions;
Acked-by: Eelco Chaudron
//Eelco
> Signed-off-by: Ilya Maximets
> ---
>
13.3 was released on March 5 and 13.2 will reach EoL in June.
Update now.
Signed-off-by: Ilya Maximets
---
.cirrus.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.cirrus.yml b/.cirrus.yml
index d8a972280..8db385f00 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -2,7 +2,7
On 9 Apr 2024, at 21:55, Ilya Maximets wrote:
> Current code checks spelling of names in commit message tags and that
> makes no sense.
>
> Most of the tags are explicitly handled, but tags like 'Tested-by' or
> other lesser used ones are falling through to the spellchecker and
> need to be
On 9 Apr 2024, at 16:58, Shahaji Bhosle wrote:
> Thanks Eelco, Sorry for the late reply.
> We are not using NVDIA NIC, and are using OVS+DPDK.
> It appears the revalidator threads are complaining because it is not able
> to get all the stats for million flows within its time window.
> Just
56 matches
Mail list logo
