Re: [ovs-dev] [PATCH ovn] northd: Allow DHCP request from the lport if enabled DHCPv4

2024-04-15 Thread 0-day Robot
Bleep bloop. Greetings 刘勰, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: northd: Allow DHCP request from the lport if

[ovs-dev] [PATCH ovn] northd: Allow DHCP request from the lport if enabled DHCPv4

2024-04-15 Thread liuxie_11
From: shylou DHCP for VM fails when removing default security group rules using a CMS like Neutron ML2/OVN [1]. This is because DHCP requests from VMs may be dropped by ACLs. To fix this issue, we add a lflow with a priority of 34000 to allow DHCP requests from the logical port if the CMS has

Re: [ovs-dev] [PATCH ovn] tests: Ignore log setting extended ack support failed.

2024-04-15 Thread 0-day Robot
Bleep bloop. Greetings 刘勰, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author shylou needs to sign off. WARNING: Unexpected sign-offs from developers who are not

[ovs-dev] [PATCH ovn] tests: Ignore log setting extended ack support failed.

2024-04-15 Thread liuxie_11
From: shylou The test error log 'setting extended ack support failed' in the test results may cause test failures. However, according to the OVS commit[1], this is not a critical issue, so we can safely ignore this log.

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

2024-04-15 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 322 characters long (recommended limit is 79) #28 FILE:

[ovs-dev] [PATCH ovn] ovn-nbctl: Document "--portrange" in the manpage.

2024-04-15 Thread Mark Michelson
The --portrange option was added in commit [0]. The option appears in the help text for ovn-nbctl, but it is not documented in the manpage at all. This commit adds documentation to the manpage for the --portrange option. Reported-at: https://issues.redhat.com/browse/FDP-537 Signed-off-by: Mark

[ovs-dev] [PATCH v2] python: ovsdb-idl: Add custom transaction operations.

2024-04-15 Thread Terry Wilson
It can be useful to be able to send raw transaction operations through the Idl's connection. For example, to clean up MAC_Binding entries for floating IPs without having to monitor the MAC_Binding table which can be quite large. Signed-off-by: Terry Wilson --- NEWS | 2 ++

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-15 Thread Jon Kohler
> On Apr 11, 2024, at 9:43 AM, Chris Riches wrote: > > On 11/04/2024 14:24, Ilya Maximets wrote: >> On 4/11/24 10:59, Chris Riches wrote: >>> From what we know so far, the DB was full of stale connection-tracking >>> information such as the following: >>> >>> [...] >>> >>> Once the host was

[ovs-dev] [PATCH v8] rhel: Make the version, displayed to the user, customizable.

2024-04-15 Thread Timothy Redaelli
Since on CentOS/RHEL the builds are based on stable branches and not on tags for debugging purpose it's better to have the downstream version as version so it's easier to know which commits are included in a build. This commit adds --with-version-suffix as ./configure option in order to set an

[ovs-dev] [Patch ovn v3 1/2] actions: New action ct_commit_to_zone.

2024-04-15 Thread Martin Kalcok
This change adds a new action 'ct_commit_to_zone' that enables users to commit the flow into a specific zone in the connection tracker. A new feature flag, OVN_FEATURE_CT_COMMIT_TO_ZONE, is also included to avoid issues during upgrade in case the northd is upgraded to a version that supports this

[ovs-dev] [Patch ovn v3 2/2] northd: Fix direct access to SNAT network.

2024-04-15 Thread Martin Kalcok
This change fixes bug that breaks ability of machines from external networks, to communicate with machines in SNATed networks (specifically when using a Distributed router). Currently when a machine (S1) on an external network tries to talk over TCP with a machine (A1) in a network that has

Re: [ovs-dev] [PATCH ovn v2 3/3] ofctrl: Introduce ecmp_nexthop_monitor.

2024-04-15 Thread Lorenzo Bianconi
> Hi Lorenzo, Hi Mark, thx for the review. > > The code looks fine to me, but I'm a bit confused by the new test. > > My understanding of the new feature is that each ECMP nexthop has an ID > associated with it. This ID gets placed in the ct.label. If the ECMP route > is removed, then we can

Re: [ovs-dev] [PATCH] net: openvswitch: Check vport name

2024-04-15 Thread Eelco Chaudron
On 13 Apr 2024, at 10:48, jun.gu wrote: > Check vport name from dev_get_by_name, this can avoid to add and remove > NIC repeatedly when NIC rename failed at system startup. > > Signed-off-by: Jun Gu > --- > net/openvswitch/vport-netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1