On Wed, Apr 24, 2024 at 7:46 PM Numan Siddique wrote:
>
> On Wed, Apr 24, 2024 at 5:14 PM Mark Michelson wrote:
> >
> > Hi Numan,
> >
> > I haven't done a full review of this yet, but I figured I'd give some
> > initial feedback from what I had looked at.
> >
> > At a high level, this is missing
On Wed, May 8, 2024 at 2:12 PM Mark Michelson wrote:
>
> Hi Numan,
>
> If you were waiting no further comments, I've now reviewed the full
> patch and have no comments beyond what I initially gave.
Thanks. I'll submit v2 with the changes. Please check out this patch
-
Hi Numan,
If you were waiting no further comments, I've now reviewed the full
patch and have no comments beyond what I initially gave.
On 4/23/24 12:43, num...@ovn.org wrote:
From: Numan Siddique
It is expected that a provider network logical switch has a localnet logical
switch port in
I came across a new patch recently:
https://patchwork.ozlabs.org/project/ovn/patch/20240423095006.24429-1-martin.kal...@canonical.com/
After that, I searched the OVN source code for instances of "to to" and
discovered two more occurrences of the same typo.
Signed-off-by: Igor Zhukov
---
In the following case:
union ct_addr {
unsigned int ipv4;
struct in6_addr ipv6;
};
union ct_addr zero_ip = {0};
The ipv6 field might not be properly initialized.
For instance, clang 18.1.1 does not initialize the ipv6 field.
Reported-at:
Hi Paolo
Thanks for the review.
On Wed, May 8, 2024 at 5:43 PM Paolo Valerio wrote:
> Hello Xavier,
>
> just curious, based on your tests, is clang 18.1.1 the only
> compiler/version known so far to lead to the problem, right?
>
Yes. We have not seen any issues (so far) with gcc. Older clang
On Tue, May 7, 2024 at 2:13 AM Han Zhou wrote:
>
> On Mon, May 6, 2024 at 10:37 PM Ales Musil wrote:
> >
> >
> >
> > On Mon, May 6, 2024 at 8:41 PM Han Zhou wrote:
> >>
> >>
> >>
> >> On Thu, May 2, 2024 at 10:35 PM Ales Musil wrote:
> >> >
> >> > On Thu, May 2, 2024 at 6:23 PM Han Zhou
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject, ': ', is over 70 characters, i.e., 73.
WARNING: The subject summary
It's a mega nitpick, but I observed that the example URL in the "Submitted-at"
points to the OVS repository instead of OVN.
Signed-off-by: Igor Zhukov
---
Documentation/internals/contributing/submitting-patches.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hello Xavier,
just curious, based on your tests, is clang 18.1.1 the only
compiler/version known so far to lead to the problem, right?
Anyways, only a small cosmetic nit below. Other than that:
Acked-by: Paolo Valerio
Xavier Simonart writes:
> In the following case:
> union ct_addr {
>
Adrian Moreno writes:
> On 5/3/24 11:43 AM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
>>
>>> Add support for psample sampling via two new attributes to the
>>> OVS_ACTION_ATTR_SAMPLE action.
>>>
>>> OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample
On 7 May 2024, at 16:18, Adrian Moreno wrote:
> On 5/3/24 11:43 AM, Eelco Chaudron wrote:
>>
>>
>> On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
>>
>>> Add support for psample sampling via two new attributes to the
>>> OVS_ACTION_ATTR_SAMPLE action.
>>>
>>> OVS_SAMPLE_ATTR_PSAMPLE_GROUP used
The flow_reval_monitor.py script incorrectly reported the reasons for
FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
This patch rectifies the order using a dictionary to avoid similar
problems in the future.
In addition this patch also syncs the delete reason output of the
On 7 May 2024, at 17:04, David Marchand wrote:
> This change has no impact, since -Dmachine=default gets converted by
> DPDK into -Dplatform=generic (since v21.08, see the link to DPDK commit
> below). Yet, switch to explicitly setting -Dplatform and avoid the
> following warning:
>
>
In the following case:
union ct_addr {
unsigned int ipv4;
struct in6_addr ipv6;
};
union ct_addr zero_ip = {0};
The ipv6 field might not be properly initialized.
For instance, clang 18.1.1 does not initialize the ipv6 field.
Reported-at:
15 matches
Mail list logo
