Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

2024-03-11 Thread Mark Michelson
I pushed this to main and branch-24.03. On 3/11/24 11:02, Mark Michelson wrote: Thanks for fixing the crash, and thanks for taking the extra effort to ensure BFD tests are run by CI. Acked-by: Mark Michelson On 3/11/24 10:48, Ales Musil wrote: The cb_bt pointer was pointing to different

Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

2024-03-11 Thread Mark Michelson
Thanks for fixing the crash, and thanks for taking the extra effort to ensure BFD tests are run by CI. Acked-by: Mark Michelson On 3/11/24 10:48, Ales Musil wrote: The cb_bt pointer was pointing to different struct and might have been NULL at this point. Make sure we are using the correct

Re: [ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

2024-03-11 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace WARNING: Line has trailing whitespace #99 FILE:

[ovs-dev] [PATCH ovn] northd: Fix NULL pointer deref within build_bfd_table.

2024-03-11 Thread Ales Musil
The cb_bt pointer was pointing to different struct and might have been NULL at this point. Make sure we are using the correct pointer in the strcmp() and sbrec_bfd_set_chassis_name() call. At the same time make sure we are actually running all tests that do require the BFD beacon, as it was