Re: [ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

2024-03-21 Thread Dumitru Ceara
On 3/21/24 07:15, Ales Musil wrote: > On Wed, Mar 20, 2024 at 8:37 PM Mark Michelson wrote: > >> Hi Ales, thanks for providing this patch. However, branch-22.03 is now >> in maintenance mode. It only is receiving patches for security issues >> and other high-severity issues. I'm not planning to

Re: [ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

2024-03-21 Thread Ales Musil
On Wed, Mar 20, 2024 at 8:37 PM Mark Michelson wrote: > Hi Ales, thanks for providing this patch. However, branch-22.03 is now > in maintenance mode. It only is receiving patches for security issues > and other high-severity issues. I'm not planning to merge this, but if > there is a good reason

Re: [ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

2024-03-20 Thread Mark Michelson
Hi Ales, thanks for providing this patch. However, branch-22.03 is now in maintenance mode. It only is receiving patches for security issues and other high-severity issues. I'm not planning to merge this, but if there is a good reason that we should, I'm willing to hear it. On 3/20/24 06:13,

Re: [ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

2024-03-20 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH ovn branch-22.03] tests: Add helper for tcpdump.

2024-03-20 Thread Ales Musil
The way how tcpdump was called in tests was inconsistent, a lot fo the tests didn't even wait for the tcpdump to properly start, some of them didn't redirect the stderr which could cause leak into the test stderr and fail the test. To prevent that add macro that starts tcpdump and properly waits