Re: [ovs-dev] [PATCH ovn branch-23.09 1/2] tests: Add helper for tcpdump.

2024-03-20 Thread Mark Michelson
Thanks Ales, I pushed this and patch 2 to branch-23.09. On 3/20/24 06:16, Ales Musil wrote: The way how tcpdump was called in tests was inconsistent, a lot fo the tests didn't even wait for the tcpdump to properly start, some of them didn't redirect the stderr which could cause leak into the

Re: [ovs-dev] [PATCH ovn branch-23.09 1/2] tests: Add helper for tcpdump.

2024-03-20 Thread 0-day Robot
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers:

[ovs-dev] [PATCH ovn branch-23.09 1/2] tests: Add helper for tcpdump.

2024-03-20 Thread Ales Musil
The way how tcpdump was called in tests was inconsistent, a lot fo the tests didn't even wait for the tcpdump to properly start, some of them didn't redirect the stderr which could cause leak into the test stderr and fail the test. To prevent that add macro that starts tcpdump and properly waits