Re: [ovs-dev] [PATCH v3 12/12] documentation: Document ovs-flowviz.

2024-04-14 Thread Adrian Moreno
On 4/12/24 11:10, Eelco Chaudron wrote: On 9 Apr 2024, at 9:06, Adrian Moreno wrote: Add a man page for ovs-flowviz as well as a topic page with some more detailed examples. Signed-off-by: Adrian Moreno In addition to Ilya’s comments, find 3 small comments below. The rest looks good.

Re: [ovs-dev] [PATCH v3 12/12] documentation: Document ovs-flowviz.

2024-04-12 Thread Eelco Chaudron
On 9 Apr 2024, at 9:06, Adrian Moreno wrote: > Add a man page for ovs-flowviz as well as a topic page with some more > detailed examples. > > Signed-off-by: Adrian Moreno In addition to Ilya’s comments, find 3 small comments below. The rest looks good. Cheers, Eelco > --- >

Re: [ovs-dev] [PATCH v3 12/12] documentation: Document ovs-flowviz.

2024-04-09 Thread Ilya Maximets
On 4/9/24 09:06, Adrian Moreno wrote: > Add a man page for ovs-flowviz as well as a topic page with some more > detailed examples. > > Signed-off-by: Adrian Moreno > --- > Documentation/automake.mk | 4 +- > Documentation/conf.py | 2 + >

Re: [ovs-dev] [PATCH v3 12/12] documentation: Document ovs-flowviz.

2024-04-09 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #544 FILE:

Re: [ovs-dev] [PATCH v3 12/12] documentation: Document ovs-flowviz.

2024-04-09 Thread Adrian Moreno
On 4/9/24 09:06, Adrian Moreno wrote: Add a man page for ovs-flowviz as well as a topic page with some more detailed examples. Signed-off-by: Adrian Moreno --- Documentation/automake.mk | 4 +- Documentation/conf.py | 2 +

[ovs-dev] [PATCH v3 12/12] documentation: Document ovs-flowviz.

2024-04-09 Thread Adrian Moreno
Add a man page for ovs-flowviz as well as a topic page with some more detailed examples. Signed-off-by: Adrian Moreno --- Documentation/automake.mk | 4 +- Documentation/conf.py | 2 + Documentation/ref/index.rst | 1 +