Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-15 Thread Shyam Ranganathan
On 3/13/19 10:44 AM, Shyam Ranganathan wrote: > On 3/13/19 9:09 AM, Kaleb Keithley wrote: >> The v5.4 tag was made and a release job was run which gave us >> https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.tar.gz. >> If the v5.4 tag is moved then there's a logical disconnect

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-13 Thread Shyam Ranganathan
On 3/13/19 9:09 AM, Kaleb Keithley wrote: > The v5.4 tag was made and a release job was run which gave us > https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.tar.gz. > If the v5.4 tag is moved then there's a logical disconnect between the > tag and _that_ tar file, or more

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-13 Thread Kaleb Keithley
The v5.4 tag was made and a release job was run which gave us https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.tar.gz. If the v5.4 tag is moved then there's a logical disconnect between the tag and _that_ tar file, or more accurately the files in that tar file. Shyam and I

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-13 Thread Amar Tumballi Suryanarayan
I am totally fine with v5.5, my suggestion for moving the tag was if we consider calling 5.4 with these two patches. Calling the release as 5.5 is totally OK, and we call it out specifically in our version numbering scheme, as if something is very serious, we can break 'release date' train.

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-13 Thread Amar Tumballi Suryanarayan
We need to tag different commit may be? So the 'git checkout v5.4' points to the correct commit? On Wed, 13 Mar, 2019, 4:40 PM Shyam Ranganathan, wrote: > Niels, Kaleb, > > We need to respin 5.4 with the 2 additional commits as follows, > > commit a00953ed212a7071b152c4afccd35b92fa5a682a (HEAD

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-13 Thread Kaleb Keithley
The Version tag should be (considered) immutable. Please don't move it. If you want to add another tag to help us remember this issue that's fine. The other option which Shyam and I discussed was tagging v5.5. On Wed, Mar 13, 2019 at 8:32 AM Amar Tumballi Suryanarayan < atumb...@redhat.com>

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-13 Thread Shyam Ranganathan
Niels, Kaleb, We need to respin 5.4 with the 2 additional commits as follows, commit a00953ed212a7071b152c4afccd35b92fa5a682a (HEAD -> release-5, core: make compute_cksum function op_version compatible commit 8fb4631c65f28dd0a5e0304386efff3c807e64a4 dict: handle STR_OLD data type in xdr

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-06 Thread Sanju Rakonde
On Tue, Mar 5, 2019 at 9:46 PM Shyam Ranganathan wrote: > On 3/5/19 10:10 AM, Sanju Rakonde wrote: > > > > > > On Tue, Mar 5, 2019 at 7:29 PM Shyam Ranganathan > > wrote: > > > > On 2/27/19 5:19 AM, Niels de Vos wrote: > > > On Tue, Feb 26, 2019 at 02:47:30PM

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-05 Thread Shyam Ranganathan
On 3/5/19 10:10 AM, Sanju Rakonde wrote: > > > On Tue, Mar 5, 2019 at 7:29 PM Shyam Ranganathan > wrote: > > On 2/27/19 5:19 AM, Niels de Vos wrote: > > On Tue, Feb 26, 2019 at 02:47:30PM +, > jenk...@build.gluster.org

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-05 Thread Sanju Rakonde
On Tue, Mar 5, 2019 at 7:29 PM Shyam Ranganathan wrote: > On 2/27/19 5:19 AM, Niels de Vos wrote: > > On Tue, Feb 26, 2019 at 02:47:30PM +, jenk...@build.gluster.org > wrote: > >> SRC: > https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.tar.gz > >> HASH: >

Re: [gluster-packaging] [Gluster-Maintainers] glusterfs-5.4 released

2019-03-05 Thread Shyam Ranganathan
On 2/27/19 5:19 AM, Niels de Vos wrote: > On Tue, Feb 26, 2019 at 02:47:30PM +, jenk...@build.gluster.org wrote: >> SRC: >> https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.tar.gz >> HASH: >> https://build.gluster.org/job/release-new/80/artifact/glusterfs-5.4.sha512sum >