Re: [Pan-devel] Is Pan still actively being developed?

[Zan Lynx]

On 4/30/21 9:04 AM, Jack via Discussions of Pan source code hacking. wrote:


Pan already works with GTK3.   It just requires a change to the 
configure options, but the default needs to be changed from gtk2 to gtk3.


I don't know if you've tried it lately?

But no. Pan does not work with GTK3. It compiles. It runs. But the 
behavior is so bad it cannot be used. It needs a ton of work.


--
Knowledge is Power -- Power Corrupts
Study Hard -- Be Evil

___
Pan-devel mailing list
Pan-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/pan-devel

Re: [Pan-devel] A fix for a Fedora 28 bug

[Zan Lynx]

On 04/06/2018 09:45 AM, Petr Kovar wrote:
> Thanks for the patch, pushed as 7ec8ca1c45763682f159793b720b982b1618a488
> to master. (I actually had to recreate the patch because the line breaks
> got messed up.)

Sorry about that. I must have forgotten to switch to preformatted text.

-- 
Knowledge is Power -- Power Corrupts
Study Hard -- Be Evil

___
Pan-devel mailing list
Pan-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/pan-devel

[Pan-devel] A fix for a Fedora 28 bug

[Zan Lynx]

I just found this Pan bug after upgrading to Fedora 28. It's because of
new compilers and C++ libraries, etc. And because calling front() on an
empty container is a bug.

Patch:

>From 564d931d4f88eaea18bb30abd7ffd8b4ba468bc8 Mon Sep 17 00:00:00 2001
From: Jonathan Briggs 
Date: Tue, 3 Apr 2018 23:29:20 -0600
Subject: [PATCH] Do not use front() on empty vector.

---
 pan/data-impl/rules-filter.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pan/data-impl/rules-filter.cc b/pan/data-impl/rules-filter.cc
index abc2506..c0d26c4 100644
--- a/pan/data-impl/rules-filter.cc
+++ b/pan/data-impl/rules-filter.cc
@@ -36,7 +36,9 @@ RulesFilter :: finalize (Data& data)
   _delete.clear();

   const std::vector tmp (_mark_read.begin(),
_mark_read.end());
-  data.mark_read ((const Article**)(), tmp.size());
+  if (!tmp.empty()) {
+data.mark_read ((const Article**)(), tmp.size());
+  }
   _mark_read.clear();

   const std::vector tmp2 ( _cached.begin(),
_cached.end());
-- 
2.17.0

-- 
Knowledge is Power -- Power Corrupts
Study Hard -- Be Evil

___
Pan-devel mailing list
Pan-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/pan-devel