Re: [PATCH] Unset variables messing with Git use

2019-11-28 Thread Jason A. Donenfeld
Thanks for the patch. Sorry for the delay. https://git.zx2c4.com/password-store/commit/?id=88936b11aff49e48f79842e4628c55620e0ad736 ___ Password-Store mailing list Password-Store@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/password-store

Re: [PATCH] Unset variables messing with Git use

2019-08-13 Thread martin f krafft
GIT_CEILING_DIRECTORIES Just noticed that password-store already overrides this anyway… -- @martinkrafft | https://riot.im/app/#/room/#madduck:madduck.net whatever you do will be insignificant, but it is very important that you do it. --

Re: [PATCH] Unset variables messing with Git use

2019-08-13 Thread martin f krafft
Quoting "Amir Yalon", who wrote on 2019-08-13 at 23:09 Uhr +0300: +unset GIT_DIR GIT_WORK_TREE GIT_NAMESPACE GIT_INDEX_FILE GIT_OBJECT_DIRECTORY The list might not be comprehensive; No, it's not, but I did consider the others ones: GIT_INDEX_FILE Included. GIT_INDEX_VERSION I was

Re: [PATCH] Unset variables messing with Git use

2019-08-13 Thread Amir Yalon
Hi, On Tue, Aug 13, 2019, at 12:54, martin f. krafft wrote: > > +unset GIT_DIR GIT_WORK_TREE GIT_NAMESPACE GIT_INDEX_FILE GIT_OBJECT_DIRECTORY > + The list might not be comprehensive; the following appear in the man page for my local installation of git (version 2.20.1) in the first group

[PATCH] Unset variables messing with Git use

2019-08-13 Thread martin f. krafft
This patch makes sure that variables from the environment cannot override e.g. the Git directory to operate on. Without it, in a setting where GIT_DIR is set, pass would otherwise commit generated password files to the wrong repository. I caught this, because fortunately the other repository had