Re: pwclient handling of argparse options

On October 17, 2015 4:25:54 AM GMT+02:00, Mike Frysinger wrote: >On 16 Oct 2015 16:39, Brian Norris wrote: >> commit_str = args.get('c') > >if you feel like cleaning things up, i find the args behavior weird and >non-standard. it does: > args =

Re: [PULL] github.com/stephenfin/development

On Fri, Oct 16, 2015 at 07:08:45PM +0100, Finucane, Stephen wrote: > # 1) Add additional project configuration options: > > We should add the following options to the 'Project' model > > * Add an optional list property to specify the tests contexts that > have to run in order for a patch to be

RE: [PATCH 01/15] parsemail: Return the list of prefixes when cleaning up the subject

> On Sat, Oct 10, 2015 at 12:21:11AM +0100, Finucane, Stephen wrote: > > > The patch is a preparation step towards understanding series. It will > be > > > handy to parse those prefixes, looking for 'x/n' to retrieve the order > > > of a patch in a series. > > > > > > Signed-off-by: Damien Lespiau

Re: pwclient handling of argparse options

On 19 Oct 2015 09:57, Bernhard Reutner-Fischer wrote: > On October 17, 2015 4:25:54 AM GMT+02:00, Mike Frysinger wrote: > >On 16 Oct 2015 16:39, Brian Norris wrote: > >> commit_str = args.get('c') > > > >if you feel like cleaning things up, i find the args behavior weird and >

RE: [PATCH v2 1/4] pwclient: dict.iteritems() is deprecated in Python 3

> > Just use dict.items(), since there are few fields and we don't really > > care about the extra copying. > > > > Signed-off-by: Brian Norris > > Reviewed-by: Mike Frysinger > > Reviewed-by: Stephen Finucane

RE: [PATCH v2 3/4] pwclient: rework multi-command help text

> > On 16 Oct 2015 16:39, Brian Norris wrote: > > > Our --help handling is convoluted and confusing, since we're hacking > > > around using some of argparse's built-in features (like generating > > > --help arguments for us). It seems like we were hacking around the > > > conflict between -h used

RE: [PATCH v2 4/4] pwclient: use argparse's error() function for bad input

> This reduces the boilerplate we need and provides a more consistent help > output. e.g.: > >$ pwclient update -s FOO -c 1337 314159 1234567 >usage: pwclient update [--help] [-h HASH] [-p PROJECT] [-c COMMIT-REF] > [-s STATE] [-a {yes,no}] >

RE: [PATCH 0/2] Add groundwork for semantic versioning

> This series adds two crucial changes to the projects documentation. > > The main focus of this series is to add some adminstrator-focused > documentation to provide instruction on the upgrading Patchwork along > with an overview of the changes between releases. Given that future > releases make