Re: [PATCH 1/3] pwclient: require one or more of pwclient -{a,s}

Ping on this series? There's some other oustanding mildly conflicting patches for pwclient too (python3 support, from Mike Frysinger) too. I can resend whatever you'd like, or rebase if you take other patches first. Regards, Brian On Wed, May 20, 2015 at 11:36:01PM -0700, Brian Norris wrote: >

Re: missing patches

Hi Damien, On Fri, Oct 16, 2015 at 01:43:04PM +0100, Damien Lespiau wrote: > On Mon, Oct 12, 2015 at 01:54:24PM -0700, Brian Norris wrote: > > Occasionally, I'll run across patches from the linux-mtd mailing list > > that never show up on the ozlabs.org Patchwork instance. I don't > > really have

RE: [PULL] github.com/stephenfin/development

> On Fri, Oct 16, 2015 at 04:11:50PM +0100, Finucane, Stephen wrote: > > You appear to be insisting there should be a more static configuration > > of "runnable tests". However, I don't think this would scale or allow > > the fluidity of Thomas' proposal. > > I'm insisting it's *possible* to have

Re: [PATCH] views: patch-list: show the 'Properties' update box for all users

One more ping? The context changed slightly but it still applies to my tree OK. I can resend if needed. Thanks, Brian On Wed, May 20, 2015 at 11:29:29PM -0700, Brian Norris wrote: > On Sat, Nov 22, 2014 at 10:30:06PM -0800, Brian Norris wrote: > > Any authenticated user should be able to change

RE: [PATCH 1/3] pwclient: require one or more of pwclient -{a,s}

> Ping on this series? There's some other oustanding mildly conflicting > patches for pwclient too (python3 support, from Mike Frysinger) too. I > can resend whatever you'd like, or rebase if you take other patches > first. I'd be happy to merge this (Python 3 is on the roadmap, after all), but

[PATCH 1/2] doc: Add CHANGELOG and UPGRADING docs

The CHANGELOG document should describe the high level changes of the project. This will provide a human-readable way for people to evaluate the changes in each release. This file is based on the templates and general changelog "ethos" provided by 'Keep a CHANGELOG': http://keepachangelog.com/

[PATCH 0/2] Add groundwork for semantic versioning

This series adds two crucial changes to the projects documentation. The main focus of this series is to add some adminstrator-focused documentation to provide instruction on the upgrading Patchwork along with an overview of the changes between releases. Given that future releases make changes to

[PATCH 2/2] docs: Update Git URLs to GitHub

Per move to GitHub: https://lists.ozlabs.org/pipermail/patchwork/2015-October/001873.html Signed-off-by: Stephen Finucane --- docs/index.md | 2 +- mkdocs.yml| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/index.md b/docs/index.md

Re: [PATCH 1/3] pwclient: require one or more of pwclient -{a,s}

+ Mike On Fri, Oct 16, 2015 at 06:11:52PM +, Finucane, Stephen wrote: > > Ping on this series? There's some other oustanding mildly conflicting > > patches for pwclient too (python3 support, from Mike Frysinger) too. I > > can resend whatever you'd like, or rebase if you take other patches >

[PATCH 1/3] pwclient: handle missing ~/.pwclientrc better

From: Mike Frysinger The upgrade path will crash if ~/.pwclientrc doesn't exist, so add an explicit check for the file before we try to "upgrade" it. The default error messages don't mention the config file, so it can be a bit confusing what pwclient is complaining about

Re: [PATCH 1/3] pwclient: handle missing ~/.pwclientrc better

On Fri, Oct 16, 2015 at 05:15:29PM -0400, Mike Frysinger wrote: > From: Mike Frysinger > > The upgrade path will crash if ~/.pwclientrc doesn't exist, so add an > explicit check for the file before we try to "upgrade" it. > > The default error messages don't mention the

[PATCH 3/3] pwclient: basic python3 support

From: Mike Frysinger This fixes a few random issues to make the script work at least somewhat under python 3: - set the default encoding to utf-8 - handle xmlrpclib/xmlrpc.client module renames - handle ConfigParser/configparser module renames - add a unicode() stub for

[PATCH 2/3] pwclient: use print_function for better py3 compatibility

From: Mike Frysinger The script already tries to use print like a function in many places but is really passing a parenthesized string. Import the print_function from the future module so that it actually works as intended. We also need to fix up a few latent print

Re: [PULL] github.com/stephenfin/development

On Thu, Oct 15, 2015 at 11:46:30PM +, Finucane, Stephen wrote: > Hey, > > First pull request (request-pull style, that is). Hope I've done > everything correctly :S This PR includes two fixes and the code enable > the check API. It's got positive reviews first time round and I > haven't heard

Re: missing patches

Hi, On Mon, Oct 12, 2015 at 01:54:24PM -0700, Brian Norris wrote: > Occasionally, I'll run across patches from the linux-mtd mailing list > that never show up on the ozlabs.org Patchwork instance. I don't > really have much visibility into this problem, so I wanted to reach > out here. > > For

RE: [PULL] github.com/stephenfin/development

> On Thu, Oct 15, 2015 at 11:46:30PM +, Finucane, Stephen wrote: > > Hey, > > > > First pull request (request-pull style, that is). Hope I've done > > everything correctly :S This PR includes two fixes and the code enable > > the check API. It's got positive reviews first time round and I > >

RE: [PATCH v2 0/6] Add some API documentation

> On Mon, Oct 12, 2015 at 07:54:33PM +0100, Stephen Finucane wrote: > > docs/api.md| 51 +++ > > This conflicts with the readthedocs series sent earlier. *reStructuredText series - Markdown works just fine with readthedocs. Yeah, I'm waiting for a reply to my questions on

RE: [PULL] github.com/stephenfin/development

> On Thu, Oct 15, 2015 at 11:46:30PM +, Finucane, Stephen wrote: > > Hey, > > > > First pull request (request-pull style, that is). Hope I've done > > everything correctly :S This PR includes two fixes and the code enable > > the check API. It's got positive reviews first time round and I > >

Re: [PULL] github.com/stephenfin/development

On Fri, Oct 16, 2015 at 04:11:50PM +0100, Finucane, Stephen wrote: > You appear to be insisting there should be a more static configuration > of "runnable tests". However, I don't think this would scale or allow > the fluidity of Thomas' proposal. I'm insisting it's *possible* to have a list of

[PATCH 2/3] pwclient: require one or more of pwclient -{a,s}

Previously, we required the -s flag for 'pwclient update'. But since we allow updating up to 2 different fields ('archived' and 'state'), drop the required flag, and just enforce that the user must provide -a, -s, or both. Signed-off-by: Brian Norris ---

Re: [PATCH 3/3] pwclient: basic python3 support

On 16 Oct 2015 22:13, Finucane, Stephen wrote: > > From: Mike Frysinger > > > > This fixes a few random issues to make the script work at least somewhat > > under python 3: > > - set the default encoding to utf-8 > > - handle xmlrpclib/xmlrpc.client module renames > > -

Re: [PATCH 3/3] pwclient: basic python3 support

On Fri, Oct 16, 2015 at 10:49:04PM +, Finucane, Stephen wrote: > > (... and I see it was merged already. Cool.) > > I had reviewed (and have also been using) the patches 1[1] and 3[2] in > the series since the first time they were sent. Had the same trivial > comment about the second one but

Re: [PATCH 1/3] pwclient: dict.iteritems() is deprecated in Python 3

On 16 Oct 2015 16:12, Brian Norris wrote: > Just use dict.items(), since there are few fields and we don't really > care about the extra copying. Reviewed-by: Mike Frysinger > --- a/patchwork/bin/pwclient > +++ b/patchwork/bin/pwclient > @@ -237,7 +237,7 @@ def

[PATCH v2 3/4] pwclient: rework multi-command help text

Our --help handling is convoluted and confusing, since we're hacking around using some of argparse's built-in features (like generating --help arguments for us). It seems like we were hacking around the conflict between -h used for hashes and -h used for automatic help flags. Fortunately, Python's

[PATCH v2 1/4] pwclient: dict.iteritems() is deprecated in Python 3

Just use dict.items(), since there are few fields and we don't really care about the extra copying. Signed-off-by: Brian Norris Reviewed-by: Mike Frysinger --- v2: unchanged patchwork/bin/pwclient | 2 +- 1 file changed, 1 insertion(+), 1

RE: [PATCH 3/3] pwclient: basic python3 support

> (... and I see it was merged already. Cool.) I had reviewed (and have also been using) the patches 1[1] and 3[2] in the series since the first time they were sent. Had the same trivial comment about the second one but I let it slip - it's a good fix and I'm eager to get this kind of stuff in

RE: [PATCH 3/3] pwclient: basic python3 support

> From: Mike Frysinger > > This fixes a few random issues to make the script work at least somewhat > under python 3: > - set the default encoding to utf-8 > - handle xmlrpclib/xmlrpc.client module renames > - handle ConfigParser/configparser module renames > - add a

RE: [PATCH 1/3] pwclient: handle missing ~/.pwclientrc better

> > From: Mike Frysinger > > > > The upgrade path will crash if ~/.pwclientrc doesn't exist, so add an > > explicit check for the file before we try to "upgrade" it. > > > > The default error messages don't mention the config file, so it can be > > a bit confusing what

RE: [PATCH 3/3] pwclient: basic python3 support

> > From: Mike Frysinger > > > > This fixes a few random issues to make the script work at least somewhat > > under python 3: > > - set the default encoding to utf-8 > > - handle xmlrpclib/xmlrpc.client module renames > > - handle ConfigParser/configparser module renames > >

RE: [PATCH 1/3] pwclient: require one or more of pwclient -{a,s}

> + Mike > > On Fri, Oct 16, 2015 at 06:11:52PM +, Finucane, Stephen wrote: > > > Ping on this series? There's some other oustanding mildly conflicting > > > patches for pwclient too (python3 support, from Mike Frysinger) too. I > > > can resend whatever you'd like, or rebase if you take

RE: [PATCH 00/15] Series models & parsing (v2)

... > > I > > have seen that occurence happen on intel-gfx, it's usually new > contributors > > that don't quite know how we'd like v2 of series to be sent (because it's > > not > > really well clear/documented). > > I've replied to all the patches available bar one (which I want to > investigate

Re: [PATCH] login: add link to password reset

On Wed, Mar 11, 2015 at 10:39:35PM +0100, Bernhard Reutner-Fischer wrote: > Hi, > > I am attaching an old patch to add a password-reset knob to the login > page. If anyone thinks this is a good idea then it should be thoroughly > tested against current django, i do remember that it worked like >

RE: [PATCH 2/3] pwclient: use print_function for better py3 compatibility

> From: Mike Frysinger > > The script already tries to use print like a function in many places but > is really passing a parenthesized string. Import the print_function from > the future module so that it actually works as intended. > > We also need to fix up a few latent

RE: [PATCH] Highlight patches with Acked/Reviewed/Tested tags

> On Mon, 20 Jul 2015 11:30:59 +0200, Thomas Petazzoni wrote: > > A little while ago, accounting of the number of Acked-by, Reviewed-by > > and Tested-by tags was added to patchwork. The count of such tags per > > patch is shown in the "A / R / T" column. > > > > However, since the values are

RE: [PATCH v2 01/10] models: Resolve issues with Patch.state

> > On Thu, Oct 01, 2015 at 04:14:23PM +0100, Finucane, Stephen wrote: > > > > On Thu, Oct 01, 2015 at 03:52:25PM +0100, Stephen Finucane wrote: > > > > > @@ -243,7 +243,7 @@ class Patch(models.Model): > > > > > date = models.DateTimeField(default=datetime.datetime.now) > > > > >

RE: [PULL] github.com/dlespiau/patchwork for-upstream

> Hi Jeremy, > > This pull request is the same as the previous one: > > https://lists.ozlabs.org/pipermail/patchwork/2015-October/001799.html > > with an embarassing typo fixed. > > HTH, > > -- > Damien I'm holding off merging this until we get the versioning stuff (or some version of it)

Re: [PATCH 2/3] pwclient: use print_function for better py3 compatibility

On 16 Oct 2015 15:38, Brian Norris wrote: > On Fri, Oct 16, 2015 at 05:15:30PM -0400, Mike Frysinger wrote: > > -except xmlrpclib.Fault, f: > > +except xmlrpclib.Fault as f: > > ^^^ this change is not documented in the commit message. Not that it > really matters much. this was supposed

Re: [PATCH v2 4/4] pwclient: use argparse's error() function for bad input

Reviewed-by: Mike Frysinger -mike signature.asc Description: Digital signature ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

Re: [PATCH v2 2/4] pwclient: require one or more of pwclient -{a,s}

Reviewed-by: Mike Frysinger -mike signature.asc Description: Digital signature ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork

pwclient handling of argparse options

On 16 Oct 2015 16:39, Brian Norris wrote: > commit_str = args.get('c') if you feel like cleaning things up, i find the args behavior weird and non-standard. it does: args = action_parser.parse_args() args = dict(vars(args)) action = args.get('subcmd') normally

Re: [PATCH v2 3/4] pwclient: rework multi-command help text

On 16 Oct 2015 16:39, Brian Norris wrote: > Our --help handling is convoluted and confusing, since we're hacking > around using some of argparse's built-in features (like generating > --help arguments for us). It seems like we were hacking around the > conflict between -h used for hashes and -h

RE: [PATCH] views: patch-list: show the 'Properties' update box for all users

> One more ping? The context changed slightly but it still applies to my > tree OK. I can resend if needed. > > Thanks, > Brian LGTM Acked-by: Stephen Finucane > On Wed, May 20, 2015 at 11:29:29PM -0700, Brian Norris wrote: > > On Sat, Nov 22, 2014 at 10:30:06PM