Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-11 Thread Finucane, Stephen
On 09 Nov 15:20, Damien Lespiau wrote: > On Mon, Nov 09, 2015 at 02:53:36PM +, Finucane, Stephen wrote: > > Ah, I get the point - I just misinterpreted the line ending character > > (it's a '\r', but I instinctively saw a '\n'). How about this? > > > > self.stdout.write('%06d/%06d\r' %

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-10 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:39:09PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > > > PS: Since we're talking, if you have time to address the remaining > > comments > > > on the 'series' series it would be appreciated. I don't want to just

RE: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Finucane, Stephen
> -Original Message- > From: Lespiau, Damien > Sent: Monday, November 9, 2015 4:54 AM > To: Finucane, Stephen > Cc: patchwork@lists.ozlabs.org > Subject: Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout > wrappers > > On Mon, Nov 09, 2015 at

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > PS: Since we're talking, if you have time to address the remaining comments > on the 'series' series it would be appreciated. I don't want to just do the > rework without you input in case I miss something. It's one of three

RE: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Finucane, Stephen
> On Mon, Nov 09, 2015 at 03:39:09PM +, Finucane, Stephen wrote: > > > On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > > > > PS: Since we're talking, if you have time to address the remaining > > > comments > > > > on the 'series' series it would be appreciated. I don't

RE: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Finucane, Stephen
> On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > > PS: Since we're talking, if you have time to address the remaining > comments > > on the 'series' series it would be appreciated. I don't want to just do > the > > rework without you input in case I miss something. It's one

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 03:39:09PM +, Finucane, Stephen wrote: > > On Mon, Nov 09, 2015 at 03:33:18PM +, Finucane, Stephen wrote: > > > PS: Since we're talking, if you have time to address the remaining > > comments > > > on the 'series' series it would be appreciated. I don't want to just

Re: [PATCH 1/2] retag: Don't use BaseCommand's stdin/stdout wrappers

2015-11-09 Thread Damien Lespiau
On Mon, Nov 09, 2015 at 02:29:57AM +, Finucane, Stephen wrote: > > @@ -38,6 +39,6 @@ class Command(BaseCommand): > > for i, patch in enumerate(query.iterator()): > > patch.refresh_tag_counts() > > if (i % 10) == 0 or i == count: > > -