Re: [PECL-DEV] Elliptic curve extension for PHP

2014-09-24 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 24/09/2014 15:51, John Judy a écrit : as RemiFedora (Remi Collet?) Yes, me ;) I didn't use what OpenSSL had built in because when I was researching implementing the ED25519 curve, I didn't see it listed as one of OpenSSL's defined curves.

Re: [PECL-DEV] Elliptic curve extension for PHP

2014-09-24 Thread Scott Arciszewski
Hi all, I've been working on my first PHP extension ( https://github.com/trianglman/ellipticCurveSignature) and I finally have it working and tested. I would really appreciate if some more people could look at it and let me know what I might have missed or better ways for me to do it. I

Re: [PECL-DEV] Elliptic curve extension for PHP

2014-09-23 Thread Antony Dovgal
Hello John, just a few remarks: https://github.com/trianglman/ellipticCurveSignature/blob/master/src/php_ellipticCurveSignature.c#L62 the l argument of zend_parse_parameters() accepts longs, not ints. zend_error() and E_ERROR are used for engine things _only_. There is no reason to stop script

[PECL-DEV] Elliptic curve extension for PHP

2014-09-22 Thread John Judy
Hi all, I've been working on my first PHP extension ( https://github.com/trianglman/ellipticCurveSignature) and I finally have it working and tested. I would really appreciate if some more people could look at it and let me know what I might have missed or better ways for me to do it. I would