pgsql: Avoid unportable shell syntax in pg_upgrade's test script.

2018-07-20 Thread Tom Lane
Avoid unportable shell syntax in pg_upgrade's test script. Most of test.sh uses traditional backtick syntax for command substitution, but commit da9b580d8 introduced two uses of $(...) syntax, which is not recognized by very old shells. Bring those into line with the rest. Victor Wagner

pgsql: Avoid unportable shell syntax in pg_upgrade's test script.

2018-07-20 Thread Tom Lane
Avoid unportable shell syntax in pg_upgrade's test script. Most of test.sh uses traditional backtick syntax for command substitution, but commit da9b580d8 introduced two uses of $(...) syntax, which is not recognized by very old shells. Bring those into line with the rest. Victor Wagner

pgsql: Guard against rare RAND_bytes() failures in pg_strong_random().

2018-07-20 Thread Dean Rasheed
Guard against rare RAND_bytes() failures in pg_strong_random(). When built using OpenSSL, pg_strong_random() uses RAND_bytes() to generate the random number. On very rare occasions that can fail, if its PRNG has not been seeded with enough data. Additionally, once it does fail, all subsequent

pgsql: Guard against rare RAND_bytes() failures in pg_strong_random().

2018-07-20 Thread Dean Rasheed
Guard against rare RAND_bytes() failures in pg_strong_random(). When built using OpenSSL, pg_strong_random() uses RAND_bytes() to generate the random number. On very rare occasions that can fail, if its PRNG has not been seeded with enough data. Additionally, once it does fail, all subsequent

pgsql: Guard against rare RAND_bytes() failures in pg_strong_random().

2018-07-20 Thread Dean Rasheed
Guard against rare RAND_bytes() failures in pg_strong_random(). When built using OpenSSL, pg_strong_random() uses RAND_bytes() to generate the random number. On very rare occasions that can fail, if its PRNG has not been seeded with enough data. Additionally, once it does fail, all subsequent