Re: pgsql: Build all Flex files standalone

2022-09-04 Thread John Naylor
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan wrote: > Probably happens because crake does vpath builds. I think you're going > to have to set up EXTRAINCLUDES for it - see near the bottom of the > headerscheck script. Possibly something like > > > src/backend/utils/adt/*) > >

pgsql: Force parallelism in partition_aggregate

2022-09-04 Thread Tomas Vondra
Force parallelism in partition_aggregate Commit db0d67db2 tweaked sort costing, which however resulted in a couple plan changes in our regression tests. Most of the new plans were fine, but partition_aggregate were meant to test parallel plans and the new plans were serial. Fix that by lowering

pgsql: Force parallelism in partition_aggregate

2022-09-04 Thread Tomas Vondra
Force parallelism in partition_aggregate Commit db0d67db2 tweaked sort costing, which however resulted in a couple plan changes in our regression tests. Most of the new plans were fine, but partition_aggregate were meant to test parallel plans and the new plans were serial. Fix that by lowering

pgsql: Reinstate tests accidentally removed by e3fcca0d0d

2022-09-04 Thread Tomas Vondra
Reinstate tests accidentally removed by e3fcca0d0d Commit e3fcca0d0d24 reverted modifications to HOT for BRIN, but it also removed a couple unrelated tests from stats.sql. Reinstate those tests. Reported-by: Peter Eisentraut Branch -- REL_15_STABLE Details ---

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread Andres Freund
Hi, On 2022-09-04 13:19:56 +0700, John Naylor wrote: > Crake fails with > > headerscheck: > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > Sep 04 01:56:01 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error:

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread Andres Freund
Hi, On 2022-09-04 18:04:13 +0700, John Naylor wrote: > On Sun, Sep 4, 2022 at 4:36 PM John Naylor > wrote: > > > > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe > > something like the following is needed: > > > > --- a/src/tools/msvc/Mkvcbuild.pm > > +++

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread Andrew Dunstan
On 2022-09-04 Su 02:19, John Naylor wrote: > Crake fails with > > headerscheck: > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > Sep 04 01:56:01 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error:

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread John Naylor
On Sun, Sep 4, 2022 at 4:36 PM John Naylor wrote: > > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe > something like the following is needed: > > --- a/src/tools/msvc/Mkvcbuild.pm > +++ b/src/tools/msvc/Mkvcbuild.pm > @@ -362,6 +362,7 @@ sub mkvcbuild >

pgsql: Fix MSVC linker error for specparse.obj

2022-09-04 Thread John Naylor
Fix MSVC linker error for specparse.obj Per buildfarm animals drongo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/92e7b7722da98eb4d54df7d4f850eee6a5fe9eef Modified Files -- src/tools/msvc/Mkvcbuild.pm | 1 + 1 file changed, 1 insertion(+)

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread John Naylor
The second failure is on drongo (MSVC): "c:\\prog\\bf\\root\\HEAD\\pgsql.build\\pgsql.sln" (default target) (1) -> "c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj" (default target) (13) -> (Link target) -> specparse.obj : error LNK2019: unresolved external symbol spec_yylex

Re: pgsql: Build all Flex files standalone

2022-09-04 Thread John Naylor
Crake fails with headerscheck: Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: Sep 04 01:56:01 /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: fatal error: jsonpath_gram.h: No such file or directory Sep 04 01:56:0126 |