pgsql: Fix headerscheck in vpath builds

2022-09-05 Thread John Naylor
Fix headerscheck in vpath builds Oversight in dac048f71e per buildfarm animal crake. Fix per suggestion from Andrew Dunstan. Discussion: https://www.postgresql.org/message-id/e3f4a3d0-dfcc-41cc-1ed2-acc15700ddef%40dunslane.net Branch -- master Details ---

pgsql: Fix failure to maintainer-clean jsonpath_gram.h

2022-09-05 Thread John Naylor
Fix failure to maintainer-clean jsonpath_gram.h Oversight in dac048f71e Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eac76cc012aa4888e882287baae791429396b403 Modified Files -- src/backend/Makefile | 1 + 1 file changed, 1 insertion(+)

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
I see why I couldn't reproduce: I neglected to add jsonpath_gram.h to the backend's maintainer-clean so it failed to be deleted. Working on the fix now. -- John Naylor EDB: http://www.enterprisedb.com

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
On Tue, Sep 6, 2022 at 11:49 AM Tom Lane wrote: > > crake is still unhappy: > > Sep 06 00:09:55 In file included from /tmp/headerscheck.AwLxya/test.c:2: > Sep 06 00:09:55 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error:

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread Tom Lane
John Naylor writes: > On Tue, Sep 6, 2022 at 10:54 AM Andres Freund wrote: >> Presumably it only happens if you previously triggered the parsers to be >> generated. > If you attempt to run the check before building, the first thing you get is > fatal error: utils/errcodes.h: No such file or

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
On Tue, Sep 6, 2022 at 10:54 AM Andres Freund wrote: > >I just tried a vpath build and the failing check doesn't reproduce for > >me there. Any ideas? > > Presumably it only happens if you previously triggered the parsers to be > generated. If you attempt to run the check before building, the

pgsql: Fix typo in 16d69ec29

2022-09-05 Thread David Rowley
Fix typo in 16d69ec29 As noted by Justin Pryzby, just I forgot to commit locally before creating a patch file. Discussion: https://postgr.es/m/20220901053146.gi31...@telsasoft.com Branch -- master Details ---

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread Andres Freund
Hi, On September 5, 2022 8:33:37 PM PDT, John Naylor wrote: >On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan wrote: >> >> >> On 2022-09-04 Su 02:19, John Naylor wrote: >> > Crake fails with >> > >> > headerscheck: >> > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: >>

pgsql: Remove buggy and dead code from CreateTriggerFiringOn

2022-09-05 Thread David Rowley
Remove buggy and dead code from CreateTriggerFiringOn Here we remove some dead code from CreateTriggerFiringOn() which was attempting to find the relevant child partition index corresponding to the given indexOid. As it turned out, thanks to -Wshadow=compatible-local, this code was buggy as the

Re: pgsql: Build all Flex files standalone

2022-09-05 Thread John Naylor
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan wrote: > > > On 2022-09-04 Su 02:19, John Naylor wrote: > > Crake fails with > > > > headerscheck: > > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > > Sep 04 01:56:01 > >

pgsql: Add missing exceptions to cpluspluscheck

2022-09-05 Thread John Naylor
Add missing exceptions to cpluspluscheck dac048f71 added exceptions to headerscheck but failed to do the same for cpluspluscheck Per report from Andres Freund regarding CI Discussion:https://www.postgresql.org/message-id/20220904205743.y3ntq6ij3aibmxvy%40awork3.anarazel.de Branch -- master

pgsql: Fix an assortment of improper usages of string functions

2022-09-05 Thread David Rowley
Fix an assortment of improper usages of string functions In a similar effort to f736e188c and 110d81728, fixup various usages of string functions where a more appropriate function is available and more fit for purpose. These changes include: 1. Use cstring_to_text_with_len() instead of

pgsql: Stamp 15beta4.

2022-09-05 Thread Tom Lane
Stamp 15beta4. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6e55ea79faa56db85a2b6c5bf94cee8acf8bfdb8 Modified Files -- configure| 18 +- configure.ac | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-)

pgsql: Backpatch nbtree page deletion hardening.

2022-09-05 Thread Peter Geoghegan
Backpatch nbtree page deletion hardening. Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy opclasses. VACUUM's inability to locate a to-be-deleted page's downlink in the parent page was logged instead of throwing an error. VACUUM could just press on with vacuuming the index,

pgsql: Backpatch nbtree page deletion hardening.

2022-09-05 Thread Peter Geoghegan
Backpatch nbtree page deletion hardening. Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy opclasses. VACUUM's inability to locate a to-be-deleted page's downlink in the parent page was logged instead of throwing an error. VACUUM could just press on with vacuuming the index,

pgsql: Backpatch nbtree page deletion hardening.

2022-09-05 Thread Peter Geoghegan
Backpatch nbtree page deletion hardening. Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy opclasses. VACUUM's inability to locate a to-be-deleted page's downlink in the parent page was logged instead of throwing an error. VACUUM could just press on with vacuuming the index,

pgsql: Backpatch nbtree page deletion hardening.

2022-09-05 Thread Peter Geoghegan
Backpatch nbtree page deletion hardening. Postgres 14 commit 5b861baa taught nbtree VACUUM to tolerate buggy opclasses. VACUUM's inability to locate a to-be-deleted page's downlink in the parent page was logged instead of throwing an error. VACUUM could just press on with vacuuming the index,

pgsql: Translation updates

2022-09-05 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: f2c273bb8723eb69911a4b0b9d02ca15bbc7c60f Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/77ce482e9efb9f1eaf62cd77ad1e5f17b6cc9d16 Modified Files

pgsql: Fix incorrect uses of Datum conversion macros

2022-09-05 Thread Peter Eisentraut
Fix incorrect uses of Datum conversion macros Since these macros just cast whatever you give them to the designated output type, and many normal uses also cast the output type further, a number of incorrect uses go undiscovered. The fixes in this patch have been discovered by changing these

pgsql: Update out of date comments in pg_trgm

2022-09-05 Thread Daniel Gustafsson
Update out of date comments in pg_trgm Commit be8a7a68662 changed the check_only parameter to a flag array but missed updating all comments. Update, and fix a related typo. Discussion: https://postgr.es/m/9732d8a2-eabd-4f5b-8ba0-a97da4ab5...@yesql.se Branch -- master Details ---

pgsql: Check for interrupts in pg_trgm word similarity

2022-09-05 Thread Daniel Gustafsson
Check for interrupts in pg_trgm word similarity Calculating similarity between large strings can be timesconsuming and overrun configured statement timeouts. Check for interrupts in the main loop to ensure query cancellation can be performed. Author: Robins Tharakan Reviewed-by: Tom Lane

pgsql: Doc: clarify partitioned table limitations

2022-09-05 Thread David Rowley
Doc: clarify partitioned table limitations Improve documentation regarding the limitations of unique and primary key constraints on partitioned tables. The existing documentation didn't make it clear that the constraint columns had to be present in the partition key as bare columns. The reader

pgsql: Doc: clarify partitioned table limitations

2022-09-05 Thread David Rowley
Doc: clarify partitioned table limitations Improve documentation regarding the limitations of unique and primary key constraints on partitioned tables. The existing documentation didn't make it clear that the constraint columns had to be present in the partition key as bare columns. The reader

pgsql: Doc: clarify partitioned table limitations

2022-09-05 Thread David Rowley
Doc: clarify partitioned table limitations Improve documentation regarding the limitations of unique and primary key constraints on partitioned tables. The existing documentation didn't make it clear that the constraint columns had to be present in the partition key as bare columns. The reader

pgsql: Doc: clarify partitioned table limitations

2022-09-05 Thread David Rowley
Doc: clarify partitioned table limitations Improve documentation regarding the limitations of unique and primary key constraints on partitioned tables. The existing documentation didn't make it clear that the constraint columns had to be present in the partition key as bare columns. The reader

pgsql: Doc: clarify partitioned table limitations

2022-09-05 Thread David Rowley
Doc: clarify partitioned table limitations Improve documentation regarding the limitations of unique and primary key constraints on partitioned tables. The existing documentation didn't make it clear that the constraint columns had to be present in the partition key as bare columns. The reader

pgsql: Doc: clarify partitioned table limitations

2022-09-05 Thread David Rowley
Doc: clarify partitioned table limitations Improve documentation regarding the limitations of unique and primary key constraints on partitioned tables. The existing documentation didn't make it clear that the constraint columns had to be present in the partition key as bare columns. The reader