pgsql: Straighten include order in guc-file.l

2022-11-02 Thread John Naylor
Straighten include order in guc-file.l Oversight in dac048f71eb Michael Paquier Reviewed by Julien Rouhaud Discussion: https://www.postgresql.org/message-id/Y2IATvRGo347Lvd1%40paquier.xyz Branch -- master Details ---

pgsql: Allow use of __sync_lock_test_and_set for spinlocks on any machi

2022-11-02 Thread Tom Lane
Allow use of __sync_lock_test_and_set for spinlocks on any machine. If we have no special-case code in s_lock.h for the current platform, but the compiler has __sync_lock_test_and_set, use that instead of failing. It's unlikely that anybody's __sync_lock_test_and_set would be so awful as to be

pgsql: Allow use of __sync_lock_test_and_set for spinlocks on any machi

2022-11-02 Thread Tom Lane
Allow use of __sync_lock_test_and_set for spinlocks on any machine. If we have no special-case code in s_lock.h for the current platform, but the compiler has __sync_lock_test_and_set, use that instead of failing. It's unlikely that anybody's __sync_lock_test_and_set would be so awful as to be

pgsql: Allow use of __sync_lock_test_and_set for spinlocks on any machi

2022-11-02 Thread Tom Lane
Allow use of __sync_lock_test_and_set for spinlocks on any machine. If we have no special-case code in s_lock.h for the current platform, but the compiler has __sync_lock_test_and_set, use that instead of failing. It's unlikely that anybody's __sync_lock_test_and_set would be so awful as to be

pgsql: Allow use of __sync_lock_test_and_set for spinlocks on any machi

2022-11-02 Thread Tom Lane
Allow use of __sync_lock_test_and_set for spinlocks on any machine. If we have no special-case code in s_lock.h for the current platform, but the compiler has __sync_lock_test_and_set, use that instead of failing. It's unlikely that anybody's __sync_lock_test_and_set would be so awful as to be

pgsql: Allow use of __sync_lock_test_and_set for spinlocks on any machi

2022-11-02 Thread Tom Lane
Allow use of __sync_lock_test_and_set for spinlocks on any machine. If we have no special-case code in s_lock.h for the current platform, but the compiler has __sync_lock_test_and_set, use that instead of failing. It's unlikely that anybody's __sync_lock_test_and_set would be so awful as to be

pgsql: Allow use of __sync_lock_test_and_set for spinlocks on any machi

2022-11-02 Thread Tom Lane
Allow use of __sync_lock_test_and_set for spinlocks on any machine. If we have no special-case code in s_lock.h for the current platform, but the compiler has __sync_lock_test_and_set, use that instead of failing. It's unlikely that anybody's __sync_lock_test_and_set would be so awful as to be

pgsql: Allow use of __sync_lock_test_and_set for spinlocks on any machi

2022-11-02 Thread Tom Lane
Allow use of __sync_lock_test_and_set for spinlocks on any machine. If we have no special-case code in s_lock.h for the current platform, but the compiler has __sync_lock_test_and_set, use that instead of failing. It's unlikely that anybody's __sync_lock_test_and_set would be so awful as to be

pgsql: pg_dump: Refactor code that constructs ALTER ... OWNER TO comman

2022-11-02 Thread Peter Eisentraut
pg_dump: Refactor code that constructs ALTER ... OWNER TO commands Avoid having to list all the possible object types twice. Instead, only _getObjectDescription() needs to know about specific object types. It communicates back to _printTocEntry() whether an owner is to be set. In passing,

pgsql: Defend against unsupported partition relkind in logical replicat

2022-11-02 Thread Tom Lane
Defend against unsupported partition relkind in logical replication worker. Since partitions can be foreign tables not only plain tables, but logical replication only supports plain tables, we'd better check the relkind of a partition after we find it. (There was some discussion of checking this

pgsql: Defend against unsupported partition relkind in logical replicat

2022-11-02 Thread Tom Lane
Defend against unsupported partition relkind in logical replication worker. Since partitions can be foreign tables not only plain tables, but logical replication only supports plain tables, we'd better check the relkind of a partition after we find it. (There was some discussion of checking this

pgsql: Defend against unsupported partition relkind in logical replicat

2022-11-02 Thread Tom Lane
Defend against unsupported partition relkind in logical replication worker. Since partitions can be foreign tables not only plain tables, but logical replication only supports plain tables, we'd better check the relkind of a partition after we find it. (There was some discussion of checking this

pgsql: Defend against unsupported partition relkind in logical replicat

2022-11-02 Thread Tom Lane
Defend against unsupported partition relkind in logical replication worker. Since partitions can be foreign tables not only plain tables, but logical replication only supports plain tables, we'd better check the relkind of a partition after we find it. (There was some discussion of checking this

pgsql: pg_dump: fix failure to dump comments on constraints in some cas

2022-11-02 Thread Tom Lane
pg_dump: fix failure to dump comments on constraints in some cases. Thinko in commit 5209c0ba0: I checked the wrong object's DUMP_COMPONENT_COMMENT bit in two places. Per bug #17675 from Franz-Josef Färber. Discussion: https://postgr.es/m/17675-c69c001e06390...@postgresql.org Branch --

pgsql: pg_dump: fix failure to dump comments on constraints in some cas

2022-11-02 Thread Tom Lane
pg_dump: fix failure to dump comments on constraints in some cases. Thinko in commit 5209c0ba0: I checked the wrong object's DUMP_COMPONENT_COMMENT bit in two places. Per bug #17675 from Franz-Josef Färber. Discussion: https://postgr.es/m/17675-c69c001e06390...@postgresql.org Branch --

pgsql: Fix copy-and-pasteo in comment.

2022-11-02 Thread Etsuro Fujita
Fix copy-and-pasteo in comment. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d5e1748f02fb54cff276e7714be474f4e9a9de72 Modified Files -- src/backend/executor/nodeModifyTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix copy-and-pasteo in comment.

2022-11-02 Thread Etsuro Fujita
Fix copy-and-pasteo in comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d54e79ba282c6a86d0c63e990e716b2c07a8656d Modified Files -- src/backend/executor/nodeModifyTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix copy-and-pasteo in comment.

2022-11-02 Thread Etsuro Fujita
Fix copy-and-pasteo in comment. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2896aa98ef569d99ea5b27cd6e7a2a789c14fd0a Modified Files -- src/backend/executor/nodeModifyTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix copy-and-pasteo in comment.

2022-11-02 Thread Etsuro Fujita
Fix copy-and-pasteo in comment. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/197cbca6bc7766aba215f34cb835306f101997b2 Modified Files -- src/backend/executor/nodeModifyTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix copy-and-pasteo in comment.

2022-11-02 Thread Etsuro Fujita
Fix copy-and-pasteo in comment. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0008ad8517aefa0787c925718a88da8af1a683c1 Modified Files -- src/backend/executor/nodeModifyTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix copy-and-pasteo in comment.

2022-11-02 Thread Etsuro Fujita
Fix copy-and-pasteo in comment. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/36abd1fb51df7c94ddfc26b0d08be7feb5f40241 Modified Files -- src/backend/executor/nodeModifyTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Doc: Update information about manually creating slots.

2022-11-02 Thread Amit Kapila
Doc: Update information about manually creating slots. There are some cases (e.g. when the subscription is created using the connect = false option) where the remote replication slot was not created automatically and the user must create it manually before the subscription can be activated. There