pgsql: pageinspect: Fix gist_page_items() with included columns

2023-05-18 Thread Michael Paquier
pageinspect: Fix gist_page_items() with included columns Non-leaf pages of GiST indexes contain key attributes, leaf pages contain both key and non-key attributes, and gist_page_items() ignored the handling of non-key attributes. This caused a few problems when using gist_page_items() on a GiST

pgsql: pageinspect: Fix gist_page_items() with included columns

2023-05-18 Thread Michael Paquier
pageinspect: Fix gist_page_items() with included columns Non-leaf pages of GiST indexes contain key attributes, leaf pages contain both key and non-key attributes, and gist_page_items() ignored the handling of non-key attributes. This caused a few problems when using gist_page_items() on a GiST

pgsql: pageinspect: Fix gist_page_items() with included columns

2023-05-18 Thread Michael Paquier
pageinspect: Fix gist_page_items() with included columns Non-leaf pages of GiST indexes contain key attributes, leaf pages contain both key and non-key attributes, and gist_page_items() ignored the handling of non-key attributes. This caused a few problems when using gist_page_items() on a GiST

pgsql: doc: improve pg_walinspect and role membership items

2023-05-18 Thread Bruce Momjian
doc: improve pg_walinspect and role membership items Reported-by: Peter Geoghegan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/613a7eca9ca9f13d1f9fd8a7806bbded1836e58f Modified Files -- doc/src/sgml/release-16.sgml | 6 +++--- 1 file changed, 3

pgsql: doc: improve description of adding roles as members

2023-05-18 Thread Bruce Momjian
doc: improve description of adding roles as members Discussion: https://postgr.es/m/zfvvzvqdliiwm...@momjian.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ce3673daded3fe3a101b0c008235dcf8bfe9ffec Modified Files --

pgsql: doc: update PG 16 relnotes for pg_walinspect changes

2023-05-18 Thread Bruce Momjian
doc: update PG 16 relnotes for pg_walinspect changes Reported-by: Peter Geoghegan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f79ee34702d485fb30427816b95e6c944660fc23 Modified Files -- doc/src/sgml/release-16.sgml | 128

pgsql: Show empty BRIN ranges in brin_page_items

2023-05-18 Thread Tomas Vondra
Show empty BRIN ranges in brin_page_items Commit 3581cbdcd6 added a flag to identify empty BRIN ranges. This adds the new flag to brin_page_items() output. This is kept as a separate commit as it should not be backpatched. Reviewed-by: Justin Pryzby, Matthias van de Meent, Alvaro Herrera

pgsql: Fix handling of empty ranges and NULLs in BRIN

2023-05-18 Thread Tomas Vondra
Fix handling of empty ranges and NULLs in BRIN BRIN indexes did not properly distinguish between summaries for empty (no rows) and all-NULL ranges, treating them as essentially the same thing. Summaries were initialized with allnulls=true, and opclasses simply reset allnulls to false when

pgsql: Fix handling of empty ranges and NULLs in BRIN

2023-05-18 Thread Tomas Vondra
Fix handling of empty ranges and NULLs in BRIN BRIN indexes did not properly distinguish between summaries for empty (no rows) and all-NULL ranges, treating them as essentially the same thing. Summaries were initialized with allnulls=true, and opclasses simply reset allnulls to false when

pgsql: Fix handling of empty ranges and NULLs in BRIN

2023-05-18 Thread Tomas Vondra
Fix handling of empty ranges and NULLs in BRIN BRIN indexes did not properly distinguish between summaries for empty (no rows) and all-NULL ranges, treating them as essentially the same thing. Summaries were initialized with allnulls=true, and opclasses simply reset allnulls to false when

pgsql: Fix handling of empty ranges and NULLs in BRIN

2023-05-18 Thread Tomas Vondra
Fix handling of empty ranges and NULLs in BRIN BRIN indexes did not properly distinguish between summaries for empty (no rows) and all-NULL ranges, treating them as essentially the same thing. Summaries were initialized with allnulls=true, and opclasses simply reset allnulls to false when

pgsql: Fix handling of empty ranges and NULLs in BRIN

2023-05-18 Thread Tomas Vondra
Fix handling of empty ranges and NULLs in BRIN BRIN indexes did not properly distinguish between summaries for empty (no rows) and all-NULL ranges, treating them as essentially the same thing. Summaries were initialized with allnulls=true, and opclasses simply reset allnulls to false when

pgsql: Fix handling of empty ranges and NULLs in BRIN

2023-05-18 Thread Tomas Vondra
Fix handling of empty ranges and NULLs in BRIN BRIN indexes did not properly distinguish between summaries for empty (no rows) and all-NULL ranges, treating them as essentially the same thing. Summaries were initialized with allnulls=true, and opclasses simply reset allnulls to false when

pgsql: doc: PG 16 relnotes, add freeze and update walinspect items

2023-05-18 Thread Bruce Momjian
doc: PG 16 relnotes, add freeze and update walinspect items Reported-by: Peter Geoghegan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1158c8c4e350b92ad6fecae894c8c1c777495954 Modified Files -- doc/src/sgml/release-16.sgml | 21 -

pgsql: docs: re-order some PG 16 relnotes items

2023-05-18 Thread Bruce Momjian
docs: re-order some PG 16 relnotes items Reported-by: Jonathan Katz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/07ef30a0282064f688a1923ba5e7c850f2ff5776 Modified Files -- doc/src/sgml/release-16.sgml | 66

pgsql: doc: more PG 16 relnote wording improvements

2023-05-18 Thread Bruce Momjian
doc: more PG 16 relnote wording improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d8a81108a87bd5e8e9ca136d3195e146a58b9e4d Modified Files -- doc/src/sgml/release-16.sgml | 109 +++ 1 file changed, 59

pgsql: Fix handling of NULLs when merging BRIN summaries

2023-05-18 Thread Tomas Vondra
Fix handling of NULLs when merging BRIN summaries When merging BRIN summaries, union_tuples() did not correctly update the target hasnulls/allnulls flags. When merging all-NULL summary into a summary without any NULL values, the result had both flags set to false (instead of having

pgsql: Fix handling of NULLs when merging BRIN summaries

2023-05-18 Thread Tomas Vondra
Fix handling of NULLs when merging BRIN summaries When merging BRIN summaries, union_tuples() did not correctly update the target hasnulls/allnulls flags. When merging all-NULL summary into a summary without any NULL values, the result had both flags set to false (instead of having

pgsql: Fix handling of NULLs when merging BRIN summaries

2023-05-18 Thread Tomas Vondra
Fix handling of NULLs when merging BRIN summaries When merging BRIN summaries, union_tuples() did not correctly update the target hasnulls/allnulls flags. When merging all-NULL summary into a summary without any NULL values, the result had both flags set to false (instead of having

pgsql: Fix handling of NULLs when merging BRIN summaries

2023-05-18 Thread Tomas Vondra
Fix handling of NULLs when merging BRIN summaries When merging BRIN summaries, union_tuples() did not correctly update the target hasnulls/allnulls flags. When merging all-NULL summary into a summary without any NULL values, the result had both flags set to false (instead of having

pgsql: Fix handling of NULLs when merging BRIN summaries

2023-05-18 Thread Tomas Vondra
Fix handling of NULLs when merging BRIN summaries When merging BRIN summaries, union_tuples() did not correctly update the target hasnulls/allnulls flags. When merging all-NULL summary into a summary without any NULL values, the result had both flags set to false (instead of having

pgsql: Fix handling of NULLs when merging BRIN summaries

2023-05-18 Thread Tomas Vondra
Fix handling of NULLs when merging BRIN summaries When merging BRIN summaries, union_tuples() did not correctly update the target hasnulls/allnulls flags. When merging all-NULL summary into a summary without any NULL values, the result had both flags set to false (instead of having

pgsql: doc: add more sections to PG 16 release notes

2023-05-18 Thread Bruce Momjian
doc: add more sections to PG 16 release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0791930aaaed2678daf694fa8b06cf81cd72cd69 Modified Files -- doc/src/sgml/release-16.sgml | 322 +++ 1 file changed, 170

pgsql: doc: first draft of the PG 16 release notes

2023-05-18 Thread Bruce Momjian
doc: first draft of the PG 16 release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/206a67e27fa15d75bd7b9ddf41d7e18d19bbb9db Modified Files -- doc/src/sgml/release-16.sgml | 3047 +- 1 file changed, 3037

pgsql: Fix documentation build broken by 1e16af8ab5.

2023-05-18 Thread Jeff Davis
Fix documentation build broken by 1e16af8ab5. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c9dc480a21f2746f5a96a8f68a22e633ba69c405 Modified Files -- doc/src/sgml/charset.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Doc improvements for language tags and custom ICU collations.

2023-05-18 Thread Jeff Davis
Doc improvements for language tags and custom ICU collations. Separate the documentation for language tags themselves from the available collation settings which can be included in a language tag. Include tables of the available options, more details about the effects of each option, and

pgsql: Tweak API of new function clause_is_computable_at().

2023-05-18 Thread Tom Lane
Tweak API of new function clause_is_computable_at(). Pass it the RestrictInfo under consideration, not just the clause_relids. This should save some trivial amount of code at the call sites, and it gives us more flexibility about what clause_is_computable_at() does. There's no actual functional