pgsql: Use fipshash in brin_multi test

2023-11-25 Thread Peter Eisentraut
Use fipshash in brin_multi test This fixes some md5() calls that snuck in in 0457109344 after we had removed them all in 208bf364a9. Reviewed-by: Tomas Vondra Discussion: https://www.postgresql.org/message-id/a35eaf0f-b19c-7797-e296-7b7e2adc4...@eisentraut.org Branch -- master Details

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Bruce Momjian
On Sat, Nov 25, 2023 at 02:18:43PM -0500, Bruce Momjian wrote: > I showed it previously in this thread: > > $ make postgres-A4.pdf 2>&1 | grep -v INFO > /usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version > '17devel' --stringparam img.src.path './' --stringparam

pgsql: Reuse BrinDesc and BrinRevmap in brininsert

2023-11-25 Thread Tomas Vondra
Reuse BrinDesc and BrinRevmap in brininsert The brininsert code used to initialize (and destroy) BrinDesc and BrinRevmap for each tuple, which is not free. This patch initializes these structures only once, and reuses them for all inserts in the same command. The data is passed through

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Bruce Momjian
On Sat, Nov 25, 2023 at 02:14:11PM -0500, Andrew Dunstan wrote: > > On 2023-11-25 Sa 11:34, Bruce Momjian wrote: > > On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote: > > > Bruce Momjian writes: > > > > On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote: > > > > > Yeah, for some

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Andrew Dunstan
On 2023-11-25 Sa 11:34, Bruce Momjian wrote: On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote: Bruce Momjian writes: On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote: Yeah, for some reason it only shows up when building PDFs.

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Bruce Momjian
On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote: > Bruce Momjian writes: > > On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote: > >> Yeah, for some reason it only shows up when building PDFs. > >>

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Tom Lane
Bruce Momjian writes: > On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote: >> Yeah, for some reason it only shows up when building PDFs. >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio=2023-11-25%2000%3A02%3A10 > Odd, I don't see that here. Maybe I need an upgraded

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Bruce Momjian
On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote: > Bruce Momjian writes: > > Can someone tell me how you saw that warning in the build farm? I don't > > see it in with a make check or a build of the docs. > > Yeah, for some reason it only shows up when building PDFs. > >

Re: [COMMITTERS] pgsql: Move pg_test_fsync from contrib/ to src/bin/

2023-11-25 Thread Bruce Momjian
On Mon, Apr 20, 2015 at 02:51:10PM +0900, Michael Paquier wrote: > On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut wrote: > > Move pg_test_fsync from contrib/ to src/bin/ > > Point of detail that I just noticed: wouldn't it be better to have a > header in pg_test_fsync.c of a shape similar to

pgsql: C comment: add header to pg_test_fsync.c

2023-11-25 Thread Bruce Momjian
C comment: add header to pg_test_fsync.c Reported-by: Michael Paquier Discussion: https://postgr.es/m/cab7npqt1c9wruw4+esgf_-ru7erboc50a4r3ts1s-yt4oay...@mail.gmail.com Author: Michael Paquier Backpatch-through: master Branch -- master Details ---

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Tom Lane
Bruce Momjian writes: > Can someone tell me how you saw that warning in the build farm? I don't > see it in with a make check or a build of the docs. Yeah, for some reason it only shows up when building PDFs.

pgsql: C comment: clarify that WAL files can be _recycled_ or removed

2023-11-25 Thread Bruce Momjian
C comment: clarify that WAL files can be _recycled_ or removed Reported-by: Michael Paquier Discussion: https://postgr.es/m/cab7npqsddf0heotqu3gsepgqx+9c+6kjld3r6anyh7kkfdd...@mail.gmail.com Author: Michael Paquier Backpatch-through: master Branch -- master Details ---

Re: pgsql: Doc: un-break PDF build.

2023-11-25 Thread Bruce Momjian
On Fri, Nov 24, 2023 at 08:16:12PM -0500, Bruce Momjian wrote: > > Thanks, I missed that issue. Can someone tell me how you saw that warning in the build farm? I don't see it in with a make check or a build of the docs. Attached is the patch that fixed it.