pgsql: Avoid unconditionally filling in missing values with NULL in pgo

2023-11-26 Thread Amit Kapila
Avoid unconditionally filling in missing values with NULL in pgoutput. 52e4f0cd4 introduced a bug in pgoutput in which missing values in tuples were incorrectly filled in with NULL. The problem was the use of CreateTupleDescCopy where CreateTupleDescCopyConstr was required, as the former drops

pgsql: Avoid unconditionally filling in missing values with NULL in pgo

2023-11-26 Thread Amit Kapila
Avoid unconditionally filling in missing values with NULL in pgoutput. 52e4f0cd4 introduced a bug in pgoutput in which missing values in tuples were incorrectly filled in with NULL. The problem was the use of CreateTupleDescCopy where CreateTupleDescCopyConstr was required, as the former drops

pgsql: Avoid unconditionally filling in missing values with NULL in pgo

2023-11-26 Thread Amit Kapila
Avoid unconditionally filling in missing values with NULL in pgoutput. 52e4f0cd4 introduced a bug in pgoutput in which missing values in tuples were incorrectly filled in with NULL. The problem was the use of CreateTupleDescCopy where CreateTupleDescCopyConstr was required, as the former drops

pgsql: Add NOT NULL checking of pg_stat_statements_reset() in tests

2023-11-26 Thread Alexander Korotkov
Add NOT NULL checking of pg_stat_statements_reset() in tests This is preliminary patch. It adds NOT NULL checking for the result of pg_stat_statements_reset() function. It is needed for upcoming patch "Track statement entry timestamp" that will change the result type of this function to the

pgsql: Track statement entry timestamp in contrib/pg_stat_statements

2023-11-26 Thread Alexander Korotkov
Track statement entry timestamp in contrib/pg_stat_statements This patch adds 'stats_since' and 'minmax_stats_since' columns to the pg_stat_statements view and pg_stat_statements() function. The new min/max reset mode for the pg_stat_stetments_reset() function is controlled by the parameter

pgsql: Fix race condition with BIO methods initialization in libpq with

2023-11-26 Thread Michael Paquier
Fix race condition with BIO methods initialization in libpq with threads The libpq code in charge of creating per-connection SSL objects was prone to a race condition when loading the custom BIO methods needed by my_SSL_set_fd(). As BIO methods are stored as a static variable, the initialization

pgsql: Fix race condition with BIO methods initialization in libpq with

2023-11-26 Thread Michael Paquier
Fix race condition with BIO methods initialization in libpq with threads The libpq code in charge of creating per-connection SSL objects was prone to a race condition when loading the custom BIO methods needed by my_SSL_set_fd(). As BIO methods are stored as a static variable, the initialization

pgsql: Fix race condition with BIO methods initialization in libpq with

2023-11-26 Thread Michael Paquier
Fix race condition with BIO methods initialization in libpq with threads The libpq code in charge of creating per-connection SSL objects was prone to a race condition when loading the custom BIO methods needed by my_SSL_set_fd(). As BIO methods are stored as a static variable, the initialization

pgsql: Fix race condition with BIO methods initialization in libpq with

2023-11-26 Thread Michael Paquier
Fix race condition with BIO methods initialization in libpq with threads The libpq code in charge of creating per-connection SSL objects was prone to a race condition when loading the custom BIO methods needed by my_SSL_set_fd(). As BIO methods are stored as a static variable, the initialization

pgsql: Fix race condition with BIO methods initialization in libpq with

2023-11-26 Thread Michael Paquier
Fix race condition with BIO methods initialization in libpq with threads The libpq code in charge of creating per-connection SSL objects was prone to a race condition when loading the custom BIO methods needed by my_SSL_set_fd(). As BIO methods are stored as a static variable, the initialization

pgsql: Fix race condition with BIO methods initialization in libpq with

2023-11-26 Thread Michael Paquier
Fix race condition with BIO methods initialization in libpq with threads The libpq code in charge of creating per-connection SSL objects was prone to a race condition when loading the custom BIO methods needed by my_SSL_set_fd(). As BIO methods are stored as a static variable, the initialization

pgsql: Update comments for pg_statistic catalog table

2023-11-26 Thread Alexander Korotkov
Update comments for pg_statistic catalog table Make a reminder that pg_stats view needs to be modified whenever a new slot kind is added. To prevent situations like 918eee0c49 when pg_stats was forgotten to be updated. Also, revise the comment that only non-null, non-empty rows are considered

pgsql: Display length and bounds histograms in pg_stats

2023-11-26 Thread Alexander Korotkov
Display length and bounds histograms in pg_stats Values corresponding to STATISTIC_KIND_RANGE_LENGTH_HISTOGRAM and STATISTIC_KIND_BOUNDS_HISTOGRAM were not exposed to pg_stats when these slot kinds were introduced in 918eee0c49. This commit adds the missing fields to pg_stats. Catversion is

pgsql: Doc: list AT TIME ZONE and COLLATE in operator precedence table.

2023-11-26 Thread Tom Lane
Doc: list AT TIME ZONE and COLLATE in operator precedence table. These constructs have precedence, but we forgot to list them. In HEAD, mention AT LOCAL as well as AT TIME ZONE. Per gripe from Shay Rojansky. Discussion:

pgsql: Doc: list AT TIME ZONE and COLLATE in operator precedence table.

2023-11-26 Thread Tom Lane
Doc: list AT TIME ZONE and COLLATE in operator precedence table. These constructs have precedence, but we forgot to list them. In HEAD, mention AT LOCAL as well as AT TIME ZONE. Per gripe from Shay Rojansky. Discussion:

pgsql: Doc: list AT TIME ZONE and COLLATE in operator precedence table.

2023-11-26 Thread Tom Lane
Doc: list AT TIME ZONE and COLLATE in operator precedence table. These constructs have precedence, but we forgot to list them. In HEAD, mention AT LOCAL as well as AT TIME ZONE. Per gripe from Shay Rojansky. Discussion:

pgsql: Doc: list AT TIME ZONE and COLLATE in operator precedence table.

2023-11-26 Thread Tom Lane
Doc: list AT TIME ZONE and COLLATE in operator precedence table. These constructs have precedence, but we forgot to list them. In HEAD, mention AT LOCAL as well as AT TIME ZONE. Per gripe from Shay Rojansky. Discussion:

pgsql: Doc: list AT TIME ZONE and COLLATE in operator precedence table.

2023-11-26 Thread Tom Lane
Doc: list AT TIME ZONE and COLLATE in operator precedence table. These constructs have precedence, but we forgot to list them. In HEAD, mention AT LOCAL as well as AT TIME ZONE. Per gripe from Shay Rojansky. Discussion:

pgsql: Doc: list AT TIME ZONE and COLLATE in operator precedence table.

2023-11-26 Thread Tom Lane
Doc: list AT TIME ZONE and COLLATE in operator precedence table. These constructs have precedence, but we forgot to list them. In HEAD, mention AT LOCAL as well as AT TIME ZONE. Per gripe from Shay Rojansky. Discussion:

pgsql: Fix brin.c indentation issues introduced by c1ec02be1d

2023-11-26 Thread Tomas Vondra
Fix brin.c indentation issues introduced by c1ec02be1d Per buildfarm member koel. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b2caf7c0e1ebada614b6aa3004d826080a07e7e4 Modified Files -- src/backend/access/brin/brin.c | 3 ++-