pgsql: Initialize data directories with --lc-messages=C for tests.

2023-12-21 Thread Jeff Davis
Initialize data directories with --lc-messages=C for tests. Commit db6d9891e8 changed them to be initialized with --no-locale, but that reduced the test coverage for non-C locales. Discussion: https://postgr.es/m/0d47e5ecc037b3908149aad5f2a987793cf938bd.camel%40j-davis.com Branch -- master

pgsql: Replace nonsense comment with a relevant one.

2023-12-21 Thread Robert Haas
Replace nonsense comment with a relevant one. Per report from Alexander Lakhin. Discussion: http://postgr.es/m/061cccf7-0cac-804f-4c2a-9d6da8e38...@gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ffc6ab9b56ae02a64349c8c6b59dd659dab5516a Modified Files

pgsql: Fix numerous typos in incremental backup commits.

2023-12-21 Thread Robert Haas
Fix numerous typos in incremental backup commits. Apparently, spell check would have been a really good idea. Alexander Lakhin, with a few additions as per an off-list report from Andres Freund. Discussion: http://postgr.es/m/f08f7c60-1ad3-0b57-d580-54b11f07c...@gmail.com Branch -- master

pgsql: pg_combinebackup didn't clean its tmp_check directory, either.

2023-12-21 Thread Tom Lane
pg_combinebackup didn't clean its tmp_check directory, either. Another oversight in dc2123400, visible when building/testing in the source directory. (There's a lot of stuff we could simplify if we stop supporting that case, but for now it's still mainstream.) Branch -- master Details

pgsql: Avoid trying to fetch metapage of an SPGist partitioned index.

2023-12-21 Thread Tom Lane
Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should

pgsql: Avoid trying to fetch metapage of an SPGist partitioned index.

2023-12-21 Thread Tom Lane
Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should

pgsql: Avoid trying to fetch metapage of an SPGist partitioned index.

2023-12-21 Thread Tom Lane
Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should

pgsql: Avoid trying to fetch metapage of an SPGist partitioned index.

2023-12-21 Thread Tom Lane
Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should

pgsql: Avoid trying to fetch metapage of an SPGist partitioned index.

2023-12-21 Thread Tom Lane
Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should

pgsql: pg_combinebackup's .gitignore file is incomplete.

2023-12-21 Thread Tom Lane
pg_combinebackup's .gitignore file is incomplete. Oversight in commit dc2123400, evidently. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0590480132bf5db7383a90a29e7b3e29a2a4743a Modified Files -- src/bin/pg_combinebackup/.gitignore | 2 ++ 1 file

pgsql: Avoid trying to fetch metapage of an SPGist partitioned index.

2023-12-21 Thread Tom Lane
Avoid trying to fetch metapage of an SPGist partitioned index. This is necessary when spgcanreturn() is invoked on a partitioned index, and the failure might be reachable in other scenarios as well. The rest of what spgGetCache() does is perfectly sensible for a partitioned index, so we should

pgsql: Fix BEFORE ROW trigger handling in cross-partition MERGE update.

2023-12-21 Thread Dean Rasheed
Fix BEFORE ROW trigger handling in cross-partition MERGE update. Fix a bug during MERGE if a cross-partition update is attempted on a partitioned table with a BEFORE DELETE ROW trigger that returns NULL, to prevent the update. This would cause an error to be thrown, or an assert failure in an

pgsql: Fix BEFORE ROW trigger handling in cross-partition MERGE update.

2023-12-21 Thread Dean Rasheed
Fix BEFORE ROW trigger handling in cross-partition MERGE update. Fix a bug during MERGE if a cross-partition update is attempted on a partitioned table with a BEFORE DELETE ROW trigger that returns NULL, to prevent the update. This would cause an error to be thrown, or an assert failure in an

pgsql: Fix BEFORE ROW trigger handling in cross-partition MERGE update.

2023-12-21 Thread Dean Rasheed
Fix BEFORE ROW trigger handling in cross-partition MERGE update. Fix a bug during MERGE if a cross-partition update is attempted on a partitioned table with a BEFORE DELETE ROW trigger that returns NULL, to prevent the update. This would cause an error to be thrown, or an assert failure in an

pgsql: Fix prologue of get_partition_ancestors()

2023-12-21 Thread Peter Eisentraut
Fix prologue of get_partition_ancestors() The callers of this function assume that the first Oid in the list returned by this function corresponds to the immediate parent and the last on corresponds to the topmost parent. Make that explicit in the function prologue. Author: Ashutosh Bapat

pgsql: meson: Make sed optional

2023-12-21 Thread Peter Eisentraut
meson: Make sed optional sed is used only if dtrace or selinux are enabled. Those options are only used on Unix platforms, which should have sed. But we don't want to make sed a hard requirement on Windows, which was the case in meson until now. This just changes sed to be not-required by

pgsql: meson: Make gzip and tar optional

2023-12-21 Thread Peter Eisentraut
meson: Make gzip and tar optional They are only used for some tests. The tests are already set to skip as appropriate if they are not available. Discussion: https://www.postgresql.org/message-id/flat/ZQzp_VMJcerM1Cs_%40paquier.xyz Branch -- master Details ---