pgsql: Fix an intermetant BF failure in 003_logical_slots.

2024-01-10 Thread Amit Kapila
Fix an intermetant BF failure in 003_logical_slots. During upgrade, when pg_restore performs CREATE DATABASE, bgwriter or checkpointer may flush buffers and hold a file handle for pg_largeobject, so later TRUNCATE pg_largeobject command will fail if OS (such as older Windows versions) doesn't

pgsql: Update documentation of default fdw_tuple_cost

2024-01-10 Thread John Naylor
Update documentation of default fdw_tuple_cost Follow up to cac169d68 Umair Shahid Reviewed by Richard Guo and Chris Travers Discussion: https://postgr.es/m/CALVUYo9RECc5gwD%2B4SRM5Es%2Bbg9cpNfhd3_qUjf7kVTGyLpFJg%40mail.gmail.com Branch -- master Details ---

pgsql: pg_regress: Disable autoruns for cmd.exe on Windows

2024-01-10 Thread Michael Paquier
pg_regress: Disable autoruns for cmd.exe on Windows This is similar to 9886744a361b, to prevent the execution of other programs due to autorun configurations which could influence the postmaster startup. Like the other change, no backpatch is done. Discussion:

pgsql: Restore initdb's old behavior of always setting the lc_xxx GUCs.

2024-01-10 Thread Tom Lane
Restore initdb's old behavior of always setting the lc_xxx GUCs. In commit 3e51b278d I (tgl) caused initdb to leave lc_messages and other lc_xxx GUCs commented-out in the installed postgresql.conf file if they were going to be set to 'C'. This was a hack for cosmetic purposes, and it was buggy

pgsql: Restore initdb's old behavior of always setting the lc_xxx GUCs.

2024-01-10 Thread Tom Lane
Restore initdb's old behavior of always setting the lc_xxx GUCs. In commit 3e51b278d I (tgl) caused initdb to leave lc_messages and other lc_xxx GUCs commented-out in the installed postgresql.conf file if they were going to be set to 'C'. This was a hack for cosmetic purposes, and it was buggy

pgsql: Allow noise semicolons ending psql \sf, \ef, \sv, \ev commands.

2024-01-10 Thread Tom Lane
Allow noise semicolons ending psql \sf, \ef, \sv, \ev commands. Many psql backslash commands tolerate trailing semicolons, even though that's not part of the official syntax. These did not. They tried to, by passing semicolon = true to psql_scan_slash_option, but that function ignored this

pgsql: Fix Asserts in calc_non_nestloop_required_outer().

2024-01-10 Thread Tom Lane
Fix Asserts in calc_non_nestloop_required_outer(). These were not testing the same thing as the comparable Assert in calc_nestloop_required_outer(), because we neglected to map the given Paths' relids to top-level relids. When considering a partition child join the latter is the correct thing to

pgsql: Handle WindowClause.runCondition in tree walker/mutator function

2024-01-10 Thread Tom Lane
Handle WindowClause.runCondition in tree walker/mutator functions. Commit 9d9c02ccd, which added the notion of a "run condition" for window functions, neglected to teach nodeFuncs.c to process the new field. Remarkably, that doesn't seem to have had any ill effects before we invented

pgsql: Handle WindowClause.runCondition in tree walker/mutator function

2024-01-10 Thread Tom Lane
Handle WindowClause.runCondition in tree walker/mutator functions. Commit 9d9c02ccd, which added the notion of a "run condition" for window functions, neglected to teach nodeFuncs.c to process the new field. Remarkably, that doesn't seem to have had any ill effects before we invented

pgsql: Handle WindowClause.runCondition in tree walker/mutator function

2024-01-10 Thread Tom Lane
Handle WindowClause.runCondition in tree walker/mutator functions. Commit 9d9c02ccd, which added the notion of a "run condition" for window functions, neglected to teach nodeFuncs.c to process the new field. Remarkably, that doesn't seem to have had any ill effects before we invented

pgsql: doc: clarify who owns the initdb-created cluster, by default

2024-01-10 Thread Bruce Momjian
doc: clarify who owns the initdb-created cluster, by default Discussion: https://postgr.es/m/zzotbsdkebg_h...@momjian.us Backpatch-through: 16 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5b2da240e01ecaef8181b0feebaeb69e6fefdaa0 Modified Files --

pgsql: doc: clarify who owns the initdb-created cluster, by default

2024-01-10 Thread Bruce Momjian
doc: clarify who owns the initdb-created cluster, by default Discussion: https://postgr.es/m/zzotbsdkebg_h...@momjian.us Backpatch-through: 16 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/65ee2ed0d0da6dd45853b050b4d59634d64479bd Modified Files

pgsql: Show the default checkpoint method in the pg_basebackup help mes

2024-01-10 Thread Magnus Hagander
Show the default checkpoint method in the pg_basebackup help message Author: Michael Banck Reviewed-By: Aleksander Alekseev, Michael Paquier, Peter Eisentraut Discussion: https://postgr.es/m/6530f954.170a0220.5637c.9...@mx.google.com Branch -- master Details ---