pgsql: Fix warnings in cpluspluscheck

2024-02-07 Thread John Naylor
Fix warnings in cpluspluscheck Various int variables were compared to macros that are of type size_t, which caused -Wsign-compare warnings in cpluspluscheck. Change those to size_t, which also better describes their purpose. Per report from Peter Eisentraut Discussion:

pgsql: Rename static function to avoid conflicting names

2024-02-07 Thread Daniel Gustafsson
Rename static function to avoid conflicting names Commit a4fd3aa719e moved setup_cancel_handler out of psql and exporeted it as a global function. While pg_dump isn't using the header it's exported in, having a conflicting name still risks causing confusion when grepping the code for callsites,

pgsql: Remove Start* macros in postmaster.c.

2024-02-07 Thread Nathan Bossart
Remove Start* macros in postmaster.c. These macros are just shorthands for calling StartChildProcess() with the appropriate process type, and they arguably make the code harder to understand. Suggested-by: Andres Freund Author: Reid Thompson Reviewed-by: Bharath Rupireddy Discussion:

pgsql: Update PQparameterStatus and ParameterStatus docs

2024-02-07 Thread Alvaro Herrera
Update PQparameterStatus and ParameterStatus docs Cover scram_iterations, which was added in commit b577743000cd. While at it, turn the list into a with 2 columns, which is much nicer to read. In master, remove mentions of antediluvian versions before which some parameters were not reported.

pgsql: Update PQparameterStatus and ParameterStatus docs

2024-02-07 Thread Alvaro Herrera
Update PQparameterStatus and ParameterStatus docs Cover scram_iterations, which was added in commit b577743000cd. While at it, turn the list into a with 2 columns, which is much nicer to read. In master, remove mentions of antediluvian versions before which some parameters were not reported.

pgsql: Adjust reltarget assignment for UPPERREL_PARTIAL_DISTINCT rel

2024-02-07 Thread David Rowley
Adjust reltarget assignment for UPPERREL_PARTIAL_DISTINCT rel A comment in grouping_planner() claimed that the PlannerInfo upper_targets array was not used in core code. However, the code that generated the paths for the UPPERREL_PARTIAL_DISTINCT rel made that comment untrue. Here we adjust the