pgsql: Fix the incorrect format specifier used in commit 7a424ece48.

2024-02-15 Thread Amit Kapila
Fix the incorrect format specifier used in commit 7a424ece48. Author: Hou Zhijie Discussion: https://postgr.es/m/514f6f2f-6833-4539-39f1-96cd1e011...@enterprisedb.com Discussion: https://postgr.es/m/os0pr01mb5716cb015bad807b29bc55be94...@os0pr01mb5716.jpnprd01.prod.outlook.com Branch --

pgsql: Change the LOG level in 040_standby_failover_slots_sync.pl to DE

2024-02-15 Thread Amit Kapila
Change the LOG level in 040_standby_failover_slots_sync.pl to DEBUG2. Temporarily change the log level of 040_standby_failover_slots_sync.pl to DEBUG2. This is to get more information about BF failures. We will reset it back to default once the tests are stabilized. Author: Hou Zhijie

pgsql: Add more LOG and DEBUG messages for slot synchronization.

2024-02-15 Thread Amit Kapila
Add more LOG and DEBUG messages for slot synchronization. This provides more information about remote slots during synchronization which helps in debugging bugs and BF failures due to test case issues. We might later want to change the LOG message added by this patch to DEBUG1. Author: Hou

Re: pgsql: Allow upgrades to preserve the full subscription's state.

2024-02-15 Thread Amit Kapila
On Thu, Feb 15, 2024 at 7:15 PM Peter Eisentraut wrote: > > On 02.01.24 04:07, Amit Kapila wrote: > > Allow upgrades to preserve the full subscription's state. > > The added test src/bin/pg_upgrade/t/004_subscription.pl does not pass when > > export PG_TEST_PG_UPGRADE_MODE=--link > > is set. > >

pgsql: Attempt to stabilize flapping regression test

2024-02-15 Thread David Rowley
Attempt to stabilize flapping regression test Per buildfarm animal mylodon, the plan for this test was sometimes swapping the join order for tenk1 and tenk2. Given that add_path() has no code that would cause this fluctuation when given paths with consistent costs, this indicates that the costs

pgsql: Followup fixes for transaction_timeout

2024-02-15 Thread Alexander Korotkov
Followup fixes for transaction_timeout Don't deal with transaction timeout in PostgresMain(). Instead, release transaction timeout activated by StartTransaction() in CommitTransaction()/AbortTransaction()/PrepareTransaction(). Deal with both enabling and disabling transaction timeout in

pgsql: Introduce transaction_timeout

2024-02-15 Thread Alexander Korotkov
Introduce transaction_timeout This commit adds timeout that is expected to be used as a prevention of long-running queries. Any session within the transaction will be terminated after spanning longer than this timeout. However, this timeout is not applied to prepared transactions. Only

pgsql: Doc: improve a couple of comments in postgresql.conf.sample.

2024-02-15 Thread Tom Lane
Doc: improve a couple of comments in postgresql.conf.sample. Clarify comments associated with max_parallel_workers and related settings. Per bug #18343 from Christopher Kline. Discussion: https://postgr.es/m/18343-3a5e903d1d369...@postgresql.org Branch -- REL_15_STABLE Details ---

pgsql: Doc: improve a couple of comments in postgresql.conf.sample.

2024-02-15 Thread Tom Lane
Doc: improve a couple of comments in postgresql.conf.sample. Clarify comments associated with max_parallel_workers and related settings. Per bug #18343 from Christopher Kline. Discussion: https://postgr.es/m/18343-3a5e903d1d369...@postgresql.org Branch -- REL_16_STABLE Details ---

pgsql: Doc: improve a couple of comments in postgresql.conf.sample.

2024-02-15 Thread Tom Lane
Doc: improve a couple of comments in postgresql.conf.sample. Clarify comments associated with max_parallel_workers and related settings. Per bug #18343 from Christopher Kline. Discussion: https://postgr.es/m/18343-3a5e903d1d369...@postgresql.org Branch -- REL_14_STABLE Details ---

pgsql: Doc: improve a couple of comments in postgresql.conf.sample.

2024-02-15 Thread Tom Lane
Doc: improve a couple of comments in postgresql.conf.sample. Clarify comments associated with max_parallel_workers and related settings. Per bug #18343 from Christopher Kline. Discussion: https://postgr.es/m/18343-3a5e903d1d369...@postgresql.org Branch -- REL_13_STABLE Details ---

pgsql: Doc: improve a couple of comments in postgresql.conf.sample.

2024-02-15 Thread Tom Lane
Doc: improve a couple of comments in postgresql.conf.sample. Clarify comments associated with max_parallel_workers and related settings. Per bug #18343 from Christopher Kline. Discussion: https://postgr.es/m/18343-3a5e903d1d369...@postgresql.org Branch -- master Details ---

pgsql: Doc: improve a couple of comments in postgresql.conf.sample.

2024-02-15 Thread Tom Lane
Doc: improve a couple of comments in postgresql.conf.sample. Clarify comments associated with max_parallel_workers and related settings. Per bug #18343 from Christopher Kline. Discussion: https://postgr.es/m/18343-3a5e903d1d369...@postgresql.org Branch -- REL_12_STABLE Details ---

Re: pgsql: Allow upgrades to preserve the full subscription's state.

2024-02-15 Thread Peter Eisentraut
On 02.01.24 04:07, Amit Kapila wrote: Allow upgrades to preserve the full subscription's state. The added test src/bin/pg_upgrade/t/004_subscription.pl does not pass when export PG_TEST_PG_UPGRADE_MODE=--link is set. Could you check whether that could be fixed, or otherwise if the test

pgsql: Pull up ANY-SUBLINK with the necessary lateral support.

2024-02-15 Thread Alexander Korotkov
Pull up ANY-SUBLINK with the necessary lateral support. For ANY-SUBLINK, we adopted a two-stage pull-up approach to handle different types of scenarios. In the first stage, the sublink is pulled up as a subquery. Because of this, when writing this code, we did not have the ability to perform

pgsql: Allow passing extra options to initdb for tests

2024-02-15 Thread Peter Eisentraut
Allow passing extra options to initdb for tests Setting the environment variable PG_TEST_INITDB_EXTRA_OPTS passes extra options to initdb run by pg_regress or PostgreSQL::Test::Cluster's init. This can be useful for a wide variety of uses, like running all tests with checksums enabled, or with