pgsql: Remove overzealous array element type assertion.

2024-04-21 Thread Peter Geoghegan
Remove overzealous array element type assertion. This led to spurious assertion failures in certain scenarios involving pseudo types. Oversight in commit 5bf748b8, which enhanced nbtree ScalarArrayOp execution. Reported-By: Richard Guo Discussion:

pgsql: createdb: compare strategy case-insensitive

2024-04-21 Thread Tomas Vondra
createdb: compare strategy case-insensitive When specifying the createdb strategy, the documentation suggests valid options are FILE_COPY and WAL_LOG, but the code does case-sensitive comparison and accepts only "file_copy" and "wal_log" as valid. Fixed by doing a case-insensitive comparison

pgsql: createdb: compare strategy case-insensitive

2024-04-21 Thread Tomas Vondra
createdb: compare strategy case-insensitive When specifying the createdb strategy, the documentation suggests valid options are FILE_COPY and WAL_LOG, but the code does case-sensitive comparison and accepts only "file_copy" and "wal_log" as valid. Fixed by doing a case-insensitive comparison

pgsql: createdb: compare strategy case-insensitive

2024-04-21 Thread Tomas Vondra
createdb: compare strategy case-insensitive When specifying the createdb strategy, the documentation suggests valid options are FILE_COPY and WAL_LOG, but the code does case-sensitive comparison and accepts only "file_copy" and "wal_log" as valid. Fixed by doing a case-insensitive comparison

pgsql: Make postgres_fdw request remote time zone 'GMT' not 'UTC'.

2024-04-21 Thread Tom Lane
Make postgres_fdw request remote time zone 'GMT' not 'UTC'. This should have the same results for all practical purposes. The advantage of selecting 'GMT' is that it's guaranteed to work even when the remote system's timezone database is missing entries, because pg_tzset() hard-wires handling of

pgsql: Make postgres_fdw request remote time zone 'GMT' not 'UTC'.

2024-04-21 Thread Tom Lane
Make postgres_fdw request remote time zone 'GMT' not 'UTC'. This should have the same results for all practical purposes. The advantage of selecting 'GMT' is that it's guaranteed to work even when the remote system's timezone database is missing entries, because pg_tzset() hard-wires handling of

pgsql: Make postgres_fdw request remote time zone 'GMT' not 'UTC'.

2024-04-21 Thread Tom Lane
Make postgres_fdw request remote time zone 'GMT' not 'UTC'. This should have the same results for all practical purposes. The advantage of selecting 'GMT' is that it's guaranteed to work even when the remote system's timezone database is missing entries, because pg_tzset() hard-wires handling of

pgsql: Make postgres_fdw request remote time zone 'GMT' not 'UTC'.

2024-04-21 Thread Tom Lane
Make postgres_fdw request remote time zone 'GMT' not 'UTC'. This should have the same results for all practical purposes. The advantage of selecting 'GMT' is that it's guaranteed to work even when the remote system's timezone database is missing entries, because pg_tzset() hard-wires handling of

pgsql: Make postgres_fdw request remote time zone 'GMT' not 'UTC'.

2024-04-21 Thread Tom Lane
Make postgres_fdw request remote time zone 'GMT' not 'UTC'. This should have the same results for all practical purposes. The advantage of selecting 'GMT' is that it's guaranteed to work even when the remote system's timezone database is missing entries, because pg_tzset() hard-wires handling of

pgsql: Make postgres_fdw request remote time zone 'GMT' not 'UTC'.

2024-04-21 Thread Tom Lane
Make postgres_fdw request remote time zone 'GMT' not 'UTC'. This should have the same results for all practical purposes. The advantage of selecting 'GMT' is that it's guaranteed to work even when the remote system's timezone database is missing entries, because pg_tzset() hard-wires handling of

Re: pgsql: createdb: Correct parameter name in SGML docs

2024-04-21 Thread Tomas Vondra
On 4/21/24 03:25, Justin Pryzby wrote: > should be backpatched to v15 > https://www.postgresql.org/docs/15/app-createdb.html > Done. I realized the backpatching late after thinking about the other createdb issue I ran into, but it was late so I left it for today. T. -- Tomas Vondra

pgsql: createdb: Correct parameter name in SGML docs

2024-04-21 Thread Tomas Vondra
createdb: Correct parameter name in SGML docs Commit 9c08aea6a309 introduced -S/--strategy option, but forgot to rename the parameter when copying the -T/--template bit. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/722f17049729600e3a885b1c1d975a0b0fa2e1e4

pgsql: createdb: Correct parameter name in SGML docs

2024-04-21 Thread Tomas Vondra
createdb: Correct parameter name in SGML docs Commit 9c08aea6a309 introduced -S/--strategy option, but forgot to rename the parameter when copying the -T/--template bit. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/877a64869996b702bb9cd5b39ebbc45febcd081a