pgsql: Fix documentation and comments on what happens after GSS rejecti

2024-04-28 Thread Heikki Linnakangas
Fix documentation and comments on what happens after GSS rejection The paragraph in the docs and the comment applied to sslnegotiaton=direct, but not sslnegotiation=requiredirect. In 'requiredirect' mode, negotiated SSL is never used. Move the paragraph in the docs under the description of

pgsql: Throw a more on-point error for functions depending on columns.

2024-04-28 Thread Tom Lane
Throw a more on-point error for functions depending on columns. ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects depending on the column whose type is to be altered. That indeed wasn't possible when this code was written, but it is possible since we introduced new-style SQL

pgsql: Throw a more on-point error for functions depending on columns.

2024-04-28 Thread Tom Lane
Throw a more on-point error for functions depending on columns. ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects depending on the column whose type is to be altered. That indeed wasn't possible when this code was written, but it is possible since we introduced new-style SQL

pgsql: Throw a more on-point error for functions depending on columns.

2024-04-28 Thread Tom Lane
Throw a more on-point error for functions depending on columns. ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects depending on the column whose type is to be altered. That indeed wasn't possible when this code was written, but it is possible since we introduced new-style SQL

pgsql: Throw a more on-point error for functions depending on columns.

2024-04-28 Thread Tom Lane
Throw a more on-point error for functions depending on columns. ALTER COLUMN TYPE wasn't expecting to find any pg_proc objects depending on the column whose type is to be altered. That indeed wasn't possible when this code was written, but it is possible since we introduced new-style SQL

pgsql: Detect more overflows in timestamp[tz]_pl_interval.

2024-04-28 Thread Tom Lane
Detect more overflows in timestamp[tz]_pl_interval. In commit 25cd2d640 I (tgl) opined that "The additions of the months and microseconds fields could also overflow, of course. However, I believe we need no additional checks there; the existing range checks should catch such cases". This is

pgsql: Detect more overflows in timestamp[tz]_pl_interval.

2024-04-28 Thread Tom Lane
Detect more overflows in timestamp[tz]_pl_interval. In commit 25cd2d640 I (tgl) opined that "The additions of the months and microseconds fields could also overflow, of course. However, I believe we need no additional checks there; the existing range checks should catch such cases". This is

pgsql: Detect more overflows in timestamp[tz]_pl_interval.

2024-04-28 Thread Tom Lane
Detect more overflows in timestamp[tz]_pl_interval. In commit 25cd2d640 I (tgl) opined that "The additions of the months and microseconds fields could also overflow, of course. However, I believe we need no additional checks there; the existing range checks should catch such cases". This is

pgsql: Detect more overflows in timestamp[tz]_pl_interval.

2024-04-28 Thread Tom Lane
Detect more overflows in timestamp[tz]_pl_interval. In commit 25cd2d640 I (tgl) opined that "The additions of the months and microseconds fields could also overflow, of course. However, I believe we need no additional checks there; the existing range checks should catch such cases". This is

pgsql: Detect more overflows in timestamp[tz]_pl_interval.

2024-04-28 Thread Tom Lane
Detect more overflows in timestamp[tz]_pl_interval. In commit 25cd2d640 I (tgl) opined that "The additions of the months and microseconds fields could also overflow, of course. However, I believe we need no additional checks there; the existing range checks should catch such cases". This is

pgsql: Detect more overflows in timestamp[tz]_pl_interval.

2024-04-28 Thread Tom Lane
Detect more overflows in timestamp[tz]_pl_interval. In commit 25cd2d640 I (tgl) opined that "The additions of the months and microseconds fields could also overflow, of course. However, I believe we need no additional checks there; the existing range checks should catch such cases". This is

pgsql: Fix duplicated consecutive words in comments

2024-04-28 Thread David Rowley
Fix duplicated consecutive words in comments Also, fix a comment incorrectly referencing the "streaming read API". This was renamed to "read stream" shortly before being committed. Discussion: https://postgr.es/m/caaphdvq-2zdqytm_hf3rmvf0qg5ps9jtfaj5qtc9xh9pwvw...@mail.gmail.com Branch --