pgsql: Remove unused typedefs

2024-05-16 Thread Peter Eisentraut
Remove unused typedefs There were a few typedefs that were never used to define a variable or field. This had the effect that the buildfarm's typedefs.list would not include them, and so they would need to be re-added manually to keep the overall pgindent result perfectly clean. We can easily

pgsql: Remove enum WaitEventExtension

2024-05-16 Thread Michael Paquier
Remove enum WaitEventExtension This enum was used to determine the first ID to use when assigning a custom wait event for extensions, which is always 1. It was kept so as it would be possible to add new in-core wait events in the category "Extension". There is no such thing currently, so let's

pgsql: Fix documentation about DROP DATABASE FORCE process termination

2024-05-16 Thread Noah Misch
Fix documentation about DROP DATABASE FORCE process termination rights. Specifically, it terminates a background worker even if the caller couldn't terminate the background worker with pg_terminate_backend(). Commit 3a9b18b3095366cd0c4305441d426d04572d88c1 neglected to update this. Back-patch to

pgsql: Fix documentation about DROP DATABASE FORCE process termination

2024-05-16 Thread Noah Misch
Fix documentation about DROP DATABASE FORCE process termination rights. Specifically, it terminates a background worker even if the caller couldn't terminate the background worker with pg_terminate_backend(). Commit 3a9b18b3095366cd0c4305441d426d04572d88c1 neglected to update this. Back-patch to

pgsql: Fix documentation about DROP DATABASE FORCE process termination

2024-05-16 Thread Noah Misch
Fix documentation about DROP DATABASE FORCE process termination rights. Specifically, it terminates a background worker even if the caller couldn't terminate the background worker with pg_terminate_backend(). Commit 3a9b18b3095366cd0c4305441d426d04572d88c1 neglected to update this. Back-patch to

pgsql: Fix documentation about DROP DATABASE FORCE process termination

2024-05-16 Thread Noah Misch
Fix documentation about DROP DATABASE FORCE process termination rights. Specifically, it terminates a background worker even if the caller couldn't terminate the background worker with pg_terminate_backend(). Commit 3a9b18b3095366cd0c4305441d426d04572d88c1 neglected to update this. Back-patch to

pgsql: Fix documentation about DROP DATABASE FORCE process termination

2024-05-16 Thread Noah Misch
Fix documentation about DROP DATABASE FORCE process termination rights. Specifically, it terminates a background worker even if the caller couldn't terminate the background worker with pg_terminate_backend(). Commit 3a9b18b3095366cd0c4305441d426d04572d88c1 neglected to update this. Back-patch to

pgsql: BitmapHeapScan: Remove incorrect assert and reset field

2024-05-16 Thread Melanie Plageman
BitmapHeapScan: Remove incorrect assert and reset field 04e72ed617be pushed the skip fetch optimization (allowing bitmap heap scans to operate like index-only scans if none of the underlying data is needed) into heap AM implementations of bitmap table scan callbacks. 04e72ed617be added an assert

pgsql: Remove option to fall back from direct to postgres SSL negotiati

2024-05-16 Thread Heikki Linnakangas
Remove option to fall back from direct to postgres SSL negotiation There were three problems with the sslnegotiation options: 1. The sslmode=prefer and sslnegotiation=requiredirect combination was somewhat dangerous, as you might unintentionally fall back to plaintext authentication when

pgsql: Document that increasing max_connections uses more resources.

2024-05-16 Thread Robert Haas
Document that increasing max_connections uses more resources. Roberto Mello Discussion: http://postgr.es/m/CAKz==bJBCWrvN77fmuZ2XqD3jazWEb=e80aa4yv9c9tq61y...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8ba346283335f7ee5bac2e904c2daad49a204c7c

pgsql: Doc: use true|false rather than on|off for "failover" option

2024-05-16 Thread David Rowley
Doc: use true|false rather than on|off for "failover" option The CREATE SUBSCRIPTION documentation mentions "false" is the default option, so let's use true|false rather than on|off in the text which talks about this option in the ALTER SUBSCRIPTION page. The other boolean options mentioned in

pgsql: pg_amcheck: Put new options in consistent order in --help and ma

2024-05-16 Thread Peter Eisentraut
pg_amcheck: Put new options in consistent order in --help and man page Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/94af84f00c5fd3ea840759d85a73204d64e28248 Modified Files -- doc/src/sgml/ref/pg_amcheck.sgml | 22 +++---

pgsql: Revert temporal primary keys and foreign keys

2024-05-16 Thread Peter Eisentraut
Revert temporal primary keys and foreign keys This feature set did not handle empty ranges correctly, and it's now too late for PostgreSQL 17 to fix it. The following commits are reverted: 6db4598fcb8 Add stratnum GiST support function 46a0cd4cefb Add temporal PRIMARY KEY and UNIQUE