Re: pgsql: Add assert checking to pg_leftmost_one_pos32() and friends

2023-02-21 Thread John Naylor
On Tue, Feb 21, 2023 at 11:59 AM John Naylor wrote: > > On Mon, Feb 20, 2023 at 10:17 PM Tom Lane wrote: > > > > John Naylor writes: > > > Add assert checking to pg_leftmost_one_pos32() and friends > > > > I can see that this was worth writing for testing purposes, but > > is it really worth

Re: pgsql: Add assert checking to pg_leftmost_one_pos32() and friends

2023-02-20 Thread John Naylor
On Mon, Feb 20, 2023 at 10:17 PM Tom Lane wrote: > > John Naylor writes: > > Add assert checking to pg_leftmost_one_pos32() and friends > > I can see that this was worth writing for testing purposes, but > is it really worth carrying permanently? Even in a debug build, > the ratio of cycles

Re: pgsql: Add assert checking to pg_leftmost_one_pos32() and friends

2023-02-20 Thread Tom Lane
John Naylor writes: > Add assert checking to pg_leftmost_one_pos32() and friends I can see that this was worth writing for testing purposes, but is it really worth carrying permanently? Even in a debug build, the ratio of cycles expended to chances of finding a problem seems mighty poor, and

pgsql: Add assert checking to pg_leftmost_one_pos32() and friends

2023-02-19 Thread John Naylor
Add assert checking to pg_leftmost_one_pos32() and friends Discussion: https://www.postgresql.org/message-id/CAFBsxsEPc%2BFnX_0vmmQ5DHv60sk4rL_RZJ%2BMD6ei%3D76L0kFMvA%40mail.gmail.com Branch -- master Details ---