On Wed, Jun 26, 2019 at 03:07:33PM -0400, Stephen Frost wrote:
> Yes, thanks, and specifically this:
>
> https://www.postgresql.org/message-id/20181130163728.GE3415%40tamriel.snowman.net
>
> Adding 'DROP IF EXISTS' to the top to have things cleaned up so that the
> run can be repeated is fine.
Greetings,
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> On 2019-Jun-26, Stephen Frost wrote:
>
> > Isn’t this the one run from pg_upgrade’s tests? We don’t want to break that
> > (and hopefully we haven’t but maybe something did...). Pretty sure we had
> > nearly the same discussion
On 2019-Jun-26, Stephen Frost wrote:
> Isn’t this the one run from pg_upgrade’s tests? We don’t want to break that
> (and hopefully we haven’t but maybe something did...). Pretty sure we had
> nearly the same discussion this past fall...
https://postgr.es/m/20180904203012.gg20...@paquier.xyz ?
Greetings,
On Wed, Jun 26, 2019 at 10:51 Tom Lane wrote:
> I wrote:
> > Michael Paquier writes:
> >> If we are on that, we still have src/test/modules/test_pg_dump/ which
> >> is not repeatable with multiple installchecks:
> >>
>
I wrote:
> Michael Paquier writes:
>> If we are on that, we still have src/test/modules/test_pg_dump/ which
>> is not repeatable with multiple installchecks:
>> https://www.postgresql.org/message-id/20181130163728.ge3...@tamriel.snowman.net
> OK, hadn't run into that personally, but let's fix
Michael Paquier writes:
> On Mon, Jun 24, 2019 at 04:37:13PM +, Tom Lane wrote:
>> Commit d7f8d26d9 added a test case that created a user, but forgot
>> to drop it again. This is no good; for one thing, it causes repeated
>> "make installcheck" runs to fail.
> If we are on that, we still
On Mon, Jun 24, 2019 at 04:37:13PM +, Tom Lane wrote:
> Drop test user when done with it.
>
> Commit d7f8d26d9 added a test case that created a user, but forgot
> to drop it again. This is no good; for one thing, it causes repeated
> "make installcheck" runs to fail.
If we are on that, we
On Mon, 24 Jun 2019 at 17:37, Tom Lane wrote:
>
> Drop test user when done with it.
>
> Commit d7f8d26d9 added a test case that created a user, but forgot
> to drop it again. This is no good; for one thing, it causes repeated
> "make installcheck" runs to fail.
>
Ah, I see .. yes, my bad.
Drop test user when done with it.
Commit d7f8d26d9 added a test case that created a user, but forgot
to drop it again. This is no good; for one thing, it causes repeated
"make installcheck" runs to fail.
Branch
--
master
Details
---
