Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-25 Thread Heikki Linnakangas
On 24/04/2024 15:57, Peter Eisentraut wrote: On 08.04.24 03:25, Heikki Linnakangas wrote: Refactor libpq state machine for negotiating encryption This fixes the few corner cases noted in commit 705843d294, as shown by the changes in the test. Either this or something nearby appears to have

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-24 Thread Peter Eisentraut
On 08.04.24 03:25, Heikki Linnakangas wrote: Refactor libpq state machine for negotiating encryption This fixes the few corner cases noted in commit 705843d294, as shown by the changes in the test. Either this or something nearby appears to have broken the error reporting from psql or libpq

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-12 Thread Heikki Linnakangas
On 11/04/2024 20:07, Heikki Linnakangas wrote: On 11/04/2024 02:33, Thomas Munro wrote: On Thu, Apr 11, 2024 at 11:25 AM Tom Lane wrote: Thomas Munro writes: If -Dssl=none and -Dgssapi=disabled, compilation of fe-connect.c fails: call to undeclared function 'encryption_negotiation_failed'.

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-11 Thread Heikki Linnakangas
Thanks for the report! On 11/04/2024 02:33, Thomas Munro wrote: On Thu, Apr 11, 2024 at 11:25 AM Tom Lane wrote: Thomas Munro writes: If -Dssl=none and -Dgssapi=disabled, compilation of fe-connect.c fails: call to undeclared function 'encryption_negotiation_failed'. I didn't look too hard,

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-10 Thread Thomas Munro
On Thu, Apr 11, 2024 at 11:25 AM Tom Lane wrote: > Thomas Munro writes: > > If -Dssl=none and -Dgssapi=disabled, compilation of fe-connect.c > > fails: call to undeclared function 'encryption_negotiation_failed'. I > > didn't look too hard, but maybe ENABLE_GSS and USE_GSS are confused? > > For

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-10 Thread Tom Lane
Thomas Munro writes: > If -Dssl=none and -Dgssapi=disabled, compilation of fe-connect.c > fails: call to undeclared function 'encryption_negotiation_failed'. I > didn't look too hard, but maybe ENABLE_GSS and USE_GSS are confused? For me, configure --with-gssapi fails like that, but the other

Re: pgsql: Refactor libpq state machine for negotiating encryption

2024-04-10 Thread Thomas Munro
On Mon, Apr 8, 2024 at 1:25 PM Heikki Linnakangas wrote: > Refactor libpq state machine for negotiating encryption > > This fixes the few corner cases noted in commit 705843d294, as shown > by the changes in the test. > > Author: Heikki Linnakangas, Matthias van de Meent > Reviewed-by: Jacob

pgsql: Refactor libpq state machine for negotiating encryption

2024-04-07 Thread Heikki Linnakangas
Refactor libpq state machine for negotiating encryption This fixes the few corner cases noted in commit 705843d294, as shown by the changes in the test. Author: Heikki Linnakangas, Matthias van de Meent Reviewed-by: Jacob Champion Branch -- master Details ---