pgsql: Remove HP-UX port.

2022-07-07 Thread Thomas Munro
Remove HP-UX port. HP-UX hardware is no longer produced, build farm coverage recently ended, and there are no known active maintainers targeting this OS. Since there is a major rewrite of the build system in the pipeline for PostgreSQL 16, and that requires development, testing and maintainance

pgsql: Remove HP/Intel Itanium support.

2022-07-07 Thread Thomas Munro
Remove HP/Intel Itanium support. This CPU architecture has been discontinued. We already removed HP-UX support, we never supported Windows/Itanium, and the open source operating systems that a vintage hardware owner might hope to run have all either ended Itanium support or never fully released

pgsql: Only allow returning string types or bytea from json_serialize

2022-07-07 Thread Andrew Dunstan
Only allow returning string types or bytea from json_serialize These are documented to be the allowed types for the RETURNING clause, but the restriction was not being enforced, which caused a segfault if another type was specified. Add some testing for this. Per report from a.kozhemyakin

pgsql: Only allow returning string types or bytea from json_serialize

2022-07-07 Thread Andrew Dunstan
Only allow returning string types or bytea from json_serialize These are documented to be the allowed types for the RETURNING clause, but the restriction was not being enforced, which caused a segfault if another type was specified. Add some testing for this. Per report from a.kozhemyakin

pgsql: Remove stray references to lefttree/righttree in the executor.

2022-07-07 Thread Tom Lane
Remove stray references to lefttree/righttree in the executor. The general convention in the executor is to refer to child plans and planstates via the outerPlan[State] and innerPlan[State] macros, but a few places didn't do it like that. For consistency and readability, convert all the

pgsql: Add checkpoint and REDO LSN to log_checkpoints message.

2022-07-07 Thread Fujii Masao
Add checkpoint and REDO LSN to log_checkpoints message. It is useful for debugging purposes to report the checkpoint LSN and REDO LSN in log_checkpoints message. It can give more context while analyzing checkpoint-related issues. pg_controldata reports the last checkpoint LSN and REDO LSN, but

pgsql: Fix alias matching in transformLockingClause().

2022-07-07 Thread Dean Rasheed
Fix alias matching in transformLockingClause(). When locking a specific named relation for a FOR [KEY] UPDATE/SHARE clause, transformLockingClause() finds the relation to lock by scanning the rangetable for an RTE with a matching eref->aliasname. However, it failed to account for the visibility

pgsql: Fix alias matching in transformLockingClause().

2022-07-07 Thread Dean Rasheed
Fix alias matching in transformLockingClause(). When locking a specific named relation for a FOR [KEY] UPDATE/SHARE clause, transformLockingClause() finds the relation to lock by scanning the rangetable for an RTE with a matching eref->aliasname. However, it failed to account for the visibility

pgsql: Fix alias matching in transformLockingClause().

2022-07-07 Thread Dean Rasheed
Fix alias matching in transformLockingClause(). When locking a specific named relation for a FOR [KEY] UPDATE/SHARE clause, transformLockingClause() finds the relation to lock by scanning the rangetable for an RTE with a matching eref->aliasname. However, it failed to account for the visibility

pgsql: Fix alias matching in transformLockingClause().

2022-07-07 Thread Dean Rasheed
Fix alias matching in transformLockingClause(). When locking a specific named relation for a FOR [KEY] UPDATE/SHARE clause, transformLockingClause() finds the relation to lock by scanning the rangetable for an RTE with a matching eref->aliasname. However, it failed to account for the visibility

pgsql: Fix alias matching in transformLockingClause().

2022-07-07 Thread Dean Rasheed
Fix alias matching in transformLockingClause(). When locking a specific named relation for a FOR [KEY] UPDATE/SHARE clause, transformLockingClause() finds the relation to lock by scanning the rangetable for an RTE with a matching eref->aliasname. However, it failed to account for the visibility

pgsql: Fix alias matching in transformLockingClause().

2022-07-07 Thread Dean Rasheed
Fix alias matching in transformLockingClause(). When locking a specific named relation for a FOR [KEY] UPDATE/SHARE clause, transformLockingClause() finds the relation to lock by scanning the rangetable for an RTE with a matching eref->aliasname. However, it failed to account for the visibility

pgsql: Fix alias matching in transformLockingClause().

2022-07-07 Thread Dean Rasheed
Fix alias matching in transformLockingClause(). When locking a specific named relation for a FOR [KEY] UPDATE/SHARE clause, transformLockingClause() finds the relation to lock by scanning the rangetable for an RTE with a matching eref->aliasname. However, it failed to account for the visibility

pgsql: postgres_fdw: Fix grammar.

2022-07-07 Thread Etsuro Fujita
postgres_fdw: Fix grammar. Oversight in commit 4036bcbbb; back-patch to v15 where that appeared. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/54bc816810bca2041bee4997efbe67e63d927bcc Modified Files -- contrib/postgres_fdw/connection.c | 2 +-

pgsql: postgres_fdw: Fix grammar.

2022-07-07 Thread Etsuro Fujita
postgres_fdw: Fix grammar. Oversight in commit 4036bcbbb; back-patch to v15 where that appeared. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/82699edbfe75534b3b6f6f4321339a432b7b8ff2 Modified Files -- contrib/postgres_fdw/connection.c | 2 +- 1 file

pgsql: Convert macros to static inline functions (block.h)

2022-07-07 Thread Peter Eisentraut
Convert macros to static inline functions (block.h) Remove BlockIdIsValid(), which wasn't used and is unnecessary. Remove BlockIdCopy(), which wasn't used and can be done by struct assignment. (BlockIdEquals() also isn't used, but seems reasonable to keep around.) Reviewed-by: Amul Sul