pgsql: Transform proconfig for faster execution.

2023-08-10 Thread Jeff Davis
Transform proconfig for faster execution. Store function config settings in lists to avoid the need to parse and allocate for each function execution. Speedup is modest but significant. Additionally, this change also seems cleaner and supports some other performance improvements under

pgsql: Remove test from commit fa2e874946.

2023-08-10 Thread Jeff Davis
Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us Backpatch-through: 11 Branch

pgsql: Remove test from commit fa2e874946.

2023-08-10 Thread Jeff Davis
Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us Backpatch-through: 11 Branch

pgsql: Remove test from commit fa2e874946.

2023-08-10 Thread Jeff Davis
Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us Backpatch-through: 11 Branch

pgsql: Remove test from commit fa2e874946.

2023-08-10 Thread Jeff Davis
Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us Backpatch-through: 11 Branch

pgsql: Remove test from commit fa2e874946.

2023-08-10 Thread Jeff Davis
Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us Backpatch-through: 11 Branch

pgsql: Remove test from commit fa2e874946.

2023-08-10 Thread Jeff Davis
Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us Backpatch-through: 11 Branch

pgsql: Remove test from commit fa2e874946.

2023-08-10 Thread Jeff Davis
Remove test from commit fa2e874946. The fix itself is fine, but the test revealed other problems related to parallel query that are not easily fixable. Remove the test for now to fix the buildfarm. Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us Backpatch-through: 11 Branch

pgsql: Last-minute updates for release notes.

2023-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2023-39417, CVE-2023-39418 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5d81700859adc9462b9663789f4491611c3d11b8 Modified Files -- doc/src/sgml/release-13.sgml | 31

pgsql: Last-minute updates for release notes.

2023-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2023-39417, CVE-2023-39418 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/023fa8f326dad5e0f841fcc4247b449881215cb7 Modified Files -- doc/src/sgml/release-11.sgml | 31

pgsql: Last-minute updates for release notes.

2023-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2023-39417, CVE-2023-39418 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/93eb661713338b2b51f36ec397e42397b5e441e2 Modified Files -- doc/src/sgml/release-14.sgml | 52

pgsql: Last-minute updates for release notes.

2023-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2023-39417, CVE-2023-39418 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/948757fe493c1031d43bb082b6466db9a08f34a3 Modified Files -- doc/src/sgml/release-15.sgml | 89

pgsql: Reject substituting extension schemas or owners matching ["$'\].

2023-08-10 Thread Noah Misch
Reject substituting extension schemas or owners matching ["$'\]. Substituting such values in extension scripts facilitated SQL injection when @extowner@, @extschema@, or @extschema:...@ appeared inside a quoting construct (dollar quoting, '', or ""). No bundled extension was vulnerable.

pgsql: Last-minute updates for release notes.

2023-08-10 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2023-39417, CVE-2023-39418 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c79434d7fcabdf2a5b27b235c0fb85912e686087 Modified Files -- doc/src/sgml/release-12.sgml | 31

pgsql: Reject substituting extension schemas or owners matching ["$'\].

2023-08-10 Thread Noah Misch
Reject substituting extension schemas or owners matching ["$'\]. Substituting such values in extension scripts facilitated SQL injection when @extowner@, @extschema@, or @extschema:...@ appeared inside a quoting construct (dollar quoting, '', or ""). No bundled extension was vulnerable.

pgsql: Reject substituting extension schemas or owners matching ["$'\].

2023-08-10 Thread Noah Misch
Reject substituting extension schemas or owners matching ["$'\]. Substituting such values in extension scripts facilitated SQL injection when @extowner@, @extschema@, or @extschema:...@ appeared inside a quoting construct (dollar quoting, '', or ""). No bundled extension was vulnerable.

pgsql: Reject substituting extension schemas or owners matching ["$'\].

2023-08-10 Thread Noah Misch
Reject substituting extension schemas or owners matching ["$'\]. Substituting such values in extension scripts facilitated SQL injection when @extowner@, @extschema@, or @extschema:...@ appeared inside a quoting construct (dollar quoting, '', or ""). No bundled extension was vulnerable.

pgsql: Reject substituting extension schemas or owners matching ["$'\].

2023-08-10 Thread Noah Misch
Reject substituting extension schemas or owners matching ["$'\]. Substituting such values in extension scripts facilitated SQL injection when @extowner@, @extschema@, or @extschema:...@ appeared inside a quoting construct (dollar quoting, '', or ""). No bundled extension was vulnerable.

pgsql: Reject substituting extension schemas or owners matching ["$'\].

2023-08-10 Thread Noah Misch
Reject substituting extension schemas or owners matching ["$'\]. Substituting such values in extension scripts facilitated SQL injection when @extowner@, @extschema@, or @extschema:...@ appeared inside a quoting construct (dollar quoting, '', or ""). No bundled extension was vulnerable.

pgsql: Fix RLS policy usage in MERGE.

2023-08-10 Thread Dean Rasheed
Fix RLS policy usage in MERGE. If MERGE executes an UPDATE action on a table with row-level security, the code incorrectly applied the WITH CHECK clauses from the target table's INSERT policies to new rows, instead of the clauses from the table's UPDATE policies. In addition, it failed to check

pgsql: Reject substituting extension schemas or owners matching ["$'\].

2023-08-10 Thread Noah Misch
Reject substituting extension schemas or owners matching ["$'\]. Substituting such values in extension scripts facilitated SQL injection when @extowner@, @extschema@, or @extschema:...@ appeared inside a quoting construct (dollar quoting, '', or ""). No bundled extension was vulnerable.

pgsql: Fix RLS policy usage in MERGE.

2023-08-10 Thread Dean Rasheed
Fix RLS policy usage in MERGE. If MERGE executes an UPDATE action on a table with row-level security, the code incorrectly applied the WITH CHECK clauses from the target table's INSERT policies to new rows, instead of the clauses from the table's UPDATE policies. In addition, it failed to check

pgsql: Fix RLS policy usage in MERGE.

2023-08-10 Thread Dean Rasheed
Fix RLS policy usage in MERGE. If MERGE executes an UPDATE action on a table with row-level security, the code incorrectly applied the WITH CHECK clauses from the target table's INSERT policies to new rows, instead of the clauses from the table's UPDATE policies. In addition, it failed to check

pgsql: Fix erroneous -Werror=missing-braces on old GCC

2023-08-10 Thread Peter Eisentraut
Fix erroneous -Werror=missing-braces on old GCC The buildfarm reports that this is an error on gcc (Debian 4.7.2-5) 4.7.2, 32-bit. The bug seems to be GCC bug 53119, which has obviously been fixed for years. Author: Tristan Partin Discussion:

pgsql: Update Solution.pm for new LoongArch CRC symbol

2023-08-10 Thread John Naylor
Update Solution.pm for new LoongArch CRC symbol Oversight in 4d14ccd6a, per report from Amit Kapila and Michael Paquier. Discussion: https://postgr.es/m/CAA4eK1LsV3KuyUt8tzZDjPcUds1XfVVeW3Wpeju_59DtRV0%3DxQ%40mail.gmail.com Branch -- master Details ---

Re: pgsql: Recalculate search_path after ALTER ROLE.

2023-08-10 Thread Tom Lane
Jeff Davis writes: > On Wed, 2023-08-09 at 16:12 -0700, Jeff Davis wrote: >> I'm not sure yet, but this looks like a possible pre-existing bug, or >> some incorrect assumption I made in fa2e874946. > Before my commit the behavior is the same. Here's a minimal repro > ... > Given that it works

pgsql: Document RelationGetIndexAttrBitmap better

2023-08-10 Thread Alvaro Herrera
Document RelationGetIndexAttrBitmap better Commit 19d8e2308bc5 changed the list of set-of-columns that can be returned by RelationGetIndexAttrBitmap, but didn't update its "documentation". That was pretty hard to read already, so rewrite to make it more comprehensible, adding the missing values

pgsql: Document RelationGetIndexAttrBitmap better

2023-08-10 Thread Alvaro Herrera
Document RelationGetIndexAttrBitmap better Commit 19d8e2308bc5 changed the list of set-of-columns that can be returned by RelationGetIndexAttrBitmap, but didn't update its "documentation". That was pretty hard to read already, so rewrite to make it more comprehensible, adding the missing values

Re: pgsql: Recalculate search_path after ALTER ROLE.

2023-08-10 Thread Jeff Davis
On Wed, 2023-08-09 at 16:12 -0700, Jeff Davis wrote: > I'm not sure yet, but this looks like a possible pre-existing bug, or > some incorrect assumption I made in fa2e874946. Before my commit the behavior is the same. Here's a minimal repro (debug_parallel_query set to 'on' or 'regress'): s1: