pgsql: Doc: document cases where queryid is stable

2024-04-19 Thread David Rowley
Doc: document cases where queryid is stable The documents were clear that queryid should not be assumed to be stable between major versions but said nothing about minor versions and left the reader to guess if that was implied by the mention of the instability of queryid between major versions.

pgsql: Doc: document cases where queryid is stable

2024-04-19 Thread David Rowley
Doc: document cases where queryid is stable The documents were clear that queryid should not be assumed to be stable between major versions but said nothing about minor versions and left the reader to guess if that was implied by the mention of the instability of queryid between major versions.

pgsql: Doc: document cases where queryid is stable

2024-04-19 Thread David Rowley
Doc: document cases where queryid is stable The documents were clear that queryid should not be assumed to be stable between major versions but said nothing about minor versions and left the reader to guess if that was implied by the mention of the instability of queryid between major versions.

pgsql: Doc: document cases where queryid is stable

2024-04-19 Thread David Rowley
Doc: document cases where queryid is stable The documents were clear that queryid should not be assumed to be stable between major versions but said nothing about minor versions and left the reader to guess if that was implied by the mention of the instability of queryid between major versions.

pgsql: Doc: document cases where queryid is stable

2024-04-19 Thread David Rowley
Doc: document cases where queryid is stable The documents were clear that queryid should not be assumed to be stable between major versions but said nothing about minor versions and left the reader to guess if that was implied by the mention of the instability of queryid between major versions.

pgsql: Doc: document cases where queryid is stable

2024-04-19 Thread David Rowley
Doc: document cases where queryid is stable The documents were clear that queryid should not be assumed to be stable between major versions but said nothing about minor versions and left the reader to guess if that was implied by the mention of the instability of queryid between major versions.

pgsql: Revert recent ill-advised test case changes.

2024-04-19 Thread Robert Haas
Revert recent ill-advised test case changes. Commit 6bf5c42b5546984df29289918f952e6211069c54 cannot work on Windows, because it lacks symlink support. While the bug fix in commit cd64dc42d1e1b03e57e6ba3d316e4f9dec52a78d is correct as far as I know, the test case changes depend on the previous

pgsql: Use tempdir_short instead of tempdir.

2024-04-19 Thread Robert Haas
Use tempdir_short instead of tempdir. After cd64dc42d1e1b03e57e6ba3d316e4f9dec52a78d, a significant percentage of the buildfarm got unhappy, because pg_basebackup chokes if it tries to create a tarfile with symlink more than 99 characters in length. To try to fix that problem, use tempdir_short

pgsql: pg_combinebackup: Fix incorrect tablespace handling.

2024-04-19 Thread Robert Haas
pg_combinebackup: Fix incorrect tablespace handling. The previous coding mangled the pathname calculation for incremental files located in user-defined tablespaces. Enhance the test cases to cover such cases, as I should have done originally. Thanks to Andres Freund for alerting me to the lack

pgsql: Make PostgreSQL::Test::Cluster::init_from_backup handle tablespa

2024-04-19 Thread Robert Haas
Make PostgreSQL::Test::Cluster::init_from_backup handle tablespaces. This commit doesn't use this infrastructure for anything new, although it does adapt 010_pg_basebackup.pl to use it. However, a future commit will use this to improve test coverage for pg_combinebackup. Patch by me, reviewed

pgsql: Fix a couple typos in BRIN code

2024-04-19 Thread Tomas Vondra
Fix a couple typos in BRIN code Typos introduced by commits c1ec02be1d79, b43757171470 and dae761a87eda. Author: Alvaro Herrera Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/202401091043.e3nrqiad6gb7@alvherre.pgsql Branch -- master Details ---

pgsql: Add missing index_insert_cleanup calls

2024-04-19 Thread Tomas Vondra
Add missing index_insert_cleanup calls The optimization for inserts into BRIN indexes added by c1ec02be1d79 relies on a cache that needs to be explicitly released after calling index_insert(). The commit however failed to invoke the cleanup in validate_index(), which calls index_insert()

pgsql: Doc: Remove mention of @ and ~ GiST operators

2024-04-19 Thread Daniel Gustafsson
Doc: Remove mention of @ and ~ GiST operators These operators were removed by 2f70fdb0644c in the v14 cycle but they were accidentally left in the table of build-in operator classes. Backpatch down to v14 where the operators where removed. Author: Aleksander Alekseev Reported-by: Colin Caine

pgsql: Doc: Remove mention of @ and ~ GiST operators

2024-04-19 Thread Daniel Gustafsson
Doc: Remove mention of @ and ~ GiST operators These operators were removed by 2f70fdb0644c in the v14 cycle but they were accidentally left in the table of build-in operator classes. Backpatch down to v14 where the operators where removed. Author: Aleksander Alekseev Reported-by: Colin Caine

pgsql: Doc: Remove mention of @ and ~ GiST operators

2024-04-19 Thread Daniel Gustafsson
Doc: Remove mention of @ and ~ GiST operators These operators were removed by 2f70fdb0644c in the v14 cycle but they were accidentally left in the table of build-in operator classes. Backpatch down to v14 where the operators where removed. Author: Aleksander Alekseev Reported-by: Colin Caine

pgsql: Doc: Remove mention of @ and ~ GiST operators

2024-04-19 Thread Daniel Gustafsson
Doc: Remove mention of @ and ~ GiST operators These operators were removed by 2f70fdb0644c in the v14 cycle but they were accidentally left in the table of build-in operator classes. Backpatch down to v14 where the operators where removed. Author: Aleksander Alekseev Reported-by: Colin Caine

pgsql: Better handle indirect constraint drops

2024-04-19 Thread Alvaro Herrera
Better handle indirect constraint drops It is possible for certain cases to remove not-null constraints without maintaining the attnotnull in its correct state; for example if you drop a column that's part of the primary key, and the other columns of the PK don't have not-null constraints, then

pgsql: Use macro NUM_MERGE_MATCH_KINDS instead of '3' in MERGE code.

2024-04-19 Thread Dean Rasheed
Use macro NUM_MERGE_MATCH_KINDS instead of '3' in MERGE code. Code quality improvement for 0294df2f1f84. Aleksander Alekseev, reviewed by Richard Guo. Discussion: https://postgr.es/m/CAJ7c6TMsiaV5urU_Pq6zJ2tXPDwk69-NKVh4AMN5XrRiM7N%2BGA%40mail.gmail.com Branch -- master Details ---

pgsql: Remove unused function prototype

2024-04-19 Thread Daniel Gustafsson
Remove unused function prototype Commit aafc05de1bf5 removed StartSlotSyncWorker() but mistakenly left the prototype in slotsync.h. Fix by removing. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/3f577953-a29e-4722-98ad-2da9eff2c...@yesql.se Branch -- master Details

pgsql: Fix incorrect parameter name in prototype

2024-04-19 Thread Daniel Gustafsson
Fix incorrect parameter name in prototype The function declaration for select_next_encryption_method use the variable name have_valid_connection, so fix the prototype in the header to match that. Reported-by: Alexander Lakhin Discussion: