(I think it would be best to remove the comment altogether and let
> the
> code speak for itself.)
Thank you, committed.
Regards,
Jeff Davis
Remove obsolete comment.
Per suggestion from Peter, the comment was not helpful, so remove it
rather than fixing it.
Reported-by: Peter Eisentraut
Discussion:
https://postgr.es/m/d9421b21-e759-4b74-a039-c487b469c...@eisentraut.org
Branch
--
master
Details
---
On Tue, 2024-04-23 at 11:23 +0200, Peter Eisentraut wrote:
> I think I found a small bug in this commit.
Good catch, thank you.
Committed a fix.
Regards,
Jeff Davis
Fix locale options checking in CREATE DATABASE.
Discussion:
https://postgr.es/m/4ea13583-7305-40b0-8525-58381533e...@eisentraut.org
Reported-by: Peter Eisentraut
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/7562a9bd7100702ce7878a17f4aaac1df08a8e09
Modified
Fix test failures when language environment is not UTF-8.
For tests that depend on UTF-8 encoding, force LC_COLLATE=C and
LC_CTYPE=C to avoid an encoding mismatch.
Reported-by: Thomas Munro
Discussion:
https://postgr.es/m/CA+hUKGK-ZqV1njkG_=xcCqXh2fcMkz85FTMnhS2opm4ZerH=x...@mail.gmail.com
CREATE INDEX: do not update stats during binary upgrade.
During binary upgrade, indexes are created before the data is moved
into place, so it will always be zero.
This is not currently a major problem, but will be when we try to
preserve statistics during upgrade.
Author: Corey Huinker
Add unicode_strtitle() for Unicode Default Case Conversion.
This brings the titlecasing implementation for the builtin provider
out of formatting.c and into unicode_case.c, along with
unicode_strlower() and unicode_strupper(). Accepts an arbitrary word
boundary callback.
Simple for now, but can
Use version for builtin collations.
Given that the version field already exists, there's little reason not
to use it. Suggestion from Peter Eisentraut.
Discussion:
https://postgr.es/m/613c120a-5413-4fa7-a501-6590eae55...@eisentraut.org
Reviewed-by: Peter Eisentraut
Branch
--
master
Run perltidy on generate-unicode_version.pl.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b0be28761ec5958bb7bbf9a03d94ee6e1bc59849
Modified Files
--
src/common/unicode/generate-unicode_version.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Clarify comment for LogicalTapeSetBlocks().
Discussion: https://postgr.es/m/1229327.1711160...@sss.pgh.pa.us
Backpatch-through: 13
Branch
--
REL_13_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/abcea19abf3bd9dfbb4d4b9571ee7a522eb52893
Modified Files
--
Clarify comment for LogicalTapeSetBlocks().
Discussion: https://postgr.es/m/1229327.1711160...@sss.pgh.pa.us
Backpatch-through: 13
Branch
--
REL_14_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/24d1b9989134e96f643ba31cd0e379fce5062534
Modified Files
--
Clarify comment for LogicalTapeSetBlocks().
Discussion: https://postgr.es/m/1229327.1711160...@sss.pgh.pa.us
Backpatch-through: 13
Branch
--
REL_15_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/b74e4a08b9835e18a14fd3f23e19ddd460ed5b88
Modified Files
--
Clarify comment for LogicalTapeSetBlocks().
Discussion: https://postgr.es/m/1229327.1711160...@sss.pgh.pa.us
Backpatch-through: 13
Branch
--
REL_16_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/022068ea2c60fd0b1ec9b9be5d1cc680b640335c
Modified Files
--
Clarify comment for LogicalTapeSetBlocks().
Discussion: https://postgr.es/m/1229327.1711160...@sss.pgh.pa.us
Backpatch-through: 13
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/bc5fcaa289a92941a1c7b191c7c9311bd742e172
Modified Files
--
Fix convert_case(), introduced in 5c40364dd6.
Check source length before checking for NUL terminator to avoid
reading one byte past the string end. Also fix unreachable bug when
caller does not expect NUL-terminated result.
Add unit test coverage of convert_case() in case_test.c, which makes
it
Remove incorrect Assert introduced in c8aeaf3ab.
Already removed incidentally in version 15 (c4649cce3), so this commit
is only applied to versions 13 and 14.
The comment above is misleading in all versions 13 and later, so that
will be fixed in a separate commit.
Discussion:
Remove incorrect Assert introduced in c8aeaf3ab.
Already removed incidentally in version 15 (c4649cce3), so this commit
is only applied to versions 13 and 14.
The comment above is misleading in all versions 13 and later, so that
will be fixed in a separate commit.
Discussion:
Inline basic UTF-8 functions.
Shows a measurable speedup when processing UTF-8 data, such as with
the new builtin collation provider.
Discussion:
https://postgr.es/m/163f4e2190cdf67f67016044e503c5004547e5a9.ca...@j-davis.com
Reviewed-by: Peter Eisentraut
Branch
--
master
Details
---
Support C.UTF-8 locale in the new builtin collation provider.
The builtin C.UTF-8 locale has similar semantics to the libc locale of
the same name. That is, code point sort order (fast, memcmp-based)
combined with Unicode semantics for character operations such as
pattern matching, regular
Fix documentation oversights from 2d819a08a1.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/bb5604ba9e53e3a0fb9967f960e36cff4d36b0ab
Modified Files
--
doc/src/sgml/ref/create_database.sgml | 3 ++-
doc/src/sgml/ref/createdb.sgml| 10 ++
Update src/common/unicode/README.
Change the test description to include the case mapping
test. Oversight in 5c40364dd6.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/f9f3fb1cb71a6cf28283a8cc3185599ec0ce94d3
Modified Files
--
Fix another warning, introduced by 846311051e.
Discussion: https://postgr.es/m/3703896.1710799...@sss.pgh.pa.us
Reported-by: Tom Lane
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/60769c62dc85680ee357aec92461fe97c715aebb
Modified Files
--
Address more review comments on commit 2d819a08a1.
Based on comments from Peter Eisentraut.
* Document CREATE DATABASE ... BUILTIN_LOCALE.
* Determine required encoding based on locale name for CREATE
COLLATION. Use -1 for "C" (requires catversion bump).
* initdb output fixups.
* Make
Fix unreachable code warning from commit 2d819a08a1.
Found by Coverity.
Discussion: https://postgr.es/m/3422201.1710711...@sss.pgh.pa.us
Reported-by: Tom Lane
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/61f352ece9e7eb89c7154da178d0c3bc69fc72c9
Modified Files
Introduce "builtin" collation provider.
New provider for collations, like "libc" or "icu", but without any
external dependency.
Initially, the only locale supported by the builtin provider is "C",
which is identical to the libc provider's "C" locale. The libc
provider's "C" locale has always
Fix version check in 002_pg_upgrade.pl.
Commit f696c0cd5f tried to account for the version in a way that
includes development versions, but it was broken. Fix with suggestion
from Tom Lane.
Discussion: https://postgr.es/m/1553991.1710191...@sss.pgh.pa.us
Reported-by: Tom Lane
Branch
--
arder.
I found a few cases -- attached a patch. Something is better than
nothing. I'm not sure that I got the /.*/ cases right, but they don't
seem to be expecting any output, so /.*/ seemed like the right pattern.
Regards,
Jeff Davis
From be5aa677e37180a8c1b0faebcceab5506b1c8130 Mon Sep 17 00:
On Mon, 2024-03-11 at 17:08 -0400, Tom Lane wrote:
> Jeff Davis writes:
>
> was perfectly correct as it stood, because pg_version is a
> PostgreSQL::Version object. Why did you feel a need to
> editorialize on that?
The goal was to do a version check for 17 that's inclusive
onfused on a couple of points here, such as: why does my
example work fine on newer versions of perl?
But I agree: if the empty pattern is magical, we should get rid of it,
even if we don't understand the exact conditions under which it behaves
magically.
Reagrds,
Jeff Davis
Fix 002_pg_upgrade.pl.
Commit f696c0cd5f caused a test failure in 002_pg_upgrade.pl, because
an earlier s/// operator caused qr// to no longer match the empty
string. Use qr/^$/ instead, which is a better test anyway, because we
expect the stderr to be empty.
Initially this appeared to be a perl
are likely to copy it and they
will be safe as well.
Though I'm still not sure what's going on with longfin.
Thoughts?
Regards,
Jeff Davis
On Sat, 2024-03-09 at 22:50 +, Jeff Davis wrote:
> Catalog changes preparing for builtin collation provider.
This is causing problems on a couple buildfarm members (mantid,
lapwing, snakefly) that all look like this:
# Running: pg_upgrade --no-sync -d
/home/postgres/buildroot/H
Catalog changes preparing for builtin collation provider.
Rename pg_collation.colliculocale to colllocale, and
pg_database.daticulocale to datlocale. These names reflects that the
fields will be useful for the upcoming builtin provider as well, not
just for ICU.
This is purely a rename; no
etter to fix that now. Please push your fix and
> then I'll clean up the unnecessary DROPs.
Thank you for looking. Pushed, and separately ran perltidy.
Regards,
Jeff Davis
Run perltidy on 002_pg_upgrade.pl.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b0289574bdf1202248201a3143d1459bdf5727fd
Modified Files
--
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Fix cross-version pg_upgrade test.
Pass each statement as a separate '-c' arg, so they don't get combined
into a single transaction.
Discussion:
https://postgr.es/m/bca97aecb50b2026b7dbc26604bf31861c819a64.ca...@j-davis.com
Reviewed-by: Tom Lane
Branch
--
master
Details
---
saction block, which
doesn't work for DROP DATABASE.
I'm not sure how this test is succeeding for others, so perhaps I'm
doing something wrong?
Patch attached, though I'm not particularly great with perl and the
array flattening in my implementation might be too magical.
Regards,
Jef
On Fri, 2024-03-08 at 10:24 +0200, Heikki Linnakangas wrote:
> On 07/03/2024 21:18, Jeff Davis wrote:
> > Unicode case mapping tables and functions.
>
> With -Wtype-limits, I'm seeing this warning:
Thank you, fixed. Somehow I lost that flag from my script.
Can you please add s
Fix type signedness error in commit 5c40364dd6.
Use ssize_t instead of size_t.
Discussion: https://postgr.es/m/b20d6d97-7338-48ea-ba33-837a1c8ef...@iki.fi
Reported-by: Heikki Linnakangas
Branch
--
master
Details
---
Unicode case mapping tables and functions.
Implements Unicode simple case mapping, in which all code points map
to exactly one other code point unconditionally.
These tables are generated from UnicodeData.txt, which is already
being used by other infrastructure in src/common/unicode. The tables
Add Unicode property tables.
Provide functions to test for Unicode properties, such as Alphabetic
or Cased. These functions use tables derived from Unicode data files,
similar to the tables for Unicode normalization or general category,
and those tables can be updated with the 'update-unicode'
Run pgindent again on the same file.
Apparently, pgindent got confused by the double space. The first time
I ran it, it moved the function name to the next line. The second time
I ran it, it moved the function name back, but without the double
space.
Now the results appear stable.
Branch
--
Run pgindent for commit ef4cfdce0e.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b406af1806e9fc5c090e58282c7d98f22a4b397f
Modified Files
--
src/backend/utils/activity/backend_status.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
docs: Update HOT update docs for 19d8e2308b
Commit 19d8e2308b changed when the HOT update optimization is possible
but neglected to update the Heap-Only Tuples (HOT) documentation. This
patch updates that documentation accordingly.
Author: Elizabeth Christensen
Backpatch-through: 16
docs: Update HOT update docs for 19d8e2308b
Commit 19d8e2308b changed when the HOT update optimization is possible
but neglected to update the Heap-Only Tuples (HOT) documentation. This
patch updates that documentation accordingly.
Author: Elizabeth Christensen
Backpatch-through: 16
Update sepgsql expected output.
Fix for buildfarm member rhinoceros after commit 2af07e2f74.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/c7ea3f42291bf5c74be8f957c775c5e7b3f78592
Modified Files
--
contrib/sepgsql/expected/ddl.out | 37
Fix buildfarm failures from 2af07e2f74.
Use GUC_ACTION_SAVE rather than GUC_ACTION_SET, necessary for working
with parallel query.
Now that the call requires more arguments, wrap the call in a new
function to avoid code duplication and offer a place for a comment.
Discussion:
On Mon, 2024-03-04 at 21:15 -0500, Tom Lane wrote:
> Jeff Davis writes:
> > Fix search_path to a safe value during maintenance operations.
>
> The buildfarm seems pretty unhappy with this.
Looks like I need to use GUC_ACTION_SAVE. I will remedy it shortly.
Regards,
Jeff Davis
Fix search_path to a safe value during maintenance operations.
While executing maintenance operations (ANALYZE, CLUSTER, REFRESH
MATERIALIZED VIEW, REINDEX, or VACUUM), set search_path to
'pg_catalog, pg_temp' to prevent inconsistent behavior.
Functions that are used for functional indexes, in
Documentation update for Standard Collations.
Correct out-of-date text that said the "default" collation is always
based on LC_COLLATE and LC_CTYPE.
Also reformat into a list to make it easier to understand and compare
the available collations, and briefly document the stability
characteristics
Pass correct count to WALRead().
Previously, some callers requested XLOG_BLCKSZ bytes
unconditionally. While this did not cause a problem, because the extra
bytes are ignored, it's confusing and makes it harder to add safety
checks. Additionally, the comment about zero padding was incorrect.
Add assert to WALReadFromBuffers().
Per suggestion from Andres.
Discussion:
https://postgr.es/m/20240214025508.6mcblauossthv...@awork3.anarazel.de
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/9ecbf54075a91ed155cc779fcc1870de0fff5fef
Modified Files
Read WAL directly from WAL buffers.
If available, read directly from WAL buffers, avoiding the need to go
through the filesystem. Only for physical replication for now, but can
be expanded to other callers.
In preparation for replicating unflushed WAL data.
Author: Bharath Rupireddy
Discussion:
Fix buildfarm error from commit 5c31669058.
Skip test when not using unix domain sockets.
Discussion:
https://postgr.es/m/caldanm29-8oozsbwo9h6dn_tb_3ya1qjrjput-khan8ncdj...@mail.gmail.com
Backpatch-through: 16
Branch
--
REL_16_STABLE
Details
---
Fix buildfarm error from commit 5c31669058.
Skip test when not using unix domain sockets.
Discussion:
https://postgr.es/m/caldanm29-8oozsbwo9h6dn_tb_3ya1qjrjput-khan8ncdj...@mail.gmail.com
Backpatch-through: 16
Branch
--
master
Details
---
On Fri, 2024-01-12 at 21:43 +, Jeff Davis wrote:
> Re-validate connection string in libpqrcv_connect().
Looks like the test is causing problems on drogo:
ERROR: could not connect to the publisher: connection to server at
"127.0.0.1", port 54707 failed: FATAL: SSPI authenti
Fix memory leak in connection string validation.
Introduced in commit c3afe8cf5a.
Discussion:
https://postgr.es/m/066a65233d3cb4ea27a9e0778d2f1d0dc764b222.ca...@j-davis.com
Reviewed-by: Nathan Bossart, Tom Lane
Backpatch-through: 16
Branch
--
REL_16_STABLE
Details
---
Fix memory leak in connection string validation.
Introduced in commit c3afe8cf5a.
Discussion:
https://postgr.es/m/066a65233d3cb4ea27a9e0778d2f1d0dc764b222.ca...@j-davis.com
Reviewed-by: Nathan Bossart, Tom Lane
Backpatch-through: 16
Branch
--
master
Details
---
a password from
another source (like a password file or the PGPASSWORD environment
variable), which should not have been allowed.
This commit adds a step to re-validate the connection string before
connecting.
Reported-by: Jeff Davis
Author: Vignesh C
Reviewed-by: Peter Smith, Robert Haas, Amit
a password from
another source (like a password file or the PGPASSWORD environment
variable), which should not have been allowed.
This commit adds a step to re-validate the connection string before
connecting.
Reported-by: Jeff Davis
Author: Vignesh C
Reviewed-by: Peter Smith, Robert Haas, Amit
Cleanup for unicode-update build target and test.
In preparation for adding more Unicode tables.
Discussion:
https://postgr.es/m/63cd8625-68fa-4760-844a-6b7f64333...@ardentperf.com
Reviewed-by: Jeremy Schneider
Branch
--
master
Details
---
On Fri, 2023-12-29 at 17:46 +, Peter Eisentraut wrote:
> Make all Perl warnings fatal
This seems to be causing problems in the buildfarm:
Use of uninitialized value $ENV{"PG_TEST_EXTRA"} in pattern match
(m//) at t/001_mutated_bindpasswd.pl line 23.
Regards,
Jeff Davis
Fix collate.windows.win1252 test.
Do not rely on the OS recognizing a particular locale; find the right
locale by querying the "en_US" collation.
Author: Alexander Lakhin
Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/ae73f6f5-8221-c112-4640-5cda812a6...@gmail.com
Branch
--
Initialize data directories with --lc-messages=C for tests.
Commit db6d9891e8 changed them to be initialized with --no-locale, but
that reduced the test coverage for non-C locales.
Discussion:
https://postgr.es/m/0d47e5ecc037b3908149aad5f2a987793cf938bd.camel%40j-davis.com
Branch
--
master
Use 64-bit atomics for xlblocks array elements.
In preparation for reading the contents of WAL buffers without a
lock. Also, avoids the previously-needed comment in GetXLogBuffer()
explaining why it's safe from torn reads.
Author: Bharath Rupireddy
Discussion:
Additional write barrier in AdvanceXLInsertBuffer().
First, mark the xlblocks member with InvalidXLogRecPtr, then issue a
write barrier, then initialize it. That ensures that the xlblocks
member doesn't appear valid while the contents are being initialized.
In preparation for reading WAL buffer
Cache opaque handle for GUC option to avoid repeasted lookups.
When setting GUCs from proconfig, performance is important, and hash
lookups in the GUC table are significant.
Per suggestion from Robert Haas.
Discussion:
Shrink Unicode category table.
Missing entries can implicitly be considered "unassigned".
Discussion:
https://postgr.es/m/ff4c2f2f9c8fc7ca27c1c24ae37ecaeaeaff6b53.ca...@j-davis.com
Branch
--
master
Details
---
Optimize SearchPathCache by saving the last entry.
Repeated lookups are common, so it's worth it to check the last entry
before doing another hash lookup.
Discussion:
https://postgr.es/m/04c8592dbd694e4114a3ed87139a7a04e4363030.camel%40j-davis.com
Branch
--
master
Details
---
Optimize check_search_path() by using SearchPathCache.
A hash lookup is faster than re-validating the string, particularly
because we use SplitIdentifierString() for validation.
Important when search_path changes frequently.
Discussion:
Be more paranoid about OOM in search_path cache.
Recent commit f26c2368dc introduced a search_path cache, but left some
potential out-of-memory hazards. Simplify the code and make it safer
against OOM.
This change reintroduces one list_copy(), losing a small amount of the
performance gained in
simplehash: preserve consistency in case of OOM.
Compute size first, then allocate, then update the structure.
Previously, an out-of-memory when growing could leave the hashtable in
an inconsistent state.
Discussion:
https://postgr.es/m/20231117201334.eyb542qr5yk4g...@awork3.anarazel.de
Add cache for recomputeNamespacePath().
When search_path is changed to something that was previously set, and
no invalidation happened in between, use the cached list of namespace
OIDs rather than recomputing them. This avoids syscache lookups and
ACL checks.
Important when the search_path
Additional unicode primitive functions.
Introduce unicode_version(), icu_unicode_version(), and
unicode_assigned().
The latter requires introducing a new lookup table for the Unicode
General Category, which is generated along with the other Unicode
lookup tables.
Discussion:
Clarify the result order of unnest(multirange).
It is best not to mention the storage order, because that is
an implementation detail and has confused at least one user,
who assumed that the storage order is the order in which the
constituent ranges were written in SQL.
Since the sorting order
Doc fix: Interfacing Extensions to Indexes
Refer to CREATE ACCESS METHOD rather than suggesting direct changes to
pg_am. Also corrects index-specific language that predated table
access methods.
Discussion:
https://postgr.es/m/20231025172551.685b7799455f9a6addcf5...@sraoss.co.jp
Reported-by:
On Tue, 2023-10-24 at 18:35 -0400, Bruce Momjian wrote:
> I liked this patch and adjusted it; patch attached. I would like to
> apply it to all branches since it provides useful information.
Looks good to me.
Regards,
Jeff Davis
Assert that buffers are marked dirty before XLogRegisterBuffer().
Enforce the rule from transam/README in XLogRegisterBuffer(), and
update callers to follow the rule.
Hash indexes sometimes register clean pages as a part of the locking
protocol, so provide a REGBUF_NO_CHANGE flag to support that
Fix bug in GenericXLogFinish().
Mark the buffers dirty before writing WAL.
Discussion: https://postgr.es/m/25104133-7df8-cae3-b9a2-1c0aaa1c0...@iki.fi
Reviewed-by: Heikki Linnakangas
Backpatch-through: 11
Branch
--
REL_13_STABLE
Details
---
Fix bug in GenericXLogFinish().
Mark the buffers dirty before writing WAL.
Discussion: https://postgr.es/m/25104133-7df8-cae3-b9a2-1c0aaa1c0...@iki.fi
Reviewed-by: Heikki Linnakangas
Backpatch-through: 11
Branch
--
REL_14_STABLE
Details
---
Fix bug in GenericXLogFinish().
Mark the buffers dirty before writing WAL.
Discussion: https://postgr.es/m/25104133-7df8-cae3-b9a2-1c0aaa1c0...@iki.fi
Reviewed-by: Heikki Linnakangas
Backpatch-through: 11
Branch
--
REL_11_STABLE
Details
---
Fix bug in GenericXLogFinish().
Mark the buffers dirty before writing WAL.
Discussion: https://postgr.es/m/25104133-7df8-cae3-b9a2-1c0aaa1c0...@iki.fi
Reviewed-by: Heikki Linnakangas
Backpatch-through: 11
Branch
--
REL_12_STABLE
Details
---
Fix bug in GenericXLogFinish().
Mark the buffers dirty before writing WAL.
Discussion: https://postgr.es/m/25104133-7df8-cae3-b9a2-1c0aaa1c0...@iki.fi
Reviewed-by: Heikki Linnakangas
Backpatch-through: 11
Branch
--
REL_15_STABLE
Details
---
Fix bug in GenericXLogFinish().
Mark the buffers dirty before writing WAL.
Discussion: https://postgr.es/m/25104133-7df8-cae3-b9a2-1c0aaa1c0...@iki.fi
Reviewed-by: Heikki Linnakangas
Backpatch-through: 11
Branch
--
master
Details
---
Fix bug in GenericXLogFinish().
Mark the buffers dirty before writing WAL.
Discussion: https://postgr.es/m/25104133-7df8-cae3-b9a2-1c0aaa1c0...@iki.fi
Reviewed-by: Heikki Linnakangas
Backpatch-through: 11
Branch
--
REL_16_STABLE
Details
---
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Discussion:
https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Discussion:
https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Fix pg_dump assertion failure when dumping pg_catalog.
Commit 396d348b04 did not account for the default collation.
Also, use pg_log_warning() instead of Assert().
Discussion:
https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Transform proconfig for faster execution.
Store function config settings in lists to avoid the need to parse and
allocate for each function execution.
Speedup is modest but significant. Additionally, this change also
seems cleaner and supports some other performance improvements under
Remove test from commit fa2e874946.
The fix itself is fine, but the test revealed other problems related
to parallel query that are not easily fixable. Remove the test for
now to fix the buildfarm.
Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us
Backpatch-through: 11
Branch
Remove test from commit fa2e874946.
The fix itself is fine, but the test revealed other problems related
to parallel query that are not easily fixable. Remove the test for
now to fix the buildfarm.
Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us
Backpatch-through: 11
Branch
Remove test from commit fa2e874946.
The fix itself is fine, but the test revealed other problems related
to parallel query that are not easily fixable. Remove the test for
now to fix the buildfarm.
Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us
Backpatch-through: 11
Branch
Remove test from commit fa2e874946.
The fix itself is fine, but the test revealed other problems related
to parallel query that are not easily fixable. Remove the test for
now to fix the buildfarm.
Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us
Backpatch-through: 11
Branch
Remove test from commit fa2e874946.
The fix itself is fine, but the test revealed other problems related
to parallel query that are not easily fixable. Remove the test for
now to fix the buildfarm.
Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us
Backpatch-through: 11
Branch
Remove test from commit fa2e874946.
The fix itself is fine, but the test revealed other problems related
to parallel query that are not easily fixable. Remove the test for
now to fix the buildfarm.
Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us
Backpatch-through: 11
Branch
Remove test from commit fa2e874946.
The fix itself is fine, but the test revealed other problems related
to parallel query that are not easily fixable. Remove the test for
now to fix the buildfarm.
Discussion: https://postgr.es/m/88825.1691665...@sss.pgh.pa.us
Backpatch-through: 11
Branch
On Wed, 2023-08-09 at 16:12 -0700, Jeff Davis wrote:
> I'm not sure yet, but this looks like a possible pre-existing bug, or
> some incorrect assumption I made in fa2e874946.
Before my commit the behavior is the same. Here's a minimal repro
(debug_parallel_query set to 'on' or 'regress'):
On Wed, 2023-08-09 at 20:31 +, Jeff Davis wrote:
> Recalculate search_path after ALTER ROLE.
Looks like this is causing some buildfarm failures for
debug_parallel_query members related to the combination of parallel
query, search_path, and renaming a role.
I'm not sure yet, but this lo
Recalculate search_path after ALTER ROLE.
Renaming a role can affect the meaning of the special string $user, so
must cause search_path to be recalculated.
Discussion:
https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com
Reviewed-by: Nathan Bossart, Michael Paquier
Recalculate search_path after ALTER ROLE.
Renaming a role can affect the meaning of the special string $user, so
must cause search_path to be recalculated.
Discussion:
https://postgr.es/m/186761d32c0255debbdf50b6310b581b9c973e6c.ca...@j-davis.com
Reviewed-by: Nathan Bossart, Michael Paquier
1 - 100 of 354 matches
Mail list logo
