Small cosmetic fixes in radix tree template
- Bring memory context names in line with other naming
- Fix typos, reported off-list by Alexander Lakhin
- Remove copy-paste errors from comments
- Remove duplicate #undef
Branch
--
master
Details
---
Fix make headerscheck
In the wake of commits dac048f71 and ecaf7c5df, `make headerscheck`
no longer generated all headers that are included by other headers,
causing headerscheck/cpluspluscheck to fail. To fix, backpatch enough
makefile rules from 721856ff2 to generate all required headers.
Get rid of anonymous struct
This is a C11 feature, and we require C99. While at it, go the further
step and get rid of the surrounding union (with uintptr_t) entirely,
as there is currently no use case for this file to access the header of
BlocktableEntry as a uintptr_t, and there are no
On Tue, Apr 9, 2024 at 12:27 AM Andres Freund wrote:
>
> This isn't quite C99 conformant, and thus breaks on the buildfarm animal
> set up to test that:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mylodon=2024-04-08%2012%3A07%3A01
I haven't forgotten about this and will fix within
Teach radix tree to embed values at runtime
Previously, the decision to store values in leaves or within the child
pointer was made at compile time, with variable length values using
leaves by necessity. This commit allows introspecting the length of
variable length values at runtime for that
Teach TID store to skip bitmap for small numbers of offsets
The header portion of BlocktableEntry has enough padding space for
an array of 3 offsets (1 on 32-bit platforms). Use this space instead
of having a sparse bitmap array. This will take up a constant amount
of space no matter what the
Use bump context for TID bitmaps stored by vacuum
Vacuum does not pfree individual entries, and only frees the entire
storage space when finished with it. This allows using a bump context,
eliminating the chunk header in each leaf allocation. Most leaf
allocations will be 16 to 32 bytes, so
Fix alignment of stack variable
Declare with union similar to PGAlignedBlock.
Report and fix by Andres Freund
Discussion:
https://postgr.es/m/20240407190731.izm3mdazednrsiqk%40awork3.anarazel.de
Branch
--
master
Details
---
Teach fasthash_accum to use platform endianness for bytewise loads
This function previously used a mix of word-wise loads and bytewise
loads. The bytewise loads happened to be little-endian regardless of
platform. This in itself is not a problem. However, a future commit
will require the same
Speed up tail processing when hashing aligned C strings, take two
After encountering the NUL terminator, the word-at-a-time loop exits
and we must hash the remaining bytes. Previously we calculated
the terminator's position and re-loaded the remaining bytes from
the input string. This was slower
Add macro to disable address safety instrumentation
fasthash_accum_cstring_aligned() uses a technique, found in various
strlen() implementations, to detect a string's NUL terminator by
reading a word at at time. That triggers failures when testing with
"-fsanitize=address", at least with frontend
Fix incorrect return type
fasthash32() calculates a 32-bit hashcode, but the return
type was uint64. Change to uint32.
Noted by Jeff Davis
Discussion:
https://postgr.es/m/b16c93e6c736a422d4de668343515375664eb05d.camel%40j-davis.com
Branch
--
master
Details
---
Convert uses of hash_string_pointer to fasthash equivalent
Remove duplicate hash_string_pointer() function definitions by creating
a new inline function hash_string() for this purpose.
This has the added advantage of avoiding strlen() calls when doing hash
lookup. It's not clear how many of
Revert "Speed up tail processing when hashing aligned C strings"
This reverts commit 07f0f6abfc7f6c55cede528d9689dedecefc734a.
This has shown failures on both Valgrind and big-endian machines,
per members skink and pike.
Branch
--
master
Details
---
On Sun, Mar 31, 2024 at 12:32 PM John Naylor wrote:
>
> Speed up tail processing when hashing aligned C strings
Skink reports valgrind error with
Conditional jump or move depends on uninitialised value(s)
I'll revert this soon to analyze, but first I'd like to see if any
big-endian a
the dependency chain.
Ants Aasma and John Naylor
Discussion:
https://postgr.es/m/CANwKhkP7pCiW_5fAswLhs71-JKGEz1c1%2BPC0a_w1fwY4iGMqUA%40mail.gmail.com
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/07f0f6abfc7f6c55cede528d9689dedecefc734a
Modified Files
On Tue, Mar 26, 2024 at 9:36 AM Masahiko Sawada wrote:
>
> On Tue, Mar 26, 2024 at 7:16 AM David Rowley wrote:
> >
> > Either "max_bytes" is a bad name for this variable or the * 1024L
> > should be removed.
> >
>
> Right. We discussed it on the original thread too[1]. Since we're
> going to
On Fri, Mar 8, 2024 at 10:43 AM David Rowley wrote:
>
> On Fri, 8 Mar 2024 at 16:37, John Naylor wrote:
> > Thanks, I was getting close to committing a hackish workaround -- this
> > seems better!
>
> ok cool. I also noticed a typo. Maybe worth fixing that at the same t
Revert "Fix link error for test_radixtree module on Windows"
This reverts commit 9552e3ace317ac8bb0a80613c0e5cd6536c96dc8.
I (john) forgot to revert this locally when a more principled
fix was found, which has the same message title.
Branch
--
master
Details
---
Fix link error for test_radixtree module on Windows
Add PGDLLIMPORT to pg_popcount32/64. In passing, fix a typo.
Diagnosis by Masahiko Sawada, patch by David Rowley
Per buildfarm members drongo and fairywren
Discussion:
Fix link error for test_radixtree module on Windows
Add back "link_with" directive, similar to the one removed by 1f1d73a8b,
but only for Windows, but use the "_shlib" variation.
Diagnosis by Masahiko Sawada, proposed fix adjusted and tested by me
Per buildfarm members drongo and fairywren
On Fri, Mar 8, 2024 at 10:29 AM David Rowley wrote:
>
> On Fri, 8 Mar 2024 at 13:48, John Naylor wrote:
> > Now, after I get some coffee I'll look into the Windows failures.
>
> I had a look at this and the attached fixes the broken build on MSVC for me.
>
> I didn'
On Thu, Mar 7, 2024 at 4:47 PM John Naylor wrote:
>
> On Thu, Mar 7, 2024 at 4:36 PM Alvaro Herrera wrote:
> >
> > Well, surely we can email them. Their profiles show they're still
> > active.
> > https://db.in.tum.de/people/sites/kemper/?lang=en
> > https
Blind attempt to fix ODR violations
Remove apparently useless "link_with" directive. Even if this isn't the
root cause, it makes the .build file more like the other test modules.
Reviewed by Masahiko Sawada
Follow-up to ee1b30f12, per buildfarm members olingo and grassquit.
Discussion:
On Thu, Mar 7, 2024 at 4:36 PM Alvaro Herrera wrote:
>
> Well, surely we can email them. Their profiles show they're still
> active.
> https://db.in.tum.de/people/sites/kemper/?lang=en
> https://db.in.tum.de/people/sites/neumann/?lang=en
> https://db.in.tum.de/people/sites/leis/?lang=en
I
Fix incorrect format specifier for int64
Follow-up to ee1b30f12, per buildfarm member mamba.
Discussion:
https://postgr.es/m/CANWCAZYwyRMU%2BOTVOjK%3Dno1hm-W3ZQ5vrSFM1MFAaLtLydvwzA%40mail.gmail.com
Branch
--
master
Details
---
Fix redefinition of typedefs
Per buildfarm members sifaka and longfin, clang with
-Wtypedef-redefinition warns of duplicate typedefs unless building with
C11. Follow-up to ee1b30f12.
Masahiko Sawada
Discussion:
On Thu, Mar 7, 2024 at 1:32 PM Tom Lane wrote:
>
> John Naylor writes:
> > On Thu, Mar 7, 2024 at 1:08 PM Tom Lane wrote:
> >> Hm ... do we know that this is not patent-encumbered technology?
> >> Commits citing such specific prior art make me nervous.
>
On Thu, Mar 7, 2024 at 1:08 PM Tom Lane wrote:
>
> John Naylor writes:
> > This implements a radix tree data structure based on the design in
> > "The Adaptive Radix Tree: ARTful Indexing for Main-Memory Databases"
> > by Viktor Leis, Alfons Kemper, and ThomasNe
the same manner as simplehash.h and sort_template.h.
Future commits will use this infrastructure for storing TIDs.
Patch by Masahiko Sawada and John Naylor, but a substantial amount of
credit is due to Andres Freund, whose proof-of-concept was a valuable
source of coding idioms and awarenes
Fix signedness error in 9f225e992 for gcc
The first argument of vshrq_n_s8 needs to be a signed vector type,
but it was passed unsigned. Clang is more lax with conversion, but
gcc needs a cast.
Fix by me, tested by Masahiko Sawada
Per buildfarm members splitfin, batta, widowbird, snakefly,
Introduce helper SIMD functions for small byte arrays
vector8_min - helper for emulating ">=" semantics
vector8_highbit_mask - used to turn the result of a vector
comparison into a bitmask
Masahiko Sawada
Reviewed by Nathan Bossart, with additional adjustments by me
Discussion:
Move some bitmap logic out of bitmapset.c
Move the logic for selecting appropriate pg_bitutils.h
functions based on word size to bitmapset.h for wider
visibility.
Reviewed (in a previous version) by Tom Lane
Discussion:
Fix warnings in cpluspluscheck
Various int variables were compared to macros that are of type size_t,
which caused -Wsign-compare warnings in cpluspluscheck. Change those
to size_t, which also better describes their purpose.
Per report from Peter Eisentraut
Discussion:
Further cosmetic review of hashfn_unstable.h
In follow-up to e97b672c8,
* Flesh out comments explaining the incremental interface
* Clarify detection of zero bytes when hashing aligned C strings
The latter was suggested and reviewed by Jeff Davis
Discussion:
Simplify initialization of incremental hash state
The standalone functions fasthash{32,64} use length for two purposes:
how many bytes to hash, and how to perturb the internal seed.
Developers using the incremental interface may not know the length
ahead of time (e.g. for C strings). In this
Fixed misspelled byteswap function for big endian machines
Per members lora and mamba
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/dd0a0cfc81fecacf2aed41b9eb138f850e43aab6
Modified Files
--
src/include/common/hashfn_unstable.h | 2 +-
1 file changed,
that
is written in assembly language.
As demonstration, use this in the search path cache. This brings the
general case performance closer to the special case optimization done
in commit a86c61c9ee. There are other places that could benefit, but
that is left for future work.
Jeff Davis and John Naylor
Add inline incremental hash functions for in-memory use
It can be useful for a hash function to expose separate initialization,
accumulation, and finalization steps. In particular, this is useful
for building inline hash functions for simplehash. Instead of trying
to whack around hash_bytes
Update documentation of default fdw_tuple_cost
Follow up to cac169d68
Umair Shahid
Reviewed by Richard Guo and Chris Travers
Discussion:
https://postgr.es/m/CALVUYo9RECc5gwD%2B4SRM5Es%2Bbg9cpNfhd3_qUjf7kVTGyLpFJg%40mail.gmail.com
Branch
--
master
Details
---
Fix typo and case in messages
Follow up to dc2123400
Kyotaro Horiguchi
Discussion:
https://postgr.es/m/20231222.154939.1509525390095583358.horikyota@gmail.com
Discussion:
https://postgr.es/m/20231225.145124.1745560266993421173.horikyota@gmail.com
Branch
--
master
Details
---
Remove redundant setting of hashkey after insertion
It's not necessary to fill the key field in most cases, since
hash_search has already done that. Some existing call sites have an
assert or comment that this contract has been fulfilled, but those
are quite old and that practice seems
there are also now some failures in release
> branches that don't have your commit, so I'd wait long for more
> evidence...
Ah, I did check at least one back branch yesterday and didn't see any
failures then. I see them now, thanks!
(FWIW, I've been looking for signs of memory malfeasance in t
On Thu, Aug 17, 2023 at 11:41 AM John Naylor
wrote:
>
>
> On Wed, Aug 16, 2023 at 5:17 PM John Naylor
wrote:
> >
> > Split out tiebreaker comparisons from comparetup_* functions
>
> Hammerkop is getting OOM errors with this change. Most grand totals in
the memory c
On Wed, Aug 16, 2023 at 5:17 PM John Naylor
wrote:
>
> Split out tiebreaker comparisons from comparetup_* functions
Hammerkop is getting OOM errors with this change. Most grand totals in the
memory context stats show between 1 and 3 MB, and "tuplesort main" only
shows small-
Split out tiebreaker comparisons from comparetup_* functions
Previously, if a specialized comparator found equal datum1 keys,
the "comparetup" function would repeat the comparison on the
datum before proceeding with the unabbreviated first key
and/or additional sort keys.
Move comparing
Update Solution.pm for new LoongArch CRC symbol
Oversight in 4d14ccd6a, per report from Amit Kapila
and Michael Paquier.
Discussion:
https://postgr.es/m/CAA4eK1LsV3KuyUt8tzZDjPcUds1XfVVeW3Wpeju_59DtRV0%3DxQ%40mail.gmail.com
Branch
--
master
Details
---
Use native CRC instructions on 64-bit LoongArch
As with the Intel and Arm CRC instructions, compiler intrinsics for
them must be supported by the compiler. In contrast, no runtime check
is needed. Aligned memory access is faster, so use the Arm coding as
a model.
YANG Xudong
Discussion:
Bring some MSVC asserts in line with other platforms
MSVC's _BitScan* functions return a boolean indicating whether any
bits were set in the input, and we were previously asserting that
they returned true, per our API. This is correct. However, other
platforms simply assert that the input is
doc: Update error messages in RLS examples
Since 8b9e9644d, the messages for failed permissions checks report
"table" where appropriate, rather than "relation".
Backpatch to all supported branches
Branch
--
REL_11_STABLE
Details
---
doc: Update error messages in RLS examples
Since 8b9e9644d, the messages for failed permissions checks report
"table" where appropriate, rather than "relation".
Backpatch to all supported branches
Branch
--
REL_12_STABLE
Details
---
doc: Update error messages in RLS examples
Since 8b9e9644d, the messages for failed permissions checks report
"table" where appropriate, rather than "relation".
Backpatch to all supported branches
Branch
--
REL_13_STABLE
Details
---
doc: Update error messages in RLS examples
Since 8b9e9644d, the messages for failed permissions checks report
"table" where appropriate, rather than "relation".
Backpatch to all supported branches
Branch
--
REL_14_STABLE
Details
---
doc: Update error messages in RLS examples
Since 8b9e9644d, the messages for failed permissions checks report
"table" where appropriate, rather than "relation".
Backpatch to all supported branches
Branch
--
REL_15_STABLE
Details
---
doc: Update error messages in RLS examples
Since 8b9e9644d, the messages for failed permissions checks report
"table" where appropriate, rather than "relation".
Backpatch to all supported branches
Branch
--
master
Details
---
Remove newly added asserts from pg_bitutils.h
These were valuable during development, but are unlikely to tell us
anything going forward. This reverts 204b0cbec and adjusts the content
of 677319746 to more closely match the more-readable original style.
Per review from Tom Lane
Discussion:
On Tue, Feb 21, 2023 at 11:59 AM John Naylor
wrote:
>
> On Mon, Feb 20, 2023 at 10:17 PM Tom Lane wrote:
> >
> > John Naylor writes:
> > > Add assert checking to pg_leftmost_one_pos32() and friends
> >
> > I can see that this was worth writing for testi
On Mon, Feb 20, 2023 at 10:17 PM Tom Lane wrote:
>
> John Naylor writes:
> > Add assert checking to pg_leftmost_one_pos32() and friends
>
> I can see that this was worth writing for testing purposes, but
> is it really worth carrying permanently? Even in a debug build,
Add MSVC support for pg_leftmost_one_pos32() and friends
To allow testing for general support for fast bitscan intrinsics,
add symbols HAVE_BITSCAN_REVERSE and HAVE_BITSCAN_FORWARD.
Also do related cleanup in AllocSetFreeIndex(): Previously, we
tested for HAVE__BUILTIN_CLZ and copied the
Add assert checking to pg_leftmost_one_pos32() and friends
Discussion:
https://www.postgresql.org/message-id/CAFBsxsEPc%2BFnX_0vmmQ5DHv60sk4rL_RZJ%2BMD6ei%3D76L0kFMvA%40mail.gmail.com
Branch
--
master
Details
---
Remove redundant relkind check
Ranier Vilela
Reviewed by Justin Pryzby
Discussion:
https://www.postgresql.org/message-id/CAEudQAp2R2fbbi0OHHhv_n4%3DCh0t1VtjObR9YMqtGKHJ%2BfaUFQ%40mail.gmail.com
Branch
--
master
Details
---
Remove dead code in formatting.c
Remove some code guarded by IS_MINUS() or IS_PLUS(), where the entire
stanza is inside an else-block where both of these are false. This
should slightly improve test coverage.
While at it, remove coding that apparently assumes that unsetting a
bit is so expensive
Remove redundant setting of tuplesort status
Also add an explanatory comment to match other similar coding within
tuplesort_performsort().
Xing Guo
Reviewed by Richard Guo and Cary Huang
Discussion:
Move variable increment to the end of the loop
This is less error prone and matches the placement of other code
in the file.
Justin Pryzby
Reviewed by Tom Lane
Discussion:
https://www.postgresql.org/message-id/20221123172436.gj11...@telsasoft.com
Branch
--
master
Details
---
Remove outdated include
In the wake of bfb9dfd93, there are no longer any stat() calls in
guc-file.l, but the work leading to dac048f71 did not get the memo.
Noted by Michael Paquier
Discussion: https://www.postgresql.org/message-id/Y2OosGi1Xh9x/lEn%40paquier.xyz
Branch
--
master
Details
On Thu, Nov 3, 2022 at 12:39 PM John Naylor
wrote:
>
https://git.postgresql.org/pg/commitdiff/062eef3a9bbd5da9c26c93127ee6272193cb06e6
flaviventris fails on the pg_resetwal test with "initdb: error: invalid
locale settings; check LANG and LC_* environment variables", and
idia
Straighten include order in guc-file.l
Oversight in dac048f71eb
Michael Paquier
Reviewed by Julien Rouhaud
Discussion: https://www.postgresql.org/message-id/Y2IATvRGo347Lvd1%40paquier.xyz
Branch
--
master
Details
---
Remove unnecessary semicolons after goto labels
According to the C standard, a label must followed by a statement.
If there was ever a time we needed an empty statement here, it was
a long time ago.
Japin Li
Reviewed by Julien Rouhaud
Discussion:
Fix typos referring to PGPROC
Japin Li
Reviewed by Kyotaro Horiguchi
Discussion:
https://www.postgresql.org/message-id/meyp282mb1669459813b36fb5eaa38434b6...@meyp282mb1669.ausp282.prod.outlook.com
Branch
--
master
Details
---
Fix grammar in error message
While at it, make ellipses formatting consistent when describing SQL statements.
Ekaterina Kiryanova and Alexander Lakhin
Reviewed by myself and Álvaro Herrera
Discussion:
https://www.postgresql.org/message-id/eed5cec0-a542-53da-6a5e-7789c6ed9817%40postgrespro.ru
Fix grammar in error message
While at it, make ellipses formatting consistent when describing SQL statements.
Ekaterina Kiryanova and Alexander Lakhin
Reviewed by myself and Álvaro Herrera
Discussion:
https://www.postgresql.org/message-id/eed5cec0-a542-53da-6a5e-7789c6ed9817%40postgrespro.ru
Blind attempt to fix LLVM dependency in the backend
Commit ecaf7c5df5 removed gram.h from the backend's generated-headers
target. In LLVM builds, this leads to loss of dependency information
when generating .bc files. To fix, add a rule that mirrors ad-hoc .o
dependencies for .bc files as well.
a blind attempt since it seems sporadic and
doesn't happen to reproduce for me.
--
John Naylor
EDB: http://www.enterprisedb.com
Fix failure to build gramparse.h standalone in vpath builds
Add include directory in a similar fashion as 829906fb6c.
Per buildfarm animal crake
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b0526d271d16d54064666d30bbfa53d4f335c66d
Modified Files
--
On Wed, Sep 14, 2022 at 11:02 AM John Naylor wrote:
>
> Move gramparse.h to src/backend/parser
Member crake doesn't like this. I thought I tried vpath for this
patch, but I'll go confirm now.
--
John Naylor
EDB: http://www.enterprisedb.com
Bump minimum Perl version to 5.14
The oldest vendor-shipped Perl in the buildfarm is 5.14.2, which is
the last version that Debian Wheezy shipped. That OS is EOL, but we
keep it running because there is no other convenient way to test certain
non-mainstream 32-bit platforms. There is no bugfix in
Move gramparse.h to src/backend/parser
This header is semi-private, being used only in files related to
raw parsing, so move to the backend directory where those files
live. This allows removal of Makefile rules that symlink gram.h to
src/include/parser, since gramparse.h can now include gram.h
Adjust header exceptions for 0bd9c6297
Per buildfarm animal crake
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/fcf7b3a9d42c3cf778dab0fc644f11f12684d184
Modified Files
--
src/tools/pginclude/cpluspluscheck | 2 +-
src/tools/pginclude/headerscheck |
fact
> that eval returns the value of the last expression in the string, which
> also gets rid of the ugly quoting and escaping, per the attached.
Hmm, interesting.
--
John Naylor
EDB: http://www.enterprisedb.com
Treat Unicode codepoints of category "Format" as non-spacing
Commit d8594d123 updated the list of non-spacing codepoints used
for calculating display width, but in doing so inadvertently removed
some, since the script used for that commit only considered combining
characters.
For complete
Make eval statement naturally proof against perltidy
This is a bit less verbose than adding an exception. Rewrite
the other eval statement in Catalog.pm as well, just for
the sake of consistency.
Idea from Andrew Dunstan
Discussion:
c respects block boundaries for its directives.
I tried that in the attached -- it looks a bit nicer but requires more
explanation. I don't have strong feelings either way.
--
John Naylor
EDB: http://www.enterprisedb.com
diff --git a/src/backend/catalog/Catalog.pm b/src/backend/catalog/Catalog.pm
i
022-09-08%2015%3A30%3A25
I'm seeing a lot more failures now after the Flex/Bison minimum
version bump, but that's a strange correlation. Maybe the above
failure is intermittent?
--
John Naylor
EDB: http://www.enterprisedb.com
Bump minimum version of Flex to 2.5.35
Since the retirement of some older buildfarm members, the oldest Flex
that gets regular testing is 2.5.35.
Reviewed by Andres Freund
Discussion:
https://www.postgresql.org/message-id/1097762.1662145...@sss.pgh.pa.us
Branch
--
master
Details
---
Bump minimum version of Bison to 2.3
Since the retirement of some older buildfarm members, the oldest Bison
that gets regular testing is 2.3. MacOS ships that version, and will
continue doing so for the forseeable future because of Apple's policy
regarding GPLv3. While Mac users could use a
Add jsonpath_gram.h to list of distprep targets
Oversight in dac048f71e
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/96683db880cab7791006fcc13416d67f6230a2f7
Modified Files
--
src/backend/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Add b2e6e7682 to .git-blame-ignore-revs
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b289b86231ad10fb317231ff85596d6272203916
Modified Files
--
.git-blame-ignore-revs | 3 +++
1 file changed, 3 insertions(+)
Run perltidy over Catalog.pm
Commit 69eb643b2 deliberately left indentation unchanged to make the changes
more legible. Rather than waiting until next year's perltidy run, do it now
to avoid confusion
Per suggestion from Álvaro Herrera
Discussion:
Parse catalog .dat files as a whole when compiling the backend
Previously Catalog.pm eval'd each individual hash reference
so that comments and whitespace can be preserved when running
reformat-dat-files. This is unnecessary when building, and we can save
~15% off the run time of genbki.pl by
Fix cplusplusscheck in vpath builds
Same solution as 829906fb6.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/cec2754fbebee0a40aaf905947deb823cca4fe39
Modified Files
--
src/tools/pginclude/cpluspluscheck | 2 ++
1 file changed, 2 insertions(+)
Fix headerscheck in vpath builds
Oversight in dac048f71e per buildfarm animal crake.
Fix per suggestion from Andrew Dunstan.
Discussion:
https://www.postgresql.org/message-id/e3f4a3d0-dfcc-41cc-1ed2-acc15700ddef%40dunslane.net
Branch
--
master
Details
---
Fix failure to maintainer-clean jsonpath_gram.h
Oversight in dac048f71e
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/eac76cc012aa4888e882287baae791429396b403
Modified Files
--
src/backend/Makefile | 1 +
1 file changed, 1 insertion(+)
I see why I couldn't reproduce: I neglected to add jsonpath_gram.h to
the backend's maintainer-clean so it failed to be deleted. Working on
the fix now.
--
John Naylor
EDB: http://www.enterprisedb.com
rser (see src/backend/Makefile), and included as parser/gram.h.
>
> I think this could be addressed by always adding something like
> -iquote $builddir/$(dirname "$f") -iquote $srcdir/$(dirname
> "$f") \
> to cpluspluscheck/headerscheck.
--
John Naylor
EDB: http://www.enterprisedb.com
check before building, the first thing you get is
fatal error: utils/errcodes.h: No such file or directory
so not sure what you mean.
--
John Naylor
EDB: http://www.enterprisedb.com
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan wrote:
>
>
> On 2022-09-04 Su 02:19, John Naylor wrote:
> > Crake fails with
> >
> > headerscheck:
> > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
> > Sep 04 01:56:01
> > /home
Add missing exceptions to cpluspluscheck
dac048f71 added exceptions to headerscheck but failed to do the
same for cpluspluscheck
Per report from Andres Freund regarding CI
Discussion:https://www.postgresql.org/message-id/20220904205743.y3ntq6ij3aibmxvy%40awork3.anarazel.de
Branch
--
master
/backend/utils/adt/*)
>
> EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;
Okay, I'll look at this and the cpp header check within 24 hours.
--
John Naylor
EDB: http://www.enterprisedb.com
On Sun, Sep 4, 2022 at 4:36 PM John Naylor wrote:
>
> For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
> something like the following is needed:
>
> --- a/src/tools/msvc/Mkvcbuild.pm
> +++ b/src/tools/msvc/Mkvcbuild.pm
> @@ -362,6 +3
Fix MSVC linker error for specparse.obj
Per buildfarm animals drongo
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/92e7b7722da98eb4d54df7d4f850eee6a5fe9eef
Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 1 +
1 file changed, 1 insertion(+)
1 - 100 of 207 matches
Mail list logo
