RE: Monetary Data Types Improvement

2024-03-21 Thread Brian Powell Jr
. Katz Sent: Thursday, March 21, 2024 3:12 PM To: Dave Cramer ; Erik Wienhold Cc: David Rowley ; b.powell...@outlook.com; pgsql-docs@lists.postgresql.org Subject: Re: Monetary Data Types Improvement On 3/20/24 11:07 AM, Dave Cramer wrote: > > > On Wed, 20 Mar 2024 at 10:59, Erik

Re: Monetary Data Types Improvement

2024-03-21 Thread Jonathan S. Katz
On 3/20/24 11:07 AM, Dave Cramer wrote: On Wed, 20 Mar 2024 at 10:59, Erik Wienhold > wrote: On 2024-03-18 23:24 +0100, David Rowley wrote: > My vote would go to adding a deprecation notice to that section of the > docs.  There's some talk [1] about

Re: Monetary Data Types Improvement

2024-03-20 Thread Dave Cramer
On Wed, 20 Mar 2024 at 10:59, Erik Wienhold wrote: > On 2024-03-18 23:24 +0100, David Rowley wrote: > > My vote would go to adding a deprecation notice to that section of the > > docs. There's some talk [1] about how we discourage the usage of the > > money type and that goes on to discuss the

Re: Monetary Data Types Improvement

2024-03-20 Thread Erik Wienhold
On 2024-03-18 23:24 +0100, David Rowley wrote: > My vote would go to adding a deprecation notice to that section of the > docs. There's some talk [1] about how we discourage the usage of the > money type and that goes on to discuss the possibilities of moving it > into a contrib module. > > My

Re: Monetary Data Types Improvement

2024-03-18 Thread David Rowley
On Tue, 19 Mar 2024 at 07:43, Erik Wienhold wrote: > Maybe add a note like: > > "Money does not implement all operators that one might expect of a > numeric type. For example, use (-amount::money::numeric)::money to > negate amount." > > That would also fit nicely with the existing examples on

Re: Monetary Data Types Improvement

2024-03-18 Thread Erik Wienhold
I wrote: > The attached patch does that. Hit send to early. -- Erik >From 281e684b242314d93120faf875c1456ecdddef2b Mon Sep 17 00:00:00 2001 From: Erik Wienhold Date: Mon, 18 Mar 2024 19:38:53 +0100 Subject: [PATCH v1] Add note about missing money operators --- doc/src/sgml/datatype.sgml | 10

Re: Monetary Data Types Improvement

2024-03-18 Thread Erik Wienhold
On 2024-03-17 03:16 +0100, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/datatype-money.html > Description: > > It's not explicitly obvious that money doesn't behave like a normal numeric > type in

Monetary Data Types Improvement

2024-03-18 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/datatype-money.html Description: It's not explicitly obvious that money doesn't behave like a normal numeric type in that executing a procedure with a negative numeric value for money