Re: pgsql: Add option to use ICU as global locale provider

On Fri, Mar 18, 2022 at 03:09:59PM -0700, Andres Freund wrote: > Hi, > > On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote: > > Why does your patch introduce a function check_icu_locale() that is only > > called once? Did you have further plans for that? > > I like that it moves ICU code out

Re: logical replication empty transactions

On Thu, Mar 17, 2022 at 10:43 PM Amit Kapila wrote: > > Review comments/suggestions: > = > 1. Isn't it sufficient to call pgoutput_send_begin from > maybe_send_schema as that is commonplace for all others and is always > the first message we send? If so, I think we can

Re: Replication slot drop message is sent after pgstats shutdown.

On Fri, Mar 18, 2022 at 01:24:15PM -0700, Andres Freund wrote: > On 2022-03-18 00:28:37 -0700, Noah Misch wrote: > > === > > diff -U3 > > /export/home/nm/farm/studio64v12_6/HEAD/pgsql/contrib/test_decoding/expected/slot_creation_error.out > > > >

Re: ICU for global collation

Hi, On 2022-03-17 14:14:52 +0100, Peter Eisentraut wrote: > committed, thanks Just noticed that this adds a new warning when building with -O3: In file included from /home/andres/src/postgresql/src/include/catalog/pg_collation.h:22, from

Re: [PATCH] Add reloption for views to enable RLS

On Mon, 14 Mar 2022 at 16:16, Laurenz Albe wrote: > > The patch is fine from my point of view. > > It passes "make check-world". > > I'll mark it as "ready for committer". > Cool, thanks. I think this will make a useful addition to PG15. I have been hacking on it a bit, and attached is an

Re: pgsql: Add option to use ICU as global locale provider

On Fri, Mar 18, 2022 at 04:04:10PM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > Another option is that we just don't do the check in initdb. As the > > tests show, you will then get an error from the backend call, so it's > > really just a question of when the error is reported. > > +1

Re: Allow parallel plan for referential integrity checks?

I looked at your patch and it's a good idea to make foreign key validation use parallel query on large relations. It would be valuable to add logging to ensure that the ActiveSnapshot and TransactionSnapshot is the same for the leader and the workers. This logging could be tested in the TAP

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

Hi, This is a long thread, sorry for asking if this has been asked before. On 2022-03-08 20:25:28 +0530, Nitin Jadhav wrote: >* Sort buffers that need to be written to reduce the likelihood of > random > @@ -2129,6 +2132,8 @@ BufferSync(int flags) > bufHdr =

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

Hi, First look at this patch, so I might be repeating stuff already commented on / discussed. On 2022-03-17 13:25:35 +0530, Bharath Rupireddy wrote: > +-- > +-- pg_get_raw_wal_record() > +-- > +CREATE FUNCTION pg_get_raw_wal_record(IN in_lsn pg_lsn, > +OUT start_lsn pg_lsn, > +OUT

Re: Remove INT64_FORMAT in translatable strings

On Sat, 19 Mar 2022 at 01:12, Tom Lane wrote: > Japin Li writes: >> we can rely on %lld/%llu and we decided to use them in translatable strings. > > Seems like good cleanup, so pushed. I think though that project style > is to use "long long" or "unsigned long long", without the unnecessary >

Re: Support logical replication of DDLs

On Sat, 19 Mar 2022 at 01:25, Zheng Li wrote: > Hello, > > Thanks for the quick review! > >> And, when I try to use git am to apply the patch, it complains: >> >> $ git am ~/0001-syntax-pg_publication-pg_dump-ddl_replication.patch >> Patch format detection failed. > > git apply

Re: Add 64-bit XIDs into PostgreSQL 15

Hi, On 2022-03-18 18:22:00 +0300, Maxim Orlov wrote: > Here is v22 with following changes: > - use explicit unsigned long long cast for printf/elog XIDs instead of > macro XID_TYPE > - add *.po localization > - fix forgotten XIDs format changes in pg_resetwal.c > - 0006 patch refactoring FWIW,

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

Hi, On 2022-03-18 18:14:52 +0300, Maxim Orlov wrote: > Subject: [PATCH v22 3/6] Use 64-bit pages in SLRU > > This is one step toward 64-bit XIDs. I think this should explain in more detail why this move is done. Neither the commit message nor the rest of the thread does so afaics. It's not too

Re: Fix unsigned output for signed values in SLRU error reporting

Hi, On 2022-03-18 22:52:02 +0400, Pavel Borisov wrote: > I've noticed that in SRLU error reporting both signed and unsigned values > are output as %u. I think it is worth correcting this with the very simple > patch attached. Afaics offset etc can't be negative, so I don't think this really

Re: add checkpoint stats of snapshot and mapping files of pg_logical dir

Hi, On 2022-03-18 13:32:52 +0530, Bharath Rupireddy wrote: > @@ -6115,46 +6116,81 @@ LogCheckpointEnd(bool restartpoint) > CheckpointStats.ckpt_sync_rels; > average_msecs = (long) ((average_sync_time + 999) / 1000); > > + initStringInfo(); > + > if

Re: Adding CI to our tree

Hi, Pushed 0001, 0002. Only change I made was to add DEBIAN_FRONTEND=noninteractive to the apt-get invocations, because some packages will fail / complain verbosely if there's no interactive prompt during installation. Greetings, Andres Freund

Re: speed up a logical replica setup

On 3/15/22 09:51, Peter Eisentraut wrote: > On 21.02.22 13:09, Euler Taveira wrote: >> A new tool called pg_subscriber does this conversion and is tightly >> integrated >> with Postgres. > > Are we comfortable with the name pg_subscriber?  It seems too general. > Are we planning other

Re: Out-of-tree certificate interferes ssltest

On 3/17/22 21:02, Michael Paquier wrote: > On Thu, Mar 17, 2022 at 02:28:49PM +0100, Daniel Gustafsson wrote: >> One small concern though. This hunk: >> >> +my $default_ssl_connstr = "sslkey=invalid sslcert=invalid >> sslrootcert=invalid sslcrl=invalid sslcrldir=invalid"; >> + >>

Re: pgsql: Add option to use ICU as global locale provider

Hi, On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote: > Why does your patch introduce a function check_icu_locale() that is only > called once? Did you have further plans for that? I like that it moves ICU code out of dbcommands.c - imo there should be few calls to ICU functions outside of

Re: New Object Access Type hooks

On 3/18/22 11:15, Mark Dilger wrote: > >> On Mar 18, 2022, at 7:16 AM, Joshua Brindle >> wrote: >> >> This is great, thank you for doing this. I didn't even realize the OAT >> hooks had no regression tests. >> >> It looks good to me, I reviewed both and tested the module. I wonder >> if the

Re: add checkpoint stats of snapshot and mapping files of pg_logical dir

On Fri, Mar 18, 2022 at 01:32:52PM +0530, Bharath Rupireddy wrote: > Well, here's the v5 patch, sample output at [1]. Please have a look at it. I think this is on the right track, but I would even take it a step further by separating each group of information: if (restartpoint)

Re: Probable CF bot degradation

> > confused Cirrus. 路 There is already another build for 3489 that is > almost finished now so I don't think that stale TRIGGERED one is > stopping anything from working and I guess it will eventually go away > by itself somehow... > Indeed, I saw this now. No problem anymore. Thanks! -- Best

Re: Probable CF bot degradation

On Sat, Mar 19, 2022 at 9:41 AM Pavel Borisov wrote: >> >> remote: Internal Server Error >> To github.com:postgresql-cfbot/postgresql.git >> ! [remote rejected] commitfest/37/3489 -> commitfest/37/3489 >> (Internal Server Error) >> error: failed to push some refs to >>

Re: [PATCH] Add native windows on arm64 support

On Wed, Feb 23, 2022 at 11:09 PM Niyas Sait wrote: > I have created a patch that adds support for building Postgres for the > windows/arm64 platform using the MSVC toolchain. Following changes have been > included > > 1. Extend MSVC scripts to handle ARM64 platform. > 2. Add arm64 definition of

Re: Probable CF bot degradation

> > remote: Internal Server Error > To github.com:postgresql-cfbot/postgresql.git > ! [remote rejected] commitfest/37/3489 -> commitfest/37/3489 > (Internal Server Error) > error: failed to push some refs to 'github.com: > postgresql-cfbot/postgresql.git' > I am seeing commitfest/37/3489 in

Re: Replication slot drop message is sent after pgstats shutdown.

Hi, On 2022-03-18 00:28:37 -0700, Noah Misch wrote: > On Tue, Feb 15, 2022 at 08:58:56AM -0800, Andres Freund wrote: > > Pushed the test yesterday evening, after Tom checked if it is likely to be > > problematic. Seems to worked without problems so far. > > wrasse│ 2022-02-15 09:29:06 │

Re: Proposal: Support custom authentication methods using hooks

Hi, On 2022-03-18 15:23:21 -0400, Stephen Frost wrote: > * Andres Freund (and...@anarazel.de) wrote: > > On 2022-03-18 00:45:49 -0400, Stephen Frost wrote: > > > > I also don’t think that I agree that it’s acceptable to only have the > > > > > ability to extend the authentication on the server

Re: pgsql: Add option to use ICU as global locale provider

Peter Eisentraut writes: > Another option is that we just don't do the check in initdb. As the > tests show, you will then get an error from the backend call, so it's > really just a question of when the error is reported. +1 ... seems better to not have two copies of the code.

Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

"Euler Taveira" writes: > On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote: >> I added a patch to fix table_to_xmlschema, could you point me how to add a >> unit test to that? > You should edit src/test/regress/expected/xmlmap.out. In this case, you should > also modify

Re: pgsql: Add option to use ICU as global locale provider

On 18.03.22 10:27, Julien Rouhaud wrote: I'm attaching a patch that fixes both issues for me with ICU 50. Note that there's already a test that would have failed for CREATE DATABASE if initdb tests didn't fail first, so no new test needed. I ended up copy/pasting icu_set_collation_attributes()

Re: Proposal: Support custom authentication methods using hooks

Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2022-03-18 00:45:49 -0400, Stephen Frost wrote: > > > I also don’t think that I agree that it’s acceptable to only have the > > > > ability to extend the authentication on the server side as that implies > > > > a > > > > whole bunch of

Re: Tab completion for SET TimeZone

... btw, I forgot to mention that I don't see any problem with the patch's behavior for DEFAULT. What I see with both readline and libedit is that if you type something reasonable, like set timezone to d then it will correctly complete "efault ", without any extra quotes. Now, if you're

Re: Tab completion for SET TimeZone

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes: > I just realised there's no point in the subselect when I'm not applying > the same function in the WHERE and the SELECT, so here's an updated > version that simplifies that. It also fixes a typo in the commit > message. This doesn't work right

Re: Probable CF bot degradation

On Sat, Mar 19, 2022 at 5:07 AM Julien Rouhaud wrote: > On Fri, Mar 18, 2022 at 07:43:47PM +0400, Pavel Borisov wrote: > > Hi, hackers! > > I've noticed that CF bot hasn't been running active branches from yesterday: > > https://github.com/postgresql-cfbot/postgresql/branches/active > > > > Also,

Fix unsigned output for signed values in SLRU error reporting

Hi, hackers! I've noticed that in SRLU error reporting both signed and unsigned values are output as %u. I think it is worth correcting this with the very simple patch attached. Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com

Re: [PATCH] pgbench: add multiconnect option

The current version of the patch does not apply, so I could not test it. Here are some comments I have. Pgbench is a simple benchmark tool by design, and I wonder if adding a multiconnect feature will cause pgbench to be used incorrectly. A real world use-case will be helpful for this thread.

Re: Remove INT64_FORMAT in translatable strings

On Fri, Mar 18, 2022 at 01:12:40PM -0400, Tom Lane wrote: > Japin Li writes: > > we can rely on %lld/%llu and we decided to use them in translatable strings. > > Seems like good cleanup, so pushed. I think though that project style > is to use "long long" or "unsigned long long", without the

Re: Support logical replication of DDLs

Hello, Thanks for the quick review! > And, when I try to use git am to apply the patch, it complains: > > $ git am ~/0001-syntax-pg_publication-pg_dump-ddl_replication.patch > Patch format detection failed. git apply works for me. I'm not sure why git am complains. I also

Re: a misbehavior of partition row movement (?)

On Fri, Mar 18, 2022 at 9:38 AM Alvaro Herrera wrote: > I rebased this patch; v15 attached. Other than fixing the (very large) > conflicts due to nodeModifyTable.c rework, the most important change is > moving GetAncestorResultRels into execMain.c and renaming it to have the > "Exec-" prefix.

Re: Remove INT64_FORMAT in translatable strings

Japin Li writes: > we can rely on %lld/%llu and we decided to use them in translatable strings. Seems like good cleanup, so pushed. I think though that project style is to use "long long" or "unsigned long long", without the unnecessary "int" --- it certainly makes little sense to do it both

Re: Column Filtering in Logical Replication

On 3/18/22 15:43, Tomas Vondra wrote: > > > On 3/18/22 06:52, Amit Kapila wrote: >> On Fri, Mar 18, 2022 at 12:47 AM Tomas Vondra >> wrote: >>> >>> I pushed the second fix. Interestingly enough, wrasse failed in the >>> 013_partition test. I don't see how that could be caused by this >>>

Re: a misbehavior of partition row movement (?)

I rebased this patch; v15 attached. Other than fixing the (very large) conflicts due to nodeModifyTable.c rework, the most important change is moving GetAncestorResultRels into execMain.c and renaming it to have the "Exec-" prefix. The reason is that what this code is doing is affect struct

Re: Add 64-bit XIDs into PostgreSQL 15

Hi, hackers! While working on the patchset I've noticed that FullTransactionId lost its semantics in its scope. TransactionId is supposed to be 64bit (default) and epoch approach becomes outdated. What do you think of fully removing FullTransactionId and its support functions and macro? -- Best

Re: Probable CF bot degradation

Hi, On Fri, Mar 18, 2022 at 07:43:47PM +0400, Pavel Borisov wrote: > Hi, hackers! > I've noticed that CF bot hasn't been running active branches from yesterday: > https://github.com/postgresql-cfbot/postgresql/branches/active > > Also, there is no new results on the current CF page on cputube. >

Re: On login trigger: take three

> On 18 Mar 2022, at 08:24, a.soko...@postgrespro.ru wrote: > - auth_extra => [ '--create-role', 'repl_role' ]); > + auth_extra => [ '--create-role', 'repl_role,regress_user' ]); Looking at the test in question it's not entirely clear to me what the original author really

Remove INT64_FORMAT in translatable strings

Hi, I found the following lines in pg_backup_tar.c. if (len != th->fileLen) { charbuf1[32], buf2[32]; snprintf(buf1, sizeof(buf1), INT64_FORMAT, (int64) len); snprintf(buf2, sizeof(buf2), INT64_FORMAT, (int64) th->fileLen);

Probable CF bot degradation

Hi, hackers! I've noticed that CF bot hasn't been running active branches from yesterday: https://github.com/postgresql-cfbot/postgresql/branches/active Also, there is no new results on the current CF page on cputube. I don't know if it is a problem or kind of scheduled maintenance though. --

Re: New Object Access Type hooks

> On Mar 18, 2022, at 7:16 AM, Joshua Brindle > wrote: > > This is great, thank you for doing this. I didn't even realize the OAT > hooks had no regression tests. > > It looks good to me, I reviewed both and tested the module. I wonder > if the slight abuse of subid is warranted with brand

Re: Column Filtering in Logical Replication

On 3/18/22 06:52, Amit Kapila wrote: > On Fri, Mar 18, 2022 at 12:47 AM Tomas Vondra > wrote: >> >> I pushed the second fix. Interestingly enough, wrasse failed in the >> 013_partition test. I don't see how that could be caused by this >> particular commit, though - see the pgsql-committers

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

> > > To me personally v21 looks almost OK. > > For some reason I didn't receive the recent e-mails from Tom and Kyotaro. > I've just discovered them accidentally by reading the thread through the > web interface. These comments were not addressed in v21. > Aleksander, as of now we're preparing a

Re: pg_walinspect - a new extension to get raw WAL data and WAL stats

Hi Bharath, Due to recent commits on master, the pg_walinpect module is not compiling. Kindly update the patch. pg_walinspect.c: In function ‘GetXLogRecordInfo’: pg_walinspect.c:362:39: error: ‘XLogReaderState’ {aka ‘struct XLogReaderState’} has no member named ‘max_block_id’ 362 | for

Re: New Object Access Type hooks

On Thu, Mar 17, 2022 at 11:21 PM Mark Dilger wrote: > > Hackers, > > Over in [1], Joshua proposed a new set of Object Access Type hooks based on > strings rather than Oids. > > His patch was written to be applied atop my patch for granting privileges on > gucs. > > On review of his patch, I

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

Hi hackers, > Here is an new version with the following changes compared to v20: > [...] > To me personally v21 looks almost OK. For some reason I didn't receive the recent e-mails from Tom and Kyotaro. I've just discovered them accidentally by reading the thread through the web interface. These

Re: PROPOSAL: Support global and local disabling of indexes

Just wanted to mention that this would be a useful feature for me. Had previously been bitten by this: https://www.postgresql.org/message-id/flat/CAMjNa7c4pKLZe%2BZ0V49isKycnXQ6Y%3D3BO-4Gsj3QAwsd2r7Wrw%40mail.gmail.com Ended up "solving" by putting a where clause on all my exclusion constraints I

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

> > > I don't get it. The checkpoint flags and the view flags (set by > > > pgstat_progrss_update*) are different, so why can't we add this flag to > > > the > > > view flags? The fact that checkpointer.c doesn't update the passed flag > > > and > > > instead look in the shmem to see if

Re: Commitfest Update

On Fri, Mar 18, 2022 at 3:08 AM Greg Stark wrote: > In case anyone's looking for inspiration... Here are the list of > patches marked Ready for Committer: > * Fast COPY FROM command for the foreign tables I have (re-)started reviewing this patch. Best regards, Etsuro Fujita

Re: support for MERGE

On 17.03.22 12:31, Alvaro Herrera wrote: 0001 pushed. Here's 0002 again for cfbot, with no changes other than pgindent cleanup. I did a cursory read through and want to offer some trivial amendments in the attached patches. The 0001 adds back various serial commas, the 0002 is assorted

Re: Logical replication timeout problem

On Fri, Mar 18, 2022 at 10:43 AM wangw.f...@fujitsu.com wrote: > > On Thu, Mar 17, 2022 at 7:52 PM Masahiko Sawada wrote: > > > > Attach the new patch. > * case REORDER_BUFFER_CHANGE_INVALIDATION: - /* Execute the invalidation messages locally */ - ReorderBufferExecuteInvalidations( -

Re: Support logical replication of DDLs

On Fri, 18 Mar 2022 at 08:18, Zheng Li wrote: > Hello, > > Attached please find the broken down patch set. Also fixed the failing > TAP tests Japin reported. > Here are some comments for the new patches: Seems like you forget initializing the *ddl_level_given after entering the

Re: Tab completion for SET TimeZone

Dagfinn Ilmari Mannsåker writes: > Tom Lane writes: > >> Also, personally, I'd rather not smash the names to lower case. >> I think that's a significant decrement of readability. > > That was mainly for convenience of not having to capitalise the place > names when typing (since they are

Re: pgsql: Add option to use ICU as global locale provider

(moving to -hackers) On Fri, Mar 18, 2022 at 03:40:51PM +0800, Julien Rouhaud wrote: > On Fri, Mar 18, 2022 at 02:36:48PM +0800, Julien Rouhaud wrote: > > On Fri, Mar 18, 2022 at 06:15:47PM +1300, Thomas Munro wrote: > > > > > > No idea what's happening here but one observation is that that

Re: Replication slot drop message is sent after pgstats shutdown.

At Fri, 18 Mar 2022 00:28:37 -0700, Noah Misch wrote in > === > diff -U3 > /export/home/nm/farm/studio64v12_6/HEAD/pgsql/contrib/test_decoding/expected/slot_creation_error.out > >

Re: PROPOSAL: Support global and local disabling of indexes

On Thu, Mar 17, 2022 at 11:16:24PM -0700, Paul Martinez wrote: > I propose adding an ALTER INDEX command that can enable or disable an > index on a global level: See also this thread: https://commitfest.postgresql.org/34/2937/

Re: MultiXact\SLRU buffers configuration

> On 20 Feb 2022, at 02:38, Thomas Munro wrote: > > Back to this patch: assuming we can settle on a good-enough-for-now > replacement algorithm, do we want to add this set of 7 GUCs? Does > anyone else want to weigh in on that? Hi Thomas! It seems we don't have any other input besides

Re: add checkpoint stats of snapshot and mapping files of pg_logical dir

On Fri, Mar 18, 2022 at 11:11 AM Bharath Rupireddy wrote: > > On Fri, Mar 18, 2022 at 2:15 AM Nathan Bossart > wrote: > > > > On Thu, Mar 17, 2022 at 06:48:43PM +0530, Bharath Rupireddy wrote: > > > Personally, I tend to agree with v4-0001 (option (4)) or v4-0002 > > > (option (3)) than v4-0003

Re: [PATCH] Accept IP addresses in server certificate SANs

At Thu, 17 Mar 2022 21:55:07 +, Jacob Champion wrote in > On Wed, 2022-03-16 at 23:49 +, Jacob Champion wrote: > > Thank you for the explanation -- the misunderstanding was all on my > > end. I thought you were asking me to move the check_cn assignment > > instead of copying it to the

Re: DSA failed to allocate memory

> > So it's OK for a segment to be in a bin that suggests that it has more > consecutive free pages than it really does. But it's NOT ok for a > segment to be in a bin that suggests it has fewer consecutive pages > than it really does. If dsa_free() is putting things back into the > wrong place,

Re: Replication slot drop message is sent after pgstats shutdown.

On Tue, Feb 15, 2022 at 08:58:56AM -0800, Andres Freund wrote: > Pushed the test yesterday evening, after Tom checked if it is likely to be > problematic. Seems to worked without problems so far. wrasse│ 2022-02-15 09:29:06 │ HEAD │

Re: On login trigger: take three

Daniel Gustafsson писал 2022-03-15 23:52: Yeah, that was the previously posted v25 from the author (who adopted it from the original author). I took the liberty to quickly poke at the review comments you had left as well as the ones that I had found to try and progress the patch. 0001

Re: POC: GROUP BY optimization

On 3/15/22 13:26, Tomas Vondra wrote: Thanks for the rebase. The two proposed changes (tweaked costing and simplified fake_var handling) seem fine to me. I think the last thing that needs to be done is cleanup of the debug GUCs, which I added to allow easier experimentation with the patch.

Re: ICU for global collation

On Thu, Mar 17, 2022 at 02:14:52PM +0100, Peter Eisentraut wrote: > On 17.03.22 13:01, Shinoda, Noriyoshi (PN Japan FSIP) wrote: > > Thank you to all the developers. > > I found that the description of the pg_database.daticulocale column was not > > written in the documentation. > > The attached

Re: PROPOSAL: Support global and local disabling of indexes

Hi, On Thu, Mar 17, 2022 at 11:16:24PM -0700, Paul Martinez wrote: > > Adding and removing indexes is a regular part of database maintenance, > but in a large database, removing an index can be a very risky operation. > Removing the wrong index could have disastrous consequences for >

PROPOSAL: Support global and local disabling of indexes

Hey, hackers, Adding and removing indexes is a regular part of database maintenance, but in a large database, removing an index can be a very risky operation. Removing the wrong index could have disastrous consequences for performance, and it could take tens of minutes, or even hours, to rebuild

Re: Tab completion for ALTER MATERIALIZED VIEW ... SET ACCESS METHOD

On Fri, Mar 18, 2022 at 10:27:41AM +0900, Yugo NAGATA wrote: > I added some queries in the regression test. Attached is the updated patch. Thanks. This looks rather sane to me. I'll split things into 3 commits in total, as of the psql completion, SET TABLESPACE and SET ACCESS METHOD. The first